)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"709606b73b3cec5dbbc3da2eff04f6530cf8c26e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make ironic-python-agent-builder packaging-friendly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Install dib and tinyipa files to /usr/share"},{"line_number":10,"context_line":"* Add an executable that can be installed into /usr/bin"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Since we now have python code, make pep8 operational."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_da640a24","line":9,"updated":"2019-08-12 13:18:43.000000000","message":"remove tinyipa as it\u0027s not installed under /usr/share","commit_id":"3f93fe8906fee168595eb60891be848f9828578e"}],"ironic_python_agent_builder/__init__.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4761af7cf2d0731e7f3a5502d0a3a57b5adb67e1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                               \u0027ironic-python-agent-ramdisk\u0027,"},{"line_number":48,"context_line":"                               args.distribution] + args.element)"},{"line_number":49,"context_line":"    except OSError as exc:"},{"line_number":50,"context_line":"        sys.exit(str(exc) + \u0027\\nIs diskimage-builder installed?\u0027)"},{"line_number":51,"context_line":"    except subprocess.CalledProcessError as exc:"},{"line_number":52,"context_line":"        sys.exit(str(exc))"},{"line_number":53,"context_line":"    except KeyboardInterrupt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5a1eda74","line":50,"updated":"2019-08-12 13:15:32.000000000","message":"Is there a reason we don\u0027t just add dib to requirements.txt?","commit_id":"3f93fe8906fee168595eb60891be848f9828578e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dde4510304b5e9cbf29fbe1c164e6f1390dc8c4c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                               \u0027ironic-python-agent-ramdisk\u0027,"},{"line_number":48,"context_line":"                               args.distribution] + args.element)"},{"line_number":49,"context_line":"    except OSError as exc:"},{"line_number":50,"context_line":"        sys.exit(str(exc) + \u0027\\nIs diskimage-builder installed?\u0027)"},{"line_number":51,"context_line":"    except subprocess.CalledProcessError as exc:"},{"line_number":52,"context_line":"        sys.exit(str(exc))"},{"line_number":53,"context_line":"    except KeyboardInterrupt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_bc2eeb89","line":50,"in_reply_to":"7faddb67_5a1eda74","updated":"2019-08-12 13:22:04.000000000","message":"We can, but it won\u0027t help in cases when pip is not used (e.g. packaging).","commit_id":"3f93fe8906fee168595eb60891be848f9828578e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e9d4df963eabf13b8f72c50838e8d239635fd062","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                               \u0027ironic-python-agent-ramdisk\u0027,"},{"line_number":48,"context_line":"                               args.distribution] + args.element)"},{"line_number":49,"context_line":"    except OSError as exc:"},{"line_number":50,"context_line":"        sys.exit(str(exc) + \u0027\\nIs diskimage-builder installed?\u0027)"},{"line_number":51,"context_line":"    except subprocess.CalledProcessError as exc:"},{"line_number":52,"context_line":"        sys.exit(str(exc))"},{"line_number":53,"context_line":"    except KeyboardInterrupt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9c6bef83","line":50,"in_reply_to":"7faddb67_5c5ed7e9","updated":"2019-08-12 13:31:03.000000000","message":"It\u0027s manual process, but yes, it is used for that.","commit_id":"3f93fe8906fee168595eb60891be848f9828578e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"31208af61c6612c6b4bcf71a263802425ed18ddd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                               \u0027ironic-python-agent-ramdisk\u0027,"},{"line_number":48,"context_line":"                               args.distribution] + args.element)"},{"line_number":49,"context_line":"    except OSError as exc:"},{"line_number":50,"context_line":"        sys.exit(str(exc) + \u0027\\nIs diskimage-builder installed?\u0027)"},{"line_number":51,"context_line":"    except subprocess.CalledProcessError as exc:"},{"line_number":52,"context_line":"        sys.exit(str(exc))"},{"line_number":53,"context_line":"    except KeyboardInterrupt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5c5ed7e9","line":50,"in_reply_to":"7faddb67_bc2eeb89","updated":"2019-08-12 13:30:08.000000000","message":"I would hope that requirements.txt is used to build dependencies in packaging so users wouldn\u0027t need to check if it\u0027s installed :)","commit_id":"3f93fe8906fee168595eb60891be848f9828578e"}]}