)]}'
{"id":"openstack%2Fironic-python-agent-builder~684752","triplet_id":"openstack%2Fironic-python-agent-builder~master~Ibe744121b863ef1265e5e3ead7ab13fef0855fc6","project":"openstack/ironic-python-agent-builder","branch":"master","topic":"gate","hashtags":[],"change_id":"Ibe744121b863ef1265e5e3ead7ab13fef0855fc6","subject":"Correct usage of BUILD_AND_INSTALL_TINYIPA","status":"MERGED","created":"2019-09-25 13:54:41.000000000","updated":"2019-09-25 22:35:10.000000000","submitted":"2019-09-25 22:33:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"684752-1569450817581-94a46b85","meta_rev_id":"e6cf5fe1f95bdd1f18774f29cbdb21c96887c299","_number":684752,"virtual_id_number":684752,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-25 22:33:37.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-25 18:59:12.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":2,"date":"2019-09-25 14:01:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":2,"date":"2019-09-25 14:13:41.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":1,"date":"2019-09-25 14:13:41.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-25 14:01:57.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"},{"updated":"2019-09-25 14:13:41.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2019-09-25 22:33:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"da83a9c9d6d075d5362ab907686a783ba7e01430","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-09-25 13:54:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"32b6fd7592b3ac223a7909fda54349224cb0c790","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2019-09-25 14:01:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9b53f8a9d80d1c4fda0539c587d65f3e8da895ba","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-09-25 14:11:59.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"efce1e205e7c405a42554523dbc0af6b44b44a8f","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2019-09-25 14:13:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nGood with follow up, if any. Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"a3b7cfecccb3d4f516be22203997e9350a3f5a0c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 15:45:54.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6416b2f00390423f81ffb044f9661088 : SUCCESS in 6m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6ebe4475d00a4752af1562463ea44847 : SUCCESS in 4m 13s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/9f8d5584ff4e47a29572f9caceb87e68 : FAILURE in 1h 25m 45s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/8060760266474f4a97d843c8edc8397f : SUCCESS in 1h 09m 06s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/2d931ed802ee413bb11e08c09238410b : SUCCESS in 1h 25m 12s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/b64d73d954564c558b5f313f7ec693a4 : SUCCESS in 1h 01m 45s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/d748e50735e74251b27cb7ab081cb4d8 : SUCCESS in 1h 01m 24s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/4043992b6e4d4c529e60562c0176e7b7 : SUCCESS in 17m 49s\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/b42eb0e835374748b733d74d9bcd09f0 : SUCCESS in 12m 34s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/71a5022dfc6447d6951d576d4be3173d : FAILURE in 1h 10m 30s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/d962481cb8bc40ceb98bdbef1b8c3eb1 : SUCCESS in 1h 44m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e185320e1045320014561e1ead6edc8d596d8218","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-09-25 18:59:12.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"03b099d81f069e64b113aa03f6daad0853dd9533","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 20:56:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/38d67e299dfd41668f23d14094bc3a97 : SUCCESS in 6m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/348a89392b3545bda66bae56d1df75ff : SUCCESS in 3m 50s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/b0f260480241442587214486b5dfcee1 : SUCCESS in 1h 25m 52s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/f919ebe632a54b86a914292b94d091a7 : SUCCESS in 1h 20m 54s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/12d7e110966e4f34b4f897d3d689c735 : SUCCESS in 1h 08m 29s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/f98e7b3e1ea04082bcfaa14d4511a971 : SUCCESS in 57m 11s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/16b14666355044c083d62bcaab93a42e : SUCCESS in 1h 18m 49s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/ab633c15cbb140aeb6b6647fefa12c63 : SUCCESS in 14m 58s\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/8ab8bbc21d924b92a032359c15b3be26 : SUCCESS in 9m 58s\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/85b73408227f4cb2bfae57aa742a84b2 : SUCCESS in 1h 28m 02s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/aab6566f844a45398700e5959b538a54 : SUCCESS in 1h 49m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"94684af2d52515bd6995b8c03a994cecb232e463","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 20:56:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"995d57b1031943df82bfb629fa29b5c7ece2d0f7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 22:33:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"01109666c59fe0057c1c2b3803e2326775259255","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 22:33:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09513b60ae9a44e19c923f9bc1936954 : SUCCESS in 6m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1c5a0be7b0b94a98b27d956fae929757 : SUCCESS in 3m 02s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/fdbeeaf2447a4d809a2773d5909ce2d8 : SUCCESS in 1h 31m 07s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/571881ccb39f471587487f97255a42bd : SUCCESS in 1h 09m 25s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/095fe1c30c05461ead1e16e9d3a0775d : SUCCESS in 1h 18m 45s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/384ff96fb28b408e83a0e74d453d8f0c : SUCCESS in 1h 01m 38s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/4409e9c9741b4d08b1fe57bb8ac61c2d : SUCCESS in 1h 02m 32s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/2d108b946c6141bab2e309381498d0eb : SUCCESS in 18m 12s\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/edde7bea429d4ec0a7e6996ef30c34cf : SUCCESS in 10m 52s","accounts_in_message":[],"_revision_number":1},{"id":"97f7d4d8c70bd7171de14d5eaff96b39d32a4c68","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 22:35:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4bfca3e034c34b21a584ec2c6a20fb43 : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1eee1c17a4d4f4c9b2e424342d068a4617761d22","revisions":{"1eee1c17a4d4f4c9b2e424342d068a4617761d22":{"kind":"REWORK","_number":1,"created":"2019-09-25 13:54:41.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/52/684752/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent-builder","ref":"refs/changes/52/684752/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/52/684752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/52/684752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/52/684752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/52/684752/1"}}},"commit":{"parents":[{"commit":"cd89c0267117c1ace1fd33bca8c8c5ef21ac19dd","subject":"Merge \"CI: do not create UPLOAD_* directories when uploading images\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/cd89c0267117c1ace1fd33bca8c8c5ef21ac19dd"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-25 13:53:20.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-09-25 13:53:20.000000000","tz":120},"subject":"Correct usage of BUILD_AND_INSTALL_TINYIPA","message":"Correct usage of BUILD_AND_INSTALL_TINYIPA\n\nThis variable must be executable, so using True won\u0027t work. Since\ntrue is the default in finalise-tinyipa, remove the explicit setting\nfrom the role.\n\nAlso remove this variable from build-tinyipa since it\u0027s not used there\nand update the documentation accordingly.\n\nChange-Id: Ibe744121b863ef1265e5e3ead7ab13fef0855fc6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/1eee1c17a4d4f4c9b2e424342d068a4617761d22"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/1eee1c17a4d4f4c9b2e424342d068a4617761d22"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}