)]}'
{"tinyipa/build-iso.sh":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1811262f9447d11ab4844c29d5423fe67730b3be","unresolved":false,"context_lines":[{"line_number":6,"context_line":"SYSLINUX_URL\u003d\"https://www.kernel.org/pub/linux/utils/boot/syslinux/syslinux-${SYSLINUX_VERSION}.tar.gz\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"cd $WORKDIR/build_files"},{"line_number":9,"context_line":"wget -N $SYSLINUX_URL \u0026\u0026 tar zxf syslinux-${SYSLINUX_VERSION}.tar.gz"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"cd $WORKDIR"},{"line_number":12,"context_line":"rm -rf newiso"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_efaf839a","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":21},"updated":"2019-12-06 10:05:30.000000000","message":"Why not protect this variable too?\n\n```\nwget -N ${SYSLINUX_URL} \u0026\u0026 tar zxf syslinux-${SYSLINUX_VERSION}.tar.gz\n```\n\nElse work fine locally","commit_id":"a44f84aeefb5766ab77df4cbbf5470f27934cbbb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c0fa516316bbc5d961f6acf384f7508e92841898","unresolved":false,"context_lines":[{"line_number":6,"context_line":"SYSLINUX_URL\u003d\"https://www.kernel.org/pub/linux/utils/boot/syslinux/syslinux-${SYSLINUX_VERSION}.tar.gz\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"cd $WORKDIR/build_files"},{"line_number":9,"context_line":"wget -N $SYSLINUX_URL \u0026\u0026 tar zxf syslinux-${SYSLINUX_VERSION}.tar.gz"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"cd $WORKDIR"},{"line_number":12,"context_line":"rm -rf newiso"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_7a4b4f27","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":21},"in_reply_to":"3fa7e38b_1a26dbbb","updated":"2019-12-06 10:58:11.000000000","message":"Sure it work fine in the both versions, I\u0027m fine with the current version of your code. Feel free to keep that in the current state or to push a related follow-up if you choose to surround this var.\n\nThanks for your feedback","commit_id":"a44f84aeefb5766ab77df4cbbf5470f27934cbbb"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8e8a7fec22e59ee22db7de69b6ed3eaad8956de8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"SYSLINUX_URL\u003d\"https://www.kernel.org/pub/linux/utils/boot/syslinux/syslinux-${SYSLINUX_VERSION}.tar.gz\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"cd $WORKDIR/build_files"},{"line_number":9,"context_line":"wget -N $SYSLINUX_URL \u0026\u0026 tar zxf syslinux-${SYSLINUX_VERSION}.tar.gz"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"cd $WORKDIR"},{"line_number":12,"context_line":"rm -rf newiso"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_1a26dbbb","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":21},"in_reply_to":"3fa7e38b_efaf839a","updated":"2019-12-06 10:47:15.000000000","message":"I don\u0027t think it\u0027s really necessary here, the variable is isolated and expansion works just fine, there\u0027s no risk of ambiguity.\nI would do it just for sake of consistency.","commit_id":"a44f84aeefb5766ab77df4cbbf5470f27934cbbb"}]}