)]}'
{"id":"openstack%2Fironic-python-agent-builder~697638","triplet_id":"openstack%2Fironic-python-agent-builder~master~I54f0c027961f3ea46777cc0829ad80781e06c031","project":"openstack/ironic-python-agent-builder","branch":"master","topic":"syslinux-variable","hashtags":[],"change_id":"I54f0c027961f3ea46777cc0829ad80781e06c031","subject":"Use variables for syslinux in build-iso script","status":"MERGED","created":"2019-12-06 09:43:15.000000000","updated":"2020-01-03 03:35:46.000000000","submitted":"2020-01-03 03:34:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697638-1578022467856-b2b5e395","meta_rev_id":"9e34dd5ea0b687409492d7e08ab0cc24b0ae3e82","_number":697638,"virtual_id_number":697638,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"date":"2019-12-06 10:47:15.000000000","_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-03 03:34:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"recommended":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":1,"date":"2019-12-06 10:05:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":2,"date":"2020-01-03 02:07:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-11 17:12:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":1,"date":"2020-01-03 02:07:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-06 10:05:30.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2019-12-11 17:12:49.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-01-03 02:07:38.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"},{"updated":"2020-01-03 03:34:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ba3765699307ca26f33fc50b9924dba21d608d34","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-12-06 09:43:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"46304c684da512497aa73ba4c76aa2caca97d859","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-12-06 09:46:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1811262f9447d11ab4844c29d5423fe67730b3be","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-12-06 10:05:30.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nLGTM\n\nJust 1 suggestion inline","accounts_in_message":[],"_revision_number":2},{"id":"8e8a7fec22e59ee22db7de69b6ed3eaad8956de8","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-12-06 10:47:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c0fa516316bbc5d961f6acf384f7508e92841898","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-12-06 10:58:11.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9bdd2b8b6b4c79381c5171041e33bc4fd9eefbf9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-06 11:43:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c970375a0f042b58847681336f6f309 : SUCCESS in 4m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/069e86fd684048eeae85d84025199d26 : SUCCESS in 3m 23s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/5d2208f732324dc6a04b450393eaf947 : SUCCESS in 1h 49m 09s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/e56bc5aa69234aabb880049a48ea0242 : SUCCESS in 1h 03m 15s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/6952318840924ec59f6bb76282a3202f : SUCCESS in 1h 24m 03s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/55acc29ac4ae41fdaeef43f7073f5649 : SUCCESS in 1h 34m 27s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/917f65aba5da42e4a6c5c8555b56e4ae : SUCCESS in 1h 29m 28s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/b0248e61f64443bfb2dff083e765e1ce : SUCCESS in 18m 16s\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/772b7d8d939d46a686b0d62027579781 : SUCCESS in 23m 39s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/fbebd021719f43a1a09dea02289a7990 : FAILURE in 5m 34s (non-voting)\n- ironic-python-agent-check-image-dib-fedora https://zuul.opendev.org/t/openstack/build/79a807a755524946a98a65e4b1d2e98c : SUCCESS in 18m 47s (non-voting)\n- ironic-python-agent-check-image-dib-ubuntu https://zuul.opendev.org/t/openstack/build/78aad6896c5b4ff699b180f65adb3234 : SUCCESS in 9m 27s (non-voting)\n- ironic-python-agent-check-image-dib-debian https://zuul.opendev.org/t/openstack/build/6b68be2bbdeb48e4902e7b5270a1bc62 : SUCCESS in 7m 46s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/76ea72db57984dd5b834abb5a61fda0f : FAILURE in 57m 55s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/f842c21d0105486a9fac91da5ef600eb : SUCCESS in 1h 39m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"15bc3fff53055d0719128180a24ce31ff357474c","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-12-11 17:12:49.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cc7cfa9dd4deba2fc1657d3af1367d6638660a6a","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2020-01-03 02:07:38.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"48dcc91acce010bcb4b0dc5890663c401e755e9e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-03 02:07:49.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a11da7379e03ee99cd6b661f04f563bf41dc1e3d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-03 03:34:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5f19238387b04e713848d71179195a5af5946b9d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-03 03:34:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/22a7b48fc73246708abf6708e6e7c7c9 : SUCCESS in 5m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8f92559152884445b0d2697457381ffa : SUCCESS in 3m 10s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/be238f5b946e4fb7a9be3c12fd17f14d : SUCCESS in 1h 21m 22s\n- ipa-tempest-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/b5b9d453e8204a32b3454be3a97104fa : SUCCESS in 1h 03m 21s\n- ipa-tempest-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/df58991025054cb3a9ed1a97ceacc742 : SUCCESS in 1h 00m 31s\n- ipa-tempest-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/0973b03c735b43979b2e3470e4953a80 : SUCCESS in 1h 05m 01s\n- ipa-tempest-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/718cafcf20c14b9a8d41f0a48db749f6 : SUCCESS in 55m 34s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/96ba1559d6c54082b6a288ae16291fa4 : SUCCESS in 15m 22s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/0ad1d9a150514f128f8442b619431e5f : SUCCESS in 8m 45s","accounts_in_message":[],"_revision_number":2},{"id":"5932d7b7d65f89509b1355c4d4603c3894ed77f6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-03 03:35:46.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b691c5039b4d4d11b6d1a24bf2027915 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a44f84aeefb5766ab77df4cbbf5470f27934cbbb","revisions":{"3899eea5e88873929aa88754b80b5e35268487fd":{"kind":"REWORK","_number":1,"created":"2019-12-06 09:43:15.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/38/697638/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent-builder","ref":"refs/changes/38/697638/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/1"}}},"commit":{"parents":[{"commit":"0916598653c6192ce1d43717ec005bfd8baefc93","subject":"Add words on building image for other architecture","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/0916598653c6192ce1d43717ec005bfd8baefc93"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-12-06 09:38:29.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-12-06 09:42:35.000000000","tz":60},"subject":"Use variables for syslinux in build-iso script","message":"Use variables for syslinux in build-iso script\n\nConverting syslinux related version and download path to variables.\n\nChange-Id: I54f0c027961f3ea46777cc0829ad80781e06c031\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/3899eea5e88873929aa88754b80b5e35268487fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/3899eea5e88873929aa88754b80b5e35268487fd"}]},"branch":"refs/heads/master"},"a44f84aeefb5766ab77df4cbbf5470f27934cbbb":{"kind":"REWORK","_number":2,"created":"2019-12-06 09:46:07.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/38/697638/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent-builder","ref":"refs/changes/38/697638/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/38/697638/2"}}},"commit":{"parents":[{"commit":"0916598653c6192ce1d43717ec005bfd8baefc93","subject":"Add words on building image for other architecture","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/0916598653c6192ce1d43717ec005bfd8baefc93"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-12-06 09:38:29.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-12-06 09:46:00.000000000","tz":60},"subject":"Use variables for syslinux in build-iso script","message":"Use variables for syslinux in build-iso script\n\nConverting syslinux related version and download path to variables.\n\nChange-Id: I54f0c027961f3ea46777cc0829ad80781e06c031\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/a44f84aeefb5766ab77df4cbbf5470f27934cbbb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/a44f84aeefb5766ab77df4cbbf5470f27934cbbb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}