)]}'
{"dib/ironic-python-agent-ramdisk/install.d/ironic-python-agent-ramdisk-source-install/60-ironic-python-agent-ramdisk-install":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee126a07683b761abfb8b4df757774f342b239cd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"IPADIR\u003d/tmp/ironic-python-agent"},{"line_number":13,"context_line":"UPPER_CONSTRAINTS\u003d/tmp/requirements/upper-constraints.txt"},{"line_number":14,"context_line":"VENVDIR\u003d/opt/ironic-python-agent"},{"line_number":15,"context_line":"PIP_PACKAGES_TO_UPGRADE\u003d\"pip\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# create the virtual environment using the default python"},{"line_number":18,"context_line":"if [ $DIB_PYTHON_VERSION \u003d\u003d 3 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_4f588257","line":15,"updated":"2020-02-02 15:25:31.000000000","message":"Let us actually stop upgrading pip for Python 3. We haven\u0027t used new features for a while.","commit_id":"d29478df872c6cf107496499b601e82360b8507a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4c288eab42b2a1cce50a9fb2047c39b58ae5bcdf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $DIB_PYTHON -m venv $VENVDIR"},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"  $DIB_PYTHON -m virtualenv $VENVDIR"},{"line_number":22,"context_line":"  PIP_PACKAGES_TO_UPGRADE+\u003d\" wheel setuptools setuptools_scm\""},{"line_number":23,"context_line":"  # pip might be an older version which does not support the -c option, therefore upgrade first"},{"line_number":24,"context_line":"  $VENVDIR/bin/pip install $PIP_PACKAGES_TO_UPGRADE --upgrade"},{"line_number":25,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_7e7e4ac1","line":22,"updated":"2020-02-03 11:25:14.000000000","message":"now you don\u0027t need this variable at all","commit_id":"c20ae3197be18ba7a9fa9e1dd5c25cdaaf30922d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f23ef1a27e0d08be5398e7b6596de2a685cf237a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $DIB_PYTHON -m venv $VENVDIR"},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"  $DIB_PYTHON -m virtualenv $VENVDIR"},{"line_number":22,"context_line":"  PIP_PACKAGES_TO_UPGRADE+\u003d\" wheel setuptools setuptools_scm\""},{"line_number":23,"context_line":"  # pip might be an older version which does not support the -c option, therefore upgrade first"},{"line_number":24,"context_line":"  $VENVDIR/bin/pip install $PIP_PACKAGES_TO_UPGRADE --upgrade"},{"line_number":25,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_b954dcfe","line":22,"in_reply_to":"3fa7e38b_7e7e4ac1","updated":"2020-02-03 11:38:33.000000000","message":"I was actually looking at what\u0027s happening in the ubuntu bionic job (that uses Python 3), we might need to upgrade something there too. The pip version installed by default is very old (9.0.1), and the job is exiting with the error:\nModuleNotFoundError: No module named \u0027wheel\u0027","commit_id":"c20ae3197be18ba7a9fa9e1dd5c25cdaaf30922d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"017cdb433068bf2c2546d80aa75aae5e90064c3e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"PYTHON_SUB_VERSION\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[1])\u0027)"},{"line_number":32,"context_line":"if [ $DIB_PYTHON_VERSION \u003d\u003d 2 ] || [[ $PYTHON_SUB_VERSION \u003c 7 ]] ; then"},{"line_number":33,"context_line":"  pip_upgrade_packages"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3fa7e38b_e91ea30d","line":32,"updated":"2020-02-09 18:17:47.000000000","message":"This includes CentOS 8, let\u0027s actually check for 3.6.9 then?","commit_id":"4a0c34d30f0764f38a4772bd1df14f76a7ccf80f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cccf688db83f59afa29682bd88432adb2bf515c3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"PYTHON_SYS_MIC_VER\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[2])\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [ $DIB_PYTHON_VERSION -eq 2 ] || \\"},{"line_number":35,"context_line":"  ([ $DIB_PYTHON_VERSION -eq 3 ] \u0026\u0026 [ $PYTHON_SYS_MIN_VER -eq 6 ] \u0026\u0026 [ $PYTHON_SYS_MIC_VER -ge 9 ]) ; then"},{"line_number":36,"context_line":"    pip_upgrade_packages"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_93f9e6c7","line":35,"updated":"2020-02-17 15:30:58.000000000","message":"nit: since we invoke python anyway, I\u0027d rather do the math in Python as well\n\nmmm, wait, why -ge in the last part? I think you need -lt?","commit_id":"1a004707b0ebf4afeab28e2ee9d0feebf69a43be"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1321b0b722a532e3a85042e380a41159acf7fc5b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"PYTHON_SYS_MIC_VER\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[2])\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [ $DIB_PYTHON_VERSION -eq 2 ] || \\"},{"line_number":35,"context_line":"  ([ $DIB_PYTHON_VERSION -eq 3 ] \u0026\u0026 [ $PYTHON_SYS_MIN_VER -eq 6 ] \u0026\u0026 [ $PYTHON_SYS_MIC_VER -ge 9 ]) ; then"},{"line_number":36,"context_line":"    pip_upgrade_packages"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_96a77fbc","line":35,"in_reply_to":"3fa7e38b_10a95a25","updated":"2020-02-18 14:57:00.000000000","message":"Python version in CentOS 8 is 3.6.8, so this is not applied.\nAnyway, we can exclude pip from the upgrade process, or impose a specific version, which is not a bad idea in terms of consistency considering that we\u0027re using virtualenvs everywhere.\nIf we only upgrade pip, the jobs where python is 3.6.9 or higher will fail, that\u0027s why I\u0027m upgrading setuptools and wheels; we could also specify a version for these packages and stick with that.","commit_id":"1a004707b0ebf4afeab28e2ee9d0feebf69a43be"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c63441bad2b5ba6102e0f754d0cd8ea0ac3b1e47","unresolved":false,"context_lines":[{"line_number":32,"context_line":"PYTHON_SYS_MIC_VER\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[2])\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [ $DIB_PYTHON_VERSION -eq 2 ] || \\"},{"line_number":35,"context_line":"  ([ $DIB_PYTHON_VERSION -eq 3 ] \u0026\u0026 [ $PYTHON_SYS_MIN_VER -eq 6 ] \u0026\u0026 [ $PYTHON_SYS_MIC_VER -ge 9 ]) ; then"},{"line_number":36,"context_line":"    pip_upgrade_packages"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_70e68eb2","line":35,"in_reply_to":"3fa7e38b_6a0b01d4","updated":"2020-02-18 11:19:17.000000000","message":"Wait, this shouldn\u0027t be happening. What exactly cannot we do with new Python? What you have means that we update pip, setuptools and wheels unconditionally on CentOS 8, which is something I\u0027m trying to avoid. At the very least, we only upgrade pip right now, and it seems to work.","commit_id":"1a004707b0ebf4afeab28e2ee9d0feebf69a43be"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2418f3b6a294ed3f14f6e3a56815bf3ebfa4b02b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"PYTHON_SYS_MIC_VER\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[2])\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [ $DIB_PYTHON_VERSION -eq 2 ] || \\"},{"line_number":35,"context_line":"  ([ $DIB_PYTHON_VERSION -eq 3 ] \u0026\u0026 [ $PYTHON_SYS_MIN_VER -eq 6 ] \u0026\u0026 [ $PYTHON_SYS_MIC_VER -ge 9 ]) ; then"},{"line_number":36,"context_line":"    pip_upgrade_packages"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_10a95a25","line":35,"in_reply_to":"3fa7e38b_70e68eb2","updated":"2020-02-18 11:25:36.000000000","message":"3.6.10 on my Fedora bundles pip 19.1.1 and it seems to work. CentOS 8 has 9.0.3, which works as well. I\u0027ve pulled a bionic container, and it seems to have 9.0.1 which supports -c.","commit_id":"1a004707b0ebf4afeab28e2ee9d0feebf69a43be"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2ca49f795e1ec12623e2f6a12cce72d3cc109d64","unresolved":false,"context_lines":[{"line_number":32,"context_line":"PYTHON_SYS_MIC_VER\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[2])\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [ $DIB_PYTHON_VERSION -eq 2 ] || \\"},{"line_number":35,"context_line":"  ([ $DIB_PYTHON_VERSION -eq 3 ] \u0026\u0026 [ $PYTHON_SYS_MIN_VER -eq 6 ] \u0026\u0026 [ $PYTHON_SYS_MIC_VER -ge 9 ]) ; then"},{"line_number":36,"context_line":"    pip_upgrade_packages"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_bece2956","line":35,"in_reply_to":"3fa7e38b_93f9e6c7","updated":"2020-02-17 16:12:13.000000000","message":"+1, looks like -lt is needed?","commit_id":"1a004707b0ebf4afeab28e2ee9d0feebf69a43be"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"23439c1bb0bed7496c857e3778f17dea25661be9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"PYTHON_SYS_MIC_VER\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[2])\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [ $DIB_PYTHON_VERSION -eq 2 ] || \\"},{"line_number":35,"context_line":"  ([ $DIB_PYTHON_VERSION -eq 3 ] \u0026\u0026 [ $PYTHON_SYS_MIN_VER -eq 6 ] \u0026\u0026 [ $PYTHON_SYS_MIC_VER -ge 9 ]) ; then"},{"line_number":36,"context_line":"    pip_upgrade_packages"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_114e3990","line":35,"in_reply_to":"3fa7e38b_96a77fbc","updated":"2020-02-18 16:00:10.000000000","message":"If you need an example of what happens if we don\u0027t upgrade wheel and setuptools:\nhttps://review.opendev.org/708413","commit_id":"1a004707b0ebf4afeab28e2ee9d0feebf69a43be"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5040c9893424772b18680af721a2b3db2b0fc214","unresolved":false,"context_lines":[{"line_number":32,"context_line":"PYTHON_SYS_MIC_VER\u003d$(${VENVDIR}/bin/python -c \u0027import sys; print(sys.version_info[2])\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"if [ $DIB_PYTHON_VERSION -eq 2 ] || \\"},{"line_number":35,"context_line":"  ([ $DIB_PYTHON_VERSION -eq 3 ] \u0026\u0026 [ $PYTHON_SYS_MIN_VER -eq 6 ] \u0026\u0026 [ $PYTHON_SYS_MIC_VER -ge 9 ]) ; then"},{"line_number":36,"context_line":"    pip_upgrade_packages"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"3fa7e38b_6a0b01d4","line":35,"in_reply_to":"3fa7e38b_bece2956","updated":"2020-02-18 09:16:46.000000000","message":"yeah, this seems weird at first, but the incompatibility *starts* with 3.6.9, so -ge is actually correct\nthe reason why ubuntu is failing here is the missing python3-dev package, fixed in https://review.opendev.org/705627","commit_id":"1a004707b0ebf4afeab28e2ee9d0feebf69a43be"}]}