)]}'
{"ironic_python_agent_builder/__init__.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a0426c7acae342d8069b6afc338f57773020c4c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    parser.add_argument(\"--extra-args\","},{"line_number":57,"context_line":"                        help\u003d\"Extra arguments to pass to diskimage-builder\")"},{"line_number":58,"context_line":"    parser.add_argument(\"-p\", \"--element-path\","},{"line_number":59,"context_line":"                        help\u003d\"Path to custom DIB elements\")"},{"line_number":60,"context_line":"    # TODO(dtantsur): handle distribution \u003d\u003d tinyipa"},{"line_number":61,"context_line":"    args \u003d parser.parse_args()"},{"line_number":62,"context_line":"    if args.element_path:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_35e50aa9","line":59,"updated":"2020-03-02 13:51:46.000000000","message":"I\u0027d suggest we don\u0027t create a new argument. We cannot and probably shouldn\u0027t recreate all DIB arguments except for the most critical ones.","commit_id":"75b36a6062ac8537dcc622c0133a0f17465dbbe5"},{"author":{"_account_id":31258,"name":"Zygimantas Matonis","email":"zygimantas.matonis@cern.ch","username":"gudrutis"},"change_message_id":"bc1219f3137f6b02441e1ba8907eb840137a9184","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    parser.add_argument(\"--extra-args\","},{"line_number":57,"context_line":"                        help\u003d\"Extra arguments to pass to diskimage-builder\")"},{"line_number":58,"context_line":"    parser.add_argument(\"-p\", \"--element-path\","},{"line_number":59,"context_line":"                        help\u003d\"Path to custom DIB elements\")"},{"line_number":60,"context_line":"    # TODO(dtantsur): handle distribution \u003d\u003d tinyipa"},{"line_number":61,"context_line":"    args \u003d parser.parse_args()"},{"line_number":62,"context_line":"    if args.element_path:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_dbaba686","line":59,"in_reply_to":"1fa4df85_35e50aa9","updated":"2020-03-25 20:21:11.000000000","message":"The whole idea of this patch is to be able to pas custom DIBs that are organization specific. We used to have them on a separate git repo. Without this argument this patch is pointless.","commit_id":"75b36a6062ac8537dcc622c0133a0f17465dbbe5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a0426c7acae342d8069b6afc338f57773020c4c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    args \u003d parser.parse_args()"},{"line_number":62,"context_line":"    if args.element_path:"},{"line_number":63,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] \u003d args.element_path"},{"line_number":64,"context_line":"    if \u0027ELEMENTS_PATH\u0027 in os.environ:"},{"line_number":65,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] +\u003d \":\" + find_elements_path()"},{"line_number":66,"context_line":"    else:"},{"line_number":67,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] \u003d find_elements_path()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_55e0c696","line":64,"updated":"2020-03-02 13:51:46.000000000","message":"I\u0027d even check if it\u0027s non-empty:\n\n if os.environment.get(\u0027ELEMENTS_PATH\u0027):","commit_id":"75b36a6062ac8537dcc622c0133a0f17465dbbe5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2a0426c7acae342d8069b6afc338f57773020c4c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    if args.element_path:"},{"line_number":63,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] \u003d args.element_path"},{"line_number":64,"context_line":"    if \u0027ELEMENTS_PATH\u0027 in os.environ:"},{"line_number":65,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] +\u003d \":\" + find_elements_path()"},{"line_number":66,"context_line":"    else:"},{"line_number":67,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] \u003d find_elements_path()"},{"line_number":68,"context_line":"    if not os.environ.get(\u0027DIB_INSTALLTYPE_pip_and_virtualenv\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_f5f0d269","line":65,"updated":"2020-03-02 13:51:46.000000000","message":"A big philosophical question.. do we want it to go first or last?","commit_id":"75b36a6062ac8537dcc622c0133a0f17465dbbe5"},{"author":{"_account_id":31258,"name":"Zygimantas Matonis","email":"zygimantas.matonis@cern.ch","username":"gudrutis"},"change_message_id":"bc1219f3137f6b02441e1ba8907eb840137a9184","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    if args.element_path:"},{"line_number":63,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] \u003d args.element_path"},{"line_number":64,"context_line":"    if \u0027ELEMENTS_PATH\u0027 in os.environ:"},{"line_number":65,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] +\u003d \":\" + find_elements_path()"},{"line_number":66,"context_line":"    else:"},{"line_number":67,"context_line":"        os.environ[\u0027ELEMENTS_PATH\u0027] \u003d find_elements_path()"},{"line_number":68,"context_line":"    if not os.environ.get(\u0027DIB_INSTALLTYPE_pip_and_virtualenv\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_1bccee68","line":65,"in_reply_to":"1fa4df85_f5f0d269","updated":"2020-03-25 20:21:11.000000000","message":"If I have a custom implementation of a DIB ( say IPA recipe that points to different git repo), I would like to use it instead of the default one. So I think it should go first.","commit_id":"75b36a6062ac8537dcc622c0133a0f17465dbbe5"}]}