)]}'
{"id":"openstack%2Fironic-python-agent-builder~752728","triplet_id":"openstack%2Fironic-python-agent-builder~master~I1c0bc85aefe592a2a614f60112a8982e0f03fcf7","project":"openstack/ironic-python-agent-builder","branch":"master","topic":"jay/AdvertiseHTTPS","hashtags":[],"change_id":"I1c0bc85aefe592a2a614f60112a8982e0f03fcf7","subject":"Advertise HTTPS in IPA ramdisk without Ironic assist","status":"MERGED","created":"2020-09-18 16:38:20.000000000","updated":"2020-09-18 19:44:43.000000000","submitted":"2020-09-18 19:43:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"752728-1600458197148-57e98530","meta_rev_id":"5bd5446fb8395a179b1b329569612a05585f872c","_number":752728,"virtual_id_number":752728,"owner":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-18 19:43:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2020-09-18 18:25:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2020-09-18 16:40:20.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2020-09-18 18:25:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-18 16:40:20.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2020-09-18 18:25:18.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-09-18 19:43:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"564ca0195fe26ccee8102c8df834ec95a50e2800","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2020-09-18 16:38:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d09461a816efe5677a152c6ff5222c70130a2232","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2020-09-18 16:40:20.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks!\n\n(Still think these should be linked to the TLS story but whatever :))","accounts_in_message":[],"_revision_number":1},{"id":"b64388e47cc3787e018e61d3a30d6c678b3e71a5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 18:20:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4de2aaa9c07340d3b71be0109c29d3ea : SUCCESS in 14m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3b45fe24881649eb9ab84513ad86fba6 : SUCCESS in 2m 54s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/7ca23aa3f27e44489301e2708bfb303e : SUCCESS in 1h 19m 39s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/b3cdb4f8fb274884bf928333a479a0db : SUCCESS in 1h 22m 12s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/79a76e76e45542cda1b958da25814d11 : SUCCESS in 1h 07m 32s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/98c37d213949491bade55a363c07b349 : SUCCESS in 14m 44s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/5514bd88692b41ccb19352a76d9dc100 : SUCCESS in 10m 47s\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/6b78690e12574b558607fc374cfef2b9 : SUCCESS in 16m 35s\n- ironic-python-agent-check-image-dib-centos7-python3 https://zuul.opendev.org/t/openstack/build/f5633148cb5c490895bf81b382eebe2a : SUCCESS in 11m 13s (non-voting)\n- ironic-python-agent-check-image-dib-fedora https://zuul.opendev.org/t/openstack/build/c0186586e1d841d4afbb7ffd270ff2e2 : SUCCESS in 11m 27s (non-voting)\n- ironic-python-agent-check-image-dib-debian https://zuul.opendev.org/t/openstack/build/89707152bf9f415f869d90314e9b2a5d : SUCCESS in 12m 07s (non-voting)\n- ironic-python-agent-check-image-dib-ubuntu https://zuul.opendev.org/t/openstack/build/f26692148d0244f39d1ce0d46a5daecd : SUCCESS in 8m 56s (non-voting)\n- ipa-tempest-wholedisk-bios-ipmi-direct-dib-src https://zuul.opendev.org/t/openstack/build/e82bd3a6e7304cddbda14838703355b5 : SUCCESS in 1h 38m 26s (non-voting)\n- ipa-tempest-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/1f11ca26b8404f1197a218c2a64d4d8f : FAILURE in 1h 06m 36s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/35dcf66eeb2d4fae9a7fd48f9c0227d1 : FAILURE in 1h 06m 39s (non-voting)\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/5b818023c47c4e34ba48dc7dc82011b3 : SUCCESS in 31m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0e8a8ca6fa1e3888be1abd9d23779bd4f60ff171","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-09-18 18:25:18.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0a570d3caa30b5c54ffd089800b6ee853412199b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 18:25:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2aca2a7e4d68c5448636893e3ea67024aa175b2b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 19:43:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eb7a89d1c22441b09b876138eca62d2f : SUCCESS in 14m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f027ef3cdb8241549fe79aeefdd13cbd : SUCCESS in 2m 53s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/b28aa28d6dce492b83ac01207abdfe61 : SUCCESS in 1h 05m 32s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/c7adc1c8133947f4b91bb885e44596e0 : SUCCESS in 1h 08m 53s\n- ipa-tempest-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/f7b9b4e1957c4dba9676a7572555a44a : SUCCESS in 1h 11m 43s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/0e95838e70cd486eb40a7b31a8935b47 : SUCCESS in 17m 18s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/d7bff26cd5d84f0494bd2eb0d5ca2edf : SUCCESS in 12m 22s\n- ironic-python-agent-check-image-dib-centos7 https://zuul.opendev.org/t/openstack/build/4189a28c66bc42b99e4f6a4478574d5c : SUCCESS in 10m 50s","accounts_in_message":[],"_revision_number":1},{"id":"892e2991799e0cde7a34f9e0474fb9ca72de9105","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 19:43:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"46b6435e59436e44cbfffb06f417743f65c395af","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 19:44:43.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d52527d05c3b439fafcb4c18e193bca4 : SUCCESS in 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0cc5ba8d72c742b11b40a018d8d4d61e6ddbd7d2","revisions":{"0cc5ba8d72c742b11b40a018d8d4d61e6ddbd7d2":{"kind":"REWORK","_number":1,"created":"2020-09-18 16:38:20.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/28/752728/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent-builder","ref":"refs/changes/28/752728/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/28/752728/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/28/752728/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/28/752728/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/28/752728/1"}}},"commit":{"parents":[{"commit":"69e41ff7618ff719fc5182471a84f9fd4705e19c","subject":"Fix typo in spelling of \"finalise\", breaking build","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/69e41ff7618ff719fc5182471a84f9fd4705e19c"}]}],"author":{"name":"Jay Faulkner","email":"jay.faulkner@verizonmedia.com","date":"2020-09-18 16:36:56.000000000","tz":-420},"committer":{"name":"Jay Faulkner","email":"jay.faulkner@verizonmedia.com","date":"2020-09-18 16:36:56.000000000","tz":-420},"subject":"Advertise HTTPS in IPA ramdisk without Ironic assist","message":"Advertise HTTPS in IPA ramdisk without Ironic assist\n\nBefore this change, Ironic was required to send\n`ipa-advertise-protocol\u003dhttps` with pxe parameters to make this\ncode work.\n\nInstead, ensure we *always* advertise https, via static ramdisk\nconfiguration, when TLS is enabled.\n\nChange-Id: I1c0bc85aefe592a2a614f60112a8982e0f03fcf7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/0cc5ba8d72c742b11b40a018d8d4d61e6ddbd7d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/0cc5ba8d72c742b11b40a018d8d4d61e6ddbd7d2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
