)]}'
{"dib/keylime-agent/install.d/keylime-agent-source-install/80-keylime-agent-install":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d00edced7900685861eb1bdb943db0720b93671d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPTDIR\u003d$(dirname $0)"},{"line_number":10,"context_line":"VENVDIR\u003d/opt/ironic-python-agent"},{"line_number":11,"context_line":"KLADIR\u003d/tmp/keylime-agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# install Keylime-agent inside the virtual environment"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c05b7421_76c205d0","line":10,"updated":"2021-02-11 22:09:16.000000000","message":"Unless there\u0027s a strong technical case for it, I think it\u0027s looking for trouble to place this agent inside the same venv as IPA. If there is a specific reason, please reply here and also add it as a comment in the file.","commit_id":"d34b58c917ee531bbb6e4876915cf53249c2534a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94c1fb5983996d51120df02db53f025d61203b0c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"KLADIR\u003d/tmp/keylime-agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# install Keylime-agent inside the virtual environment"},{"line_number":14,"context_line":"$VENVDIR/bin/pip install -r $KLADIR/requirements.txt $KLADIR"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ln -s $VENVDIR/bin/keylime_agent /usr/local/bin/keylime_agent"},{"line_number":17,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f466cba_0ff274d5","line":14,"updated":"2021-01-06 16:47:53.000000000","message":"Could you please try using upper-constaints to avoid breaking IPA? See -c argument in IPA installation.","commit_id":"d34b58c917ee531bbb6e4876915cf53249c2534a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d00edced7900685861eb1bdb943db0720b93671d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"KLADIR\u003d/tmp/keylime-agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# install Keylime-agent inside the virtual environment"},{"line_number":14,"context_line":"$VENVDIR/bin/pip install -r $KLADIR/requirements.txt $KLADIR"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ln -s $VENVDIR/bin/keylime_agent /usr/local/bin/keylime_agent"},{"line_number":17,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"6fa2ac60_ffebea65","line":14,"in_reply_to":"5f466cba_0ff274d5","updated":"2021-02-11 22:09:16.000000000","message":"+1 we should do this even if you follow the advice re: using a different venv","commit_id":"d34b58c917ee531bbb6e4876915cf53249c2534a"},{"author":{"_account_id":32617,"name":"Danni Shi","email":"sdanni@redhat.com","username":"sdanni"},"change_message_id":"372aa2b8f91358111a2180099d63df018fc5f668","unresolved":false,"context_lines":[{"line_number":11,"context_line":"KLADIR\u003d/tmp/keylime-agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# install Keylime-agent inside the virtual environment"},{"line_number":14,"context_line":"$VENVDIR/bin/pip install -r $KLADIR/requirements.txt $KLADIR"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ln -s $VENVDIR/bin/keylime_agent /usr/local/bin/keylime_agent"},{"line_number":17,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c22fb6d3_f11c524f","line":14,"in_reply_to":"6fa2ac60_ffebea65","updated":"2021-02-12 15:36:24.000000000","message":"Thanks for your suggestions. I think there\u0027s no specific reason to use IPA venv. I\u0027ll propose it to dib repo.","commit_id":"d34b58c917ee531bbb6e4876915cf53249c2534a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94c1fb5983996d51120df02db53f025d61203b0c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ln -s $VENVDIR/bin/keylime_agent /usr/local/bin/keylime_agent"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":19,"context_line":"    upstart)"},{"line_number":20,"context_line":"        install -D -g root -o root -m 0755 ${SCRIPTDIR}/keylime-agent.conf /etc/init/keylime-agent.conf"},{"line_number":21,"context_line":"        ;;"},{"line_number":22,"context_line":"    systemd)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"302f6a28_f7facab8","line":19,"updated":"2021-01-06 16:47:53.000000000","message":"I wonder if we even support any upstart-based system..","commit_id":"d34b58c917ee531bbb6e4876915cf53249c2534a"}],"dib/keylime-agent/install.d/keylime-agent-source-install/keylime-agent.init":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94c1fb5983996d51120df02db53f025d61203b0c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"case \"$1\" in"},{"line_number":20,"context_line":"    start)"},{"line_number":21,"context_line":"        $SCRIPT_NAME --config-dir /etc/keylime-agent.d/"},{"line_number":22,"context_line":"        ;;"},{"line_number":23,"context_line":"    stop)"},{"line_number":24,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e0fd9b3e_2eb412ea","line":21,"updated":"2021-01-06 16:47:53.000000000","message":"Do you support --config-dir? It doesn\u0027t seem present in the systemd service.\n\nSame in the upstart unit.","commit_id":"d34b58c917ee531bbb6e4876915cf53249c2534a"}],"dib/keylime-agent/package-installs.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94c1fb5983996d51120df02db53f025d61203b0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"git:"},{"line_number":2,"context_line":"    phase: pre-install.d"},{"line_number":3,"context_line":"    uninstall: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4c6a31f3_cac57b61","line":3,"updated":"2021-01-06 16:47:53.000000000","message":"git is always installed and you should NOT uninstall it, it will break pbr. just remove this file.","commit_id":"d34b58c917ee531bbb6e4876915cf53249c2534a"}]}
