)]}'
{"dib/ironic-python-agent-ramdisk/install.d/ironic-python-agent-ramdisk-source-install/60-ironic-python-agent-ramdisk-install":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1e31c03ad0fc709d78e2eda117dbb21c0eb1d58f","unresolved":true,"context_lines":[{"line_number":51,"context_line":"# Install wheel in case it needs to build wheels. E.g. for aarch64 platform"},{"line_number":52,"context_line":"# it might need to build wheels for the install python packages, as not all"},{"line_number":53,"context_line":"# the python packages provide aarch64 platform wheels in PyPi."},{"line_number":54,"context_line":"$VENVDIR/bin/pip install wheel"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Upgrade setuptools package for openSuse"},{"line_number":57,"context_line":"if [ \"$DISTRO_NAME\" \u003d\u003d \"opensuse\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"aa2b6b8b_794585f4","line":54,"updated":"2021-04-28 10:07:07.000000000","message":"at least this should be conditional based on the arch and put inside the precedent if-then since not all installations use pip by default","commit_id":"b1d4c2002f79bef642f36cdafb588ab5dead3891"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"2ff51b5cae4bd31687638fd4e2370c7da04f1af2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Install wheel in case it needs to build wheels. E.g. for aarch64 platform"},{"line_number":52,"context_line":"# it might need to build wheels for the install python packages, as not all"},{"line_number":53,"context_line":"# the python packages provide aarch64 platform wheels in PyPi."},{"line_number":54,"context_line":"$VENVDIR/bin/pip install wheel"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Upgrade setuptools package for openSuse"},{"line_number":57,"context_line":"if [ \"$DISTRO_NAME\" \u003d\u003d \"opensuse\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4ff7241c_75f13c8f","line":54,"in_reply_to":"aa2b6b8b_794585f4","updated":"2021-04-29 03:10:19.000000000","message":"Thanks, done.","commit_id":"b1d4c2002f79bef642f36cdafb588ab5dead3891"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"26462dc54e19ec8348e4fb640bd729d2a708e16c","unresolved":true,"context_lines":[{"line_number":51,"context_line":"# For aarch64 platform, it needs to build wheels for the install python"},{"line_number":52,"context_line":"# packages, as not all the python packages provide aarch64 platform wheels"},{"line_number":53,"context_line":"# in PyPi."},{"line_number":54,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aach64) ]]; then"},{"line_number":55,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"feb046c8_fc1d93d2","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":30},"updated":"2021-04-29 09:04:53.000000000","message":"aarch64 ?","commit_id":"6c3dfbdc8e4dc75a2ee3017773bdb4e3a5bb533a"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"036317dbe171622a35902d7666d3d5571ca471a1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# For aarch64 platform, it needs to build wheels for the install python"},{"line_number":52,"context_line":"# packages, as not all the python packages provide aarch64 platform wheels"},{"line_number":53,"context_line":"# in PyPi."},{"line_number":54,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aach64) ]]; then"},{"line_number":55,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8b68b388_654ec9ae","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":30},"in_reply_to":"feb046c8_fc1d93d2","updated":"2021-04-29 09:18:13.000000000","message":"Ack","commit_id":"6c3dfbdc8e4dc75a2ee3017773bdb4e3a5bb533a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f779101f9be5cacd569fdf7c05908ed6a575b34f","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"e22eee44_af4d542f","line":61,"updated":"2021-05-06 11:47:26.000000000","message":"missing # at the beginning of the line","commit_id":"bb543aa03f5b290166efe5b8640e1d61045bc74a"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"0b9b06573e52826ace1174a3b0d6f096260f5e7b","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"2c11cb1c_651da8b8","line":61,"in_reply_to":"e22eee44_af4d542f","updated":"2021-05-07 00:55:00.000000000","message":"Very sorry, just copy patch to another machine to test and submit patch on another machine. Which make thing different in two sides.","commit_id":"bb543aa03f5b290166efe5b8640e1d61045bc74a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d2f8bc3ed31a49666d60da734680a7f331181683","unresolved":true,"context_lines":[{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"# source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"dc6394f8_ecd83d70","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":69},"updated":"2021-05-07 01:03:39.000000000","message":"This should always be true now. In other words, it is redundant to have in the script.","commit_id":"a881228f3ed776e9ad20b12d262782121e1c5102"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"038d625b3b48a4d897c083abef7d8f69b31e4173","unresolved":true,"context_lines":[{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"# source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"a53f9583_7335ada4","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":69},"in_reply_to":"4d38848a_be156a77","updated":"2021-05-07 10:41:42.000000000","message":"Yeah, but arm64 became a main cpu arch only starting from rhel8.0. And we always recommend customers not to use CentOS/rhel7 for arm64 due to many kernel and user space software issues. Even the GCC 4.8.5 of CentOS7 is too old for arm64.","commit_id":"a881228f3ed776e9ad20b12d262782121e1c5102"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"14233c454a14aabfc0e174b8f9e2a460de039574","unresolved":true,"context_lines":[{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"# source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"4d38848a_be156a77","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":69},"in_reply_to":"a3679e31_1e28cab4","updated":"2021-05-07 10:27:53.000000000","message":"Centos 7 official support for aarch64/arm64 is present since 2015 https://lists.centos.org/pipermail/centos-announce/2015-August/021275.html","commit_id":"a881228f3ed776e9ad20b12d262782121e1c5102"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2b30e1d9fb25912c5e76f3af2afa815c72fc3b91","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"# source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"68b0e927_c1a94987","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":69},"in_reply_to":"a53f9583_7335ada4","updated":"2021-05-07 14:02:15.000000000","message":"I\u0027m going to stop the discussion here, I have no intention to keep blocking this patch further.\nIt is really a technicality and I think/hope we\u0027re going to see Python 2 disappear entirely quite soon :)","commit_id":"a881228f3ed776e9ad20b12d262782121e1c5102"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"05ba7dfa19a4c23025808f31397ff170df45859a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"# source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"f4a67ee4_dde56055","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":69},"in_reply_to":"d45f1d0a_590c387a","updated":"2021-05-07 06:18:10.000000000","message":"not sure about that, we still have centos7 support that has python2 by default\nunless we agree to not support Python 2 on arm64/aarch64, which I\u0027m 100% for","commit_id":"a881228f3ed776e9ad20b12d262782121e1c5102"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"1d3267912327155f7220517bb92aaae2ca0aeda6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"# source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"d45f1d0a_590c387a","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":69},"in_reply_to":"dc6394f8_ecd83d70","updated":"2021-05-07 01:24:54.000000000","message":"agree.","commit_id":"a881228f3ed776e9ad20b12d262782121e1c5102"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"bab6861c01e6b36dc2ad4154b19b59fb856b0057","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# For aarch64 platform, it seems it always tries to build wheels first for"},{"line_number":60,"context_line":"# python packages which have no wheels in PyPi. Although it will install the"},{"line_number":61,"context_line":"# source packages successfully at last."},{"line_number":62,"context_line":"if [[ \"$ARCH\" \u003d~ (arm64|aarch64) ]] \u0026\u0026 [[ $IPA_PYTHON_VERSION \u003d\u003d 3 ]]; then"},{"line_number":63,"context_line":"    $VENVDIR/bin/pip install wheel"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"a3679e31_1e28cab4","line":62,"range":{"start_line":62,"start_character":37,"end_line":62,"end_character":69},"in_reply_to":"f4a67ee4_dde56055","updated":"2021-05-07 07:41:55.000000000","message":"I am sure that CentOS7 is too old for AArch64. CentOS7 for AArcyh64 which is something like Development Preview. To support AArch64 well people should skip CentOS7 and use CentOS8.","commit_id":"a881228f3ed776e9ad20b12d262782121e1c5102"}]}