)]}'
{"dib/ironic-ramdisk-base/cleanup.d/99-ramdisk-create":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9138c884e8a28bcfef28c9227119eec8fd9269f5","unresolved":true,"context_lines":[{"line_number":36,"context_line":"for path in $DIB_IPA_PATHS_TO_PRUNE; do"},{"line_number":37,"context_line":"    FIND_COMMAND\u003d\"$FIND_COMMAND -path $path -prune -o \""},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyc\u0027 -prune -o\""},{"line_number":40,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyo\u0027 -prune -o -print\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo $FIND_COMMAND | sudo cpio -o -H newc | ${DIB_IPA_COMPRESS_CMD} \u003e ${IMAGE_PATH}.initramfs"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d3fa2edc_364934d6","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":52},"updated":"2021-07-30 12:33:51.000000000","message":"we should probably leave a space here","commit_id":"dd034815971206f503e0795d0da5ef4db644ddb9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"02b4644a1e5a3874dfbbcf9c28e78e66a70b0eb1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"for path in $DIB_IPA_PATHS_TO_PRUNE; do"},{"line_number":37,"context_line":"    FIND_COMMAND\u003d\"$FIND_COMMAND -path $path -prune -o \""},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyc\u0027 -prune -o\""},{"line_number":40,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyo\u0027 -prune -o -print\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo $FIND_COMMAND | sudo cpio -o -H newc | ${DIB_IPA_COMPRESS_CMD} \u003e ${IMAGE_PATH}.initramfs"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a78b410f_058e9cd9","line":39,"range":{"start_line":39,"start_character":51,"end_line":39,"end_character":52},"in_reply_to":"d3fa2edc_364934d6","updated":"2021-07-30 13:48:07.000000000","message":"Done","commit_id":"dd034815971206f503e0795d0da5ef4db644ddb9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"512f8834a366c2309f87766f10cb7c4fda06c33c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    FIND_COMMAND\u003d\"$FIND_COMMAND -path $path -prune -o \""},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyc\u0027 -prune -o\""},{"line_number":40,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyo\u0027 -prune -o -print\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo $FIND_COMMAND | sudo cpio -o -H newc | ${DIB_IPA_COMPRESS_CMD} \u003e ${IMAGE_PATH}.initramfs"},{"line_number":43,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5e51570b_932a7cbc","line":40,"updated":"2021-07-30 13:43:13.000000000","message":"there are only 2 \u0027names\u0027 so maybe not worth it now but I was thinking we could also do a similar thing, add DIB_IPA_NAMES_TO_PRUNE :)","commit_id":"dd034815971206f503e0795d0da5ef4db644ddb9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"02b4644a1e5a3874dfbbcf9c28e78e66a70b0eb1","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    FIND_COMMAND\u003d\"$FIND_COMMAND -path $path -prune -o \""},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyc\u0027 -prune -o\""},{"line_number":40,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyo\u0027 -prune -o -print\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo $FIND_COMMAND | sudo cpio -o -H newc | ${DIB_IPA_COMPRESS_CMD} \u003e ${IMAGE_PATH}.initramfs"},{"line_number":43,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"99d78523_d0db53cf","line":40,"in_reply_to":"5e51570b_932a7cbc","updated":"2021-07-30 13:48:07.000000000","message":"I considered this but decided YAGNI. It can be done in the future if needed.","commit_id":"dd034815971206f503e0795d0da5ef4db644ddb9"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fce52743fe936d6bc9249aaf361b8c267b5260fa","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    FIND_COMMAND\u003d\"$FIND_COMMAND -path $path -prune -o \""},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyc\u0027 -prune -o \""},{"line_number":40,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyo\u0027 -prune -o -print \""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo $FIND_COMMAND | sudo cpio -o -H newc | ${DIB_IPA_COMPRESS_CMD} \u003e ${IMAGE_PATH}.initramfs"},{"line_number":43,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7c209997_3a21950d","line":40,"range":{"start_line":40,"start_character":58,"end_line":40,"end_character":59},"updated":"2021-07-30 13:49:02.000000000","message":"nit: blank space not needed here","commit_id":"68989576e3663cdc5a7182eea14d2ed6206d61e0"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1ed8225ab26b92de75a2e243705d7385308c4f98","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    FIND_COMMAND\u003d\"$FIND_COMMAND -path $path -prune -o \""},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyc\u0027 -prune -o \""},{"line_number":40,"context_line":"FIND_COMMAND\u003d\"$FIND_COMMAND -name \u0027*.pyo\u0027 -prune -o -print \""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"sudo $FIND_COMMAND | sudo cpio -o -H newc | ${DIB_IPA_COMPRESS_CMD} \u003e ${IMAGE_PATH}.initramfs"},{"line_number":43,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"37364c60_47e5f3c2","line":40,"range":{"start_line":40,"start_character":58,"end_line":40,"end_character":59},"in_reply_to":"7c209997_3a21950d","updated":"2021-07-30 14:17:27.000000000","message":"This was actually intentional -- in cases like this, I prefer adding the space anywhere it /could ever be needed in the future/. Don\u0027t want anyone debugging something due to a missing space, especially when adding it now causes no harm for a bash script :).","commit_id":"68989576e3663cdc5a7182eea14d2ed6206d61e0"}]}