)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55e537ef7150c6643d65d0579de313470f98428d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove centos7 jobs, python2 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change does the following:"},{"line_number":10,"context_line":"- Removes the centos7 jobs, they used python2 even though python2 was"},{"line_number":11,"context_line":"  dropped from IPA in 2019."},{"line_number":12,"context_line":"  (see Ifd0e0b99bb82a7d7e82d6c14309468196f5734fc)"},{"line_number":13,"context_line":"- Allow 60-ironic-python-agent-ramdisk-install to assume python3 and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"349a20f0_5f486218","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":45},"updated":"2022-01-20 10:52:08.000000000","message":"This is not true for the centos7-python3 job, please don\u0027t remove it. CentOS 7 still exists, its support is important because 8 removed some drivers people use in real life.","commit_id":"94e5d657221fc9714b2c971978579505fde626a4"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"5b145ff1eb19abb322e86cffcb85587e0723ee5e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove centos7 jobs, python2 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change does the following:"},{"line_number":10,"context_line":"- Removes the centos7 jobs, they used python2 even though python2 was"},{"line_number":11,"context_line":"  dropped from IPA in 2019."},{"line_number":12,"context_line":"  (see Ifd0e0b99bb82a7d7e82d6c14309468196f5734fc)"},{"line_number":13,"context_line":"- Allow 60-ironic-python-agent-ramdisk-install to assume python3 and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"be4f5a02_95f9aa42","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":45},"in_reply_to":"349a20f0_5f486218","updated":"2022-01-20 19:24:00.000000000","message":"It may be the intent of centos7-python3 to use python3, but it\u0027s config is identical to the centos7 job, and the log shows that it is actually using python2.\n\nIf it is not going to be deleted it will need to be fixed to use python3. Maybe the changes here to 60-ironic-python-agent-ramdisk-install is the start of that, but I assume there will need to be more","commit_id":"94e5d657221fc9714b2c971978579505fde626a4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"caf19ea189d24f797d99cf3704f88b57328e80a7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove centos7 jobs, python2 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change does the following:"},{"line_number":10,"context_line":"- Removes the centos7 jobs, they used python2 even though python2 was"},{"line_number":11,"context_line":"  dropped from IPA in 2019."},{"line_number":12,"context_line":"  (see Ifd0e0b99bb82a7d7e82d6c14309468196f5734fc)"},{"line_number":13,"context_line":"- Allow 60-ironic-python-agent-ramdisk-install to assume python3 and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"567566de_d6b30511","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":45},"in_reply_to":"be4f5a02_95f9aa42","updated":"2022-01-21 10:24:31.000000000","message":"This cannot be true: this job would never pass on python 2. This is the commit that introduced it https://opendev.org/openstack/ironic-python-agent-builder/commit/a28b8fa5bc49bf8452c5e8f8fdf39f5f09e46ff2 and it does account for python 3.","commit_id":"94e5d657221fc9714b2c971978579505fde626a4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3d7d9ca148a5d5131ca4fca4b90cfa1f312683bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1206d4a4_94796e21","updated":"2022-01-19 21:55:35.000000000","message":"I will likely not follow up on this review; but I\u0027m putting a -1 for visibility. Please merge it over my objections without re-review if the concerns are invalid.\n\nThis is an API-breaking change. pip-and-virtualenv expose environment variables that can -- and are -- used by deployers to set custom pip configurations. That concern isn\u0027t a reason to not do this -- but it is a reason to make sure it\u0027s loudly evangelized before pushing the change.\n\nAdditionally, the dib-python module itself says it is deprecated: https://docs.openstack.org/diskimage-builder/latest/elements/dib-python/README.html and we should use /usr/bin/python3 directly. If we\u0027re going to break deployers; lets do it exactly once. I also suggest talking to Ironic deployers and seeing how difficult it\u0027d be to replicate the functionality provided by pip-and-virtualenv environment variables.","commit_id":"0862c9891661c8914e8bc8438943a9f6a9acf213"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"06b9b346f8a7addbd0cf528ce04200a68277fafa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"093150bc_45e435ea","updated":"2022-01-19 21:01:46.000000000","message":"This will likely need some followup to keep centos7-python2 working","commit_id":"0862c9891661c8914e8bc8438943a9f6a9acf213"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"862e4da5be0018d5b5e9901c93b9603cff88e542","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5429027c_448ab782","updated":"2022-01-19 23:07:38.000000000","message":"We use this at Yahoo. This might be another con for us trying to use master branch. Sigh. Please leave it, or propose a replacement and give me time (MOAR TIME) to do the replacement. Otherwise, this will break us. Unless I pin to an older version. Sigh. Not sure this means a -1 since it is my opinion, but whatever 😂","commit_id":"30e310fe0e4cbacf248533ce8853f0249fd475d2"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6b42f2e5de2aa971a6c5238155f4499e7ae72f22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"62f0ec16_0bd99a24","in_reply_to":"5429027c_448ab782","updated":"2022-01-20 00:33:31.000000000","message":"Without knowing what your builds do, I would expect the only changes you need to do is:\n- just use python3, no need to use $DIB_PYTHON\n- replace any uses of \"virtualenv\" with \"python3 -m venv\"\n\nThats it. Or you could add the pip-and-virtualenv element to your own element dependencies, but its only going to get more bitrotten at this point so YMMV","commit_id":"30e310fe0e4cbacf248533ce8853f0249fd475d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e36cc838a38167a6aa8ba6cf32d6bf7befe0f84a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bdd9801b_92967d96","updated":"2022-01-24 21:17:11.000000000","message":"I think a strong case can be made to backport this, given py2 support was quite dead and the images, which stopped getting published AFAIK were also non-functional in advance of that. ","commit_id":"66206d0b27982a6632dfa38a41129a6d1de9321b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8b0d9f6585de09753a5492a46c5fb507f164dd01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd78a1ee_09edcfc1","updated":"2022-01-21 10:27:34.000000000","message":"We should probably drop suse support.","commit_id":"66206d0b27982a6632dfa38a41129a6d1de9321b"}]}