)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0384d653fde4ebcce8e19f37b4d73f5fdb8da205","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1dcdeb4e_63fff4be","updated":"2022-02-15 18:55:03.000000000","message":"Adding two interested parties to the reviews.","commit_id":"e827e10f0854f9e0af3a4a44e790af25f8bba198"},{"author":{"_account_id":8161,"name":"Lon Hohberger","email":"lhh@redhat.com","username":"lon"},"change_message_id":"e1d4f965dd65ce761d71a64b053f58bef6fa35fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"75a08b6c_57db7fd6","updated":"2022-02-16 17:57:12.000000000","message":"Looks good to me!","commit_id":"94171f104c441f8aea4f8cfadddbb6f0964b09a4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"066d058a6d90c00b6d38f8b871995144fd5d045e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5d6b79e_a5bd9a7a","updated":"2022-02-17 18:51:06.000000000","message":"recheck","commit_id":"94171f104c441f8aea4f8cfadddbb6f0964b09a4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3daa995c97322221747af40ac0a3a48e282e9d3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac0c35d_f4d9e08d","updated":"2022-02-17 08:57:33.000000000","message":"recheck\ncs9 jobs are failing for conflicting dependencies","commit_id":"94171f104c441f8aea4f8cfadddbb6f0964b09a4"}],"dib/ironic-ramdisk-base/cleanup.d/99-ramdisk-create":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"827ba95e6373e363a00019d51299d416e7d71496","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# long standing systemd bug cases where it may, depending on"},{"line_number":29,"context_line":"# underlying OS config/version, try to open the random number"},{"line_number":30,"context_line":"# generator before initializing."},{"line_number":31,"context_line":"# https://github.com/systemd/systemd/issues/4167"},{"line_number":32,"context_line":"mknod ./dev/random c 1 8"},{"line_number":33,"context_line":"mknod ./dev/urandom c 1 9"},{"line_number":34,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"6b34d24b_6a6b052b","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":48},"updated":"2022-02-15 19:07:15.000000000","message":"Doesn\u0027t seem related, it\u0027s about a warning, not a crash.","commit_id":"e827e10f0854f9e0af3a4a44e790af25f8bba198"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"889cdbd8fb5362c11594727b69b2f12b0c9fb1d3","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# long standing systemd bug cases where it may, depending on"},{"line_number":29,"context_line":"# underlying OS config/version, try to open the random number"},{"line_number":30,"context_line":"# generator before initializing."},{"line_number":31,"context_line":"# https://github.com/systemd/systemd/issues/4167"},{"line_number":32,"context_line":"mknod ./dev/random c 1 8"},{"line_number":33,"context_line":"mknod ./dev/urandom c 1 9"},{"line_number":34,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"815651e9_63fcf13d","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":48},"in_reply_to":"6b34d24b_6a6b052b","updated":"2022-02-15 22:08:27.000000000","message":"Crash seems to be limited to rhel in fips mode, but I\u0027ve got someone who has (or will) open that bug specifically. Truthfully, we don\u0027t understand why, we just see the impact and see we\u0027re not the only ones to have encountered systemd doing this. :(","commit_id":"e827e10f0854f9e0af3a4a44e790af25f8bba198"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"47f187e7a1071f3c289480d127e056d9b01908b4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# long standing systemd bug cases where it may, depending on"},{"line_number":29,"context_line":"# underlying OS config/version, try to open the random number"},{"line_number":30,"context_line":"# generator before initializing."},{"line_number":31,"context_line":"# https://github.com/systemd/systemd/issues/4167"},{"line_number":32,"context_line":"mknod ./dev/random c 1 8"},{"line_number":33,"context_line":"mknod ./dev/urandom c 1 9"},{"line_number":34,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f2a9a98e_31784ef5","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":48},"in_reply_to":"815651e9_63fcf13d","updated":"2022-02-16 14:30:19.000000000","message":"revised statement to list it as an example of the overall behavior.","commit_id":"e827e10f0854f9e0af3a4a44e790af25f8bba198"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"63d5d1d6c0440370aa15fc33e76a5db045548f65","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# underlying OS config/version, try to open the random number"},{"line_number":30,"context_line":"# generator before initializing."},{"line_number":31,"context_line":"# https://github.com/systemd/systemd/issues/4167"},{"line_number":32,"context_line":"mknod ./dev/random c 1 8"},{"line_number":33,"context_line":"mknod ./dev/urandom c 1 9"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Note(JayF): to anyone trying to make this more configurable in the future,"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3d03fcda_1be76333","line":32,"updated":"2022-02-16 08:27:00.000000000","message":"you should probably do this only if /dev/random and /dev/urandom do not exist or the image build will fail, as it\u0027s happening in the failed jobs","commit_id":"e827e10f0854f9e0af3a4a44e790af25f8bba198"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"47f187e7a1071f3c289480d127e056d9b01908b4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# underlying OS config/version, try to open the random number"},{"line_number":30,"context_line":"# generator before initializing."},{"line_number":31,"context_line":"# https://github.com/systemd/systemd/issues/4167"},{"line_number":32,"context_line":"mknod ./dev/random c 1 8"},{"line_number":33,"context_line":"mknod ./dev/urandom c 1 9"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Note(JayF): to anyone trying to make this more configurable in the future,"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f2ab9e81_9a208b0d","line":32,"in_reply_to":"3d03fcda_1be76333","updated":"2022-02-16 14:30:19.000000000","message":"Done","commit_id":"e827e10f0854f9e0af3a4a44e790af25f8bba198"},{"author":{"_account_id":8161,"name":"Lon Hohberger","email":"lhh@redhat.com","username":"lon"},"change_message_id":"4961230a57275e0c6353b9293f01aaa05edeb5ae","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# This class of issue has appeared frquently with systemd,"},{"line_number":32,"context_line":"# https://github.com/systemd/systemd/issues/4167 is a commonly"},{"line_number":33,"context_line":"# referenced example of this behavior."},{"line_number":34,"context_line":"if [ ! -a ./dev/random ]; then"},{"line_number":35,"context_line":"    mknod ./dev/random c 1 8"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":"if [ ! -a ./dev/urandom ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"6a7d29f9_39b64590","line":34,"updated":"2022-02-16 16:28:51.000000000","message":"Should be \"if ! [ -a ... ]\"? I think putting it inside the brackets causes the check to always pass, which I think doesn\u0027t address the prior comments.\n\nex:\n    [ -a /tmp ]; echo $?     # 0\n    [ ! -a /tmp ]; echo $?   # 0\n    ! [ -a /tmp ]; echo $?   # 1","commit_id":"bb640ec77b47a4c11f8a8723bef6f8090882d621"},{"author":{"_account_id":8161,"name":"Lon Hohberger","email":"lhh@redhat.com","username":"lon"},"change_message_id":"04e112ee6ac1ef8a3762187cfddfb27180817faf","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# This class of issue has appeared frquently with systemd,"},{"line_number":32,"context_line":"# https://github.com/systemd/systemd/issues/4167 is a commonly"},{"line_number":33,"context_line":"# referenced example of this behavior."},{"line_number":34,"context_line":"if [ ! -a ./dev/random ]; then"},{"line_number":35,"context_line":"    mknod ./dev/random c 1 8"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":"if [ ! -a ./dev/urandom ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"2f3f8029_26758eb5","line":34,"in_reply_to":"68b6a730_5ead3d3b","updated":"2022-02-16 17:56:15.000000000","message":"-c or -a; -f is regular file, which will always fail on a character device inode","commit_id":"bb640ec77b47a4c11f8a8723bef6f8090882d621"},{"author":{"_account_id":8161,"name":"Lon Hohberger","email":"lhh@redhat.com","username":"lon"},"change_message_id":"302c231f4a9970822c46652e7a228af83b5fc8c6","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# This class of issue has appeared frquently with systemd,"},{"line_number":32,"context_line":"# https://github.com/systemd/systemd/issues/4167 is a commonly"},{"line_number":33,"context_line":"# referenced example of this behavior."},{"line_number":34,"context_line":"if [ ! -a ./dev/random ]; then"},{"line_number":35,"context_line":"    mknod ./dev/random c 1 8"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":"if [ ! -a ./dev/urandom ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"acf2a847_96897166","line":34,"in_reply_to":"6a7d29f9_39b64590","updated":"2022-02-16 16:29:20.000000000","message":"(same for both checks)","commit_id":"bb640ec77b47a4c11f8a8723bef6f8090882d621"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"392d775e59f9a45b0ce3330eb64772ceccb990c3","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# This class of issue has appeared frquently with systemd,"},{"line_number":32,"context_line":"# https://github.com/systemd/systemd/issues/4167 is a commonly"},{"line_number":33,"context_line":"# referenced example of this behavior."},{"line_number":34,"context_line":"if [ ! -a ./dev/random ]; then"},{"line_number":35,"context_line":"    mknod ./dev/random c 1 8"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":"if [ ! -a ./dev/urandom ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"68b6a730_5ead3d3b","line":34,"in_reply_to":"7bfecabc_2843716d","updated":"2022-02-16 17:18:36.000000000","message":"jkreger@icarus:~/ironic$ test -f /dev/urandom\njkreger@icarus:~/ironic$ echo $?\n1\njkreger@icarus:~/ironic$ test -c /dev/urandom\njkreger@icarus:~/ironic$ echo $?\n0\njkreger@icarus:~/ironic$\n\n-a is a \"any sort of file, which you can\u0027t test against a directory.\"\n\nSo interestingly enough, it is documented out there both ways, but if lon\u0027s testing doesn\u0027t work, then obviously we need to change it.","commit_id":"bb640ec77b47a4c11f8a8723bef6f8090882d621"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8eb41f6d0858529bab3e932fa61593a11db529b1","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# This class of issue has appeared frquently with systemd,"},{"line_number":32,"context_line":"# https://github.com/systemd/systemd/issues/4167 is a commonly"},{"line_number":33,"context_line":"# referenced example of this behavior."},{"line_number":34,"context_line":"if [ ! -a ./dev/random ]; then"},{"line_number":35,"context_line":"    mknod ./dev/random c 1 8"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":"if [ ! -a ./dev/urandom ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7bfecabc_2843716d","line":34,"in_reply_to":"acf2a847_96897166","updated":"2022-02-16 17:01:27.000000000","message":"should be -f, then eventually -a, although we should test them separately as we may want to add one or the other or both or neither","commit_id":"bb640ec77b47a4c11f8a8723bef6f8090882d621"}]}