)]}'
{"id":"openstack%2Fironic-python-agent-builder~848608","triplet_id":"openstack%2Fironic-python-agent-builder~stable%2Fxena~I6952b833e0be4a47e45e9c4d4459956093628b6a","project":"openstack/ironic-python-agent-builder","branch":"stable/xena","attention_set":{},"removed_from_attention_set":{"14826":{"account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"last_update":"2022-07-07 09:48:35.000000000","reason":"\u003cGERRIT_ACCOUNT_14826\u003e replied on the change","reason_account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}}},"hashtags":[],"change_id":"I6952b833e0be4a47e45e9c4d4459956093628b6a","subject":"Add smartmontools package to DIB image","status":"MERGED","created":"2022-07-05 08:06:37.000000000","updated":"2022-07-07 11:10:09.000000000","submitted":"2022-07-07 11:09:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"848608","cherry_pick_of_change":847754,"cherry_pick_of_patch_set":1,"meta_rev_id":"fcfae61d4baca3fe51fb4b0a755d07bcd268298e","_number":848608,"virtual_id_number":848608,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-07 11:09:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":2,"date":"2022-07-07 09:48:35.000000000","_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-07-05 10:54:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":1,"date":"2022-07-07 09:48:35.000000000","_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-05 10:19:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-05 10:54:03.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"1ecf48bedfe6b50f061a229d67501fea3d44ba0f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-07-05 08:06:37.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"73c606a65f43b16901a2cac05f9f8e96725537d2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-05 10:19:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/72408df637644bee9f4937134eb761ca\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f70db7ea3ade423894daa835446cbc47 : SUCCESS in 4m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef373fb280734ebab22fb80507c2ebdb : SUCCESS in 2m 38s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/d4deee9685454d23913723e07c440c48 : SUCCESS in 1h 22m 09s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/2203116eb4b847ebb038034d7060ffb8 : SUCCESS in 1h 27m 39s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/dc69a695861d45c4b1fa3a51cf96c6bf : SUCCESS in 16m 32s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/079d086ab8ea42fe9e87c2e97df221ff : SUCCESS in 12m 25s\n- ironic-python-agent-check-image-dib-centos8-extra https://zuul.opendev.org/t/openstack/build/d88249f554cb4c65aa6db4edf6b1f263 : SUCCESS in 13m 04s\n- ironic-python-agent-check-image-dib-centos7-python3 https://zuul.opendev.org/t/openstack/build/32a24f1d8d9a4080897aec5602787672 : SUCCESS in 17m 52s\n- ironic-python-agent-check-image-dib-debian https://zuul.opendev.org/t/openstack/build/21204e1ff3a34911864404764412547e : SUCCESS in 6m 36s\n- ironic-python-agent-check-image-dib-debian-extra https://zuul.opendev.org/t/openstack/build/5d1d56272e474fddadc5f5fbfdbfd0c2 : SUCCESS in 7m 00s\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/851cb05cbb744478bb2df8822c7c4e89 : SUCCESS in 8m 04s (non-voting)\n- ironic-python-agent-check-image-dib-centos9-extra https://zuul.opendev.org/t/openstack/build/1d025954b5d44310ab125f0626a39411 : FAILURE in 4m 33s (non-voting)\n- ironic-python-agent-check-image-dib-ubuntu https://zuul.opendev.org/t/openstack/build/9efd6c37af96498fb3f8d041b20a93f5 : SUCCESS in 8m 28s (non-voting)\n- ironic-python-agent-check-image-dib-opensuse https://zuul.opendev.org/t/openstack/build/5b1fed0814804a419a14ea220f98851a : SUCCESS in 11m 15s (non-voting)\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/56f6389e7f064f72834812aa78723ea6 : SUCCESS in 1h 22m 06s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/6acb238f7cef48e188779cb827488430 : SUCCESS in 2h 06m 09s (non-voting)\n- ironic-python-agent-test-image-tinyipa-ussuri https://zuul.opendev.org/t/openstack/build/c606f8acffef48b39c06afe5c6360779 : FAILURE in 7m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3487772786ea062e8031e36cbc78261ded99a8c5","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-07-05 10:54:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f047ea86ffbaf24517e047bd3d0358dd1fed7368","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-07-07 09:48:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f306233db8b01c0c5ad60b19c5ebae7f84c6d1fc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-07 09:49:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9b3b2f23f01f8979d476a1f1bab1bc463c06091e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-07 11:09:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0205ca987a0740709783595716206ab2\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/faa04e8c9bed406cbd25efdb14b37f1b : SUCCESS in 5m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d2eab5705e284c26a5681e73cf46fce3 : SUCCESS in 3m 15s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/02fd6d71abab4be4a7a3e2ccca0b8e7c : SUCCESS in 56m 00s\n- ipa-tempest-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/2072dd9cf34849afa8ae6c9e9c5938b6 : SUCCESS in 1h 10m 46s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/c399997dad7749ebb8107078c52c4260 : SUCCESS in 13m 52s\n- ironic-python-agent-check-image-dib-centos8 https://zuul.opendev.org/t/openstack/build/e15100003da945608addf0c71ffb5b8d : SUCCESS in 12m 51s\n- ironic-python-agent-check-image-dib-centos8-extra https://zuul.opendev.org/t/openstack/build/03867209f2c14f43a4fccb87b6677501 : SUCCESS in 13m 47s\n- ironic-python-agent-check-image-dib-centos7-python3 https://zuul.opendev.org/t/openstack/build/28fb46ce38ed4881a50f0769b1c7fd09 : SUCCESS in 9m 08s\n- ironic-python-agent-check-image-dib-debian https://zuul.opendev.org/t/openstack/build/8065914cef6c425d88f89bb79ae5c20a : SUCCESS in 6m 44s\n- ironic-python-agent-check-image-dib-debian-extra https://zuul.opendev.org/t/openstack/build/a6b6c7f4992c4af8852c6b2706ada272 : SUCCESS in 6m 59s","accounts_in_message":[],"_revision_number":1},{"id":"7f42f999ad0ecc031167e2306d41279654043eac","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-07 11:09:03.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"fcfae61d4baca3fe51fb4b0a755d07bcd268298e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-07 11:10:09.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4d5682d20e20475e9bd1fe2bd60b3f6e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0cba4d40322645f0a9cc046ce077426c : SUCCESS in 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bca26200102cb1da12e66b01904cc5e2c082df82","revisions":{"bca26200102cb1da12e66b01904cc5e2c082df82":{"kind":"REWORK","_number":1,"created":"2022-07-05 08:06:37.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/08/848608/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent-builder","ref":"refs/changes/08/848608/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/08/848608/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/08/848608/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/08/848608/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/08/848608/1"}}},"commit":{"parents":[{"commit":"7bf70725a6376f0967ca93dba3c6cdab479c59b6","subject":"Create random character devices so systemd does not crash","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/7bf70725a6376f0967ca93dba3c6cdab479c59b6"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-06-27 09:25:15.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2022-07-05 08:06:37.000000000","tz":0},"subject":"Add smartmontools package to DIB image","message":"Add smartmontools package to DIB image\n\nThis package includes smartctl, which is necessary for ATA secure erase\ndisk cleaning.\n\nWithout this package, IPA will fall back to shredding ATA devices, and\nyou will lose hours of your life. Worse, until\nhttps://review.opendev.org/c/openstack/ironic-python-agent/+/847591, the\nlack of smartctl was silently ignored.\n\nChange-Id: I6952b833e0be4a47e45e9c4d4459956093628b6a\n(cherry picked from commit 57f50f7e10e0043d7aa1e860b72f98211eef4567)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/bca26200102cb1da12e66b01904cc5e2c082df82"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/bca26200102cb1da12e66b01904cc5e2c082df82"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[]}
