)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ea949c2725bf41cbaa8879818c8b50d40164fd8f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exclude .pyc encoding files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resolves: rhbz#2234514"},{"line_number":10,"context_line":"Change-Id: Ic6fbc5f48ddd385a9bbbbabebe0a2c5980142c6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"345b1353_e69e665f","line":9,"updated":"2023-08-24 18:35:07.000000000","message":"Please reference downstream Ironic bugs from bugs.launchpad.net in commits; these identifiers are downstream-specific.\n\nWe do not generally require a bug marker, but it\u0027s not ideal to have one for RH but not one upstream.","commit_id":"70f2e1367d7e9c107b8c384e6b87b7fd591e37bf"},{"author":{"_account_id":17960,"name":"Illia Polliul","email":"ipolliul@juniper.net","username":"ipolliul"},"change_message_id":"1aaeaba2c1bcbb72a3440804859fe0552ec39ef9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exclude .pyc encoding files"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resolves: rhbz#2234514"},{"line_number":10,"context_line":"Change-Id: Ic6fbc5f48ddd385a9bbbbabebe0a2c5980142c6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1d50d579_01e51e41","line":9,"in_reply_to":"345b1353_e69e665f","updated":"2023-08-24 22:15:02.000000000","message":"Ack","commit_id":"70f2e1367d7e9c107b8c384e6b87b7fd591e37bf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ea949c2725bf41cbaa8879818c8b50d40164fd8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7b9ea37c_6047ea7a","updated":"2023-08-24 18:35:07.000000000","message":"Is that package-installs.yaml change unrelated? I can\u0027t tell how it\u0027s related to the change.","commit_id":"70f2e1367d7e9c107b8c384e6b87b7fd591e37bf"},{"author":{"_account_id":17960,"name":"Illia Polliul","email":"ipolliul@juniper.net","username":"ipolliul"},"change_message_id":"1aaeaba2c1bcbb72a3440804859fe0552ec39ef9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a9268695_78008644","in_reply_to":"7b9ea37c_6047ea7a","updated":"2023-08-24 22:15:02.000000000","message":"It is related in a full use-case view. Unzip binary is required to execute firmware updates from ramdisk. Would you prefer a separate bug or just a better description in the commit message would work?","commit_id":"70f2e1367d7e9c107b8c384e6b87b7fd591e37bf"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9a8295afcb56af93ef4d5c39a08a2436f072eff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee612d00_6b1624f2","in_reply_to":"a9268695_78008644","updated":"2023-08-24 22:17:44.000000000","message":"I looked, unzip is only about 1/4 a megabyte so it probably doesn\u0027t matter that much, but realistically the \"fix\" for this would be using https://docs.openstack.org/diskimage-builder/latest/elements/package-installs/README.html when calling IPA-builder to add your own needed packages.","commit_id":"70f2e1367d7e9c107b8c384e6b87b7fd591e37bf"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"768a65e2fb10388d730a70ff36e100fddb7ad757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"917c9f6d_97c87060","updated":"2023-08-24 19:15:05.000000000","message":"I read the bug more closely; it\u0027s not explicitly said but implied in the traceback that unzip is needed to access these encoding files.","commit_id":"18e550a525de3fc682e9ecbc6589382726715d49"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"91c49ff02ba87faeb411481f7437d4dae8b07692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"79c6e424_7cd02e6a","updated":"2023-08-25 06:14:04.000000000","message":"I can see the need to leave the encodings dir untouched, but adding unzip by default to all the ironic python agent images is not really a good solution, since we install only the really necessary packages for ipa to work by default.\nAs said by Jay, you should use the package-installs element to add that package to your build.","commit_id":"2e9bcca7972a7f6bcd121da6fa3a92427e8ffe45"},{"author":{"_account_id":17960,"name":"Illia Polliul","email":"ipolliul@juniper.net","username":"ipolliul"},"change_message_id":"1aaeaba2c1bcbb72a3440804859fe0552ec39ef9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8bcde14f_385ee7f9","updated":"2023-08-24 22:15:02.000000000","message":"Thank you for prompt review!","commit_id":"2e9bcca7972a7f6bcd121da6fa3a92427e8ffe45"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9a8295afcb56af93ef4d5c39a08a2436f072eff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66f7271b_4f701148","updated":"2023-08-24 22:17:44.000000000","message":"There are worse things than providing unzip by default 😊","commit_id":"2e9bcca7972a7f6bcd121da6fa3a92427e8ffe45"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ec06b3a4d62b053014582ce721004b9f82674b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"35dff86e_ac368f70","updated":"2023-08-25 09:59:21.000000000","message":"please fix the commit message","commit_id":"e2a51ffeba158bcaa8d8ebef279a5d5706fa4883"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"facbfb133e4396ecead0907a1502176d5c03e51e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3d8d74cd_660b496f","updated":"2023-08-25 13:58:58.000000000","message":"I tested it manually ashttps://www.python.org/ftp/python/3.9.18/Python-3.9.18.tgz,","commit_id":"ab1992b528d65f30eb1bb300a729ea4b7c5484fc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1d60e034ebe11665276a2f139c063bb90e180e47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4f2b8d64_42709f8a","updated":"2023-08-25 14:43:37.000000000","message":"Thanks for the bugfix!","commit_id":"ab1992b528d65f30eb1bb300a729ea4b7c5484fc"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"1e99ffa91167b01c485a70839310240db4fc7caf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a5a007e5_b655755f","updated":"2023-08-25 14:22:05.000000000","message":"The python package spec intentionally doesn\u0027t add .py files for encodings as stated at https://src.fedoraproject.org/rpms/python3.9/blob/rawhide/f/python3.9.spec#_1187","commit_id":"ab1992b528d65f30eb1bb300a729ea4b7c5484fc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"41e00ab5f13953e64f246f7577ae2b35331e6bd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3a4d6f93_8b87fb93","updated":"2023-08-28 10:03:02.000000000","message":"recheck odd error in tinyipa","commit_id":"ab1992b528d65f30eb1bb300a729ea4b7c5484fc"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"10474bc2120567ee856589f0aafe84a4b2a1ab33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ce1d5d8b_2c1f62f3","in_reply_to":"3d8d74cd_660b496f","updated":"2023-08-25 14:17:20.000000000","message":"curl -sSL -O https://www.python.org/ftp/python/3.9.18/Python-3.9.18.tgz\ntar xvf Python-3.9.18.tgz\ncd Python-3.9.18\npython3 -m compileall .\nfind . -name \u0027*.pyc\u0027 ! -path \u0027*encodings/*\u0027 -prune -o -print | grep \"\\.pyc\"","commit_id":"ab1992b528d65f30eb1bb300a729ea4b7c5484fc"}],"dib/ironic-python-agent-ramdisk/package-installs.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d5a9b4fe7a2dc3d348e44f25f997e6bd77070a47","unresolved":true,"context_lines":[{"line_number":10,"context_line":"gcc:"},{"line_number":11,"context_line":"python:"},{"line_number":12,"context_line":"parted:"},{"line_number":13,"context_line":"unzip:"},{"line_number":14,"context_line":"hdparm:"},{"line_number":15,"context_line":"util-linux:"},{"line_number":16,"context_line":"genisoimage:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0347929b_445a8925","line":13,"updated":"2023-08-24 19:10:38.000000000","message":"Is this needed for the other change / what\u0027s in the commit message+bug?","commit_id":"18e550a525de3fc682e9ecbc6589382726715d49"},{"author":{"_account_id":17960,"name":"Illia Polliul","email":"ipolliul@juniper.net","username":"ipolliul"},"change_message_id":"1aaeaba2c1bcbb72a3440804859fe0552ec39ef9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"gcc:"},{"line_number":11,"context_line":"python:"},{"line_number":12,"context_line":"parted:"},{"line_number":13,"context_line":"unzip:"},{"line_number":14,"context_line":"hdparm:"},{"line_number":15,"context_line":"util-linux:"},{"line_number":16,"context_line":"genisoimage:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6c78ecfc_22daad45","line":13,"in_reply_to":"0347929b_445a8925","updated":"2023-08-24 22:15:02.000000000","message":"I\u0027ve updated commit message for more details. Sorry for confusion","commit_id":"18e550a525de3fc682e9ecbc6589382726715d49"}]}