)]}'
{"id":"openstack%2Fironic-python-agent-builder~954524","triplet_id":"openstack%2Fironic-python-agent-builder~master~Iab766228cac801d29457e8bee5a05834f1a0f04a","project":"openstack/ironic-python-agent-builder","branch":"master","attention_set":{},"removed_from_attention_set":{"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2025-07-10 14:02:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iab766228cac801d29457e8bee5a05834f1a0f04a","subject":"Allow dib build to remove firmware in a structure.","status":"MERGED","created":"2025-07-09 15:58:09.000000000","updated":"2025-07-10 14:03:27.000000000","submitted":"2025-07-10 14:02:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"954524","meta_rev_id":"d86303fe89a5b868e5f86105ce1aad96f48af8c8","_number":954524,"virtual_id_number":954524,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-07-10 14:02:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2025-07-10 07:53:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-07-10 12:02:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-07-10 12:02:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-09 17:39:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-07-10 07:53:08.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2025-07-10 12:02:19.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"9a208b2ef87e7443a8d3be4fc7a43c7927434067","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2025-07-09 15:58:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"68d7684466e2c71ab338402ce467864d0ee567ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2025-07-09 16:08:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"067a1388bb06ffc54ca545bb02f08e810faae72f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-09 17:39:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d16cfdf1e4f547ab8d9b02857137eddf\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ff49139e1a8f4a28892a2580ec413b76 : SUCCESS in 8m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4678b7e7162245a6ae5477d1cec744b5 : SUCCESS in 2m 58s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/c016617335a24eca985c0ad162a11824 : SUCCESS in 54m 30s\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/1d6f7d36a5144f898546138845166830 : SUCCESS in 10m 23s\n- ironic-python-agent-check-image-dib-centos9-extra https://zuul.opendev.org/t/openstack/build/d58be1e7e8524e30aa113685f5bf3211 : SUCCESS in 11m 00s\n- ironic-python-agent-check-image-dib-debian https://zuul.opendev.org/t/openstack/build/64f160b4f6cc4b3a80c18bcad01f5770 : SUCCESS in 4m 23s\n- ironic-python-agent-check-image-dib-debian-arm64 https://zuul.opendev.org/t/openstack/build/80e0652f7a56420ab2cc34096f2781a9 : SUCCESS in 15m 11s\n- ironic-python-agent-check-image-dib-debian-extra https://zuul.opendev.org/t/openstack/build/d8d8cb6bfc7f49ebac4c0d6dc7ccab14 : SUCCESS in 7m 53s\n- ironic-python-agent-check-image-dib-debian-bullseye https://zuul.opendev.org/t/openstack/build/77fe910efdb14f3da4219c5d714adf73 : SUCCESS in 8m 00s (non-voting)\n- ironic-python-agent-check-image-dib-ubuntu https://zuul.opendev.org/t/openstack/build/6d3027e2a7c54f01a27b7cfc4d353408 : SUCCESS in 9m 13s (non-voting)\n- ironic-python-agent-check-image-dib-ubuntu-arm64 https://zuul.opendev.org/t/openstack/build/0004c62cfcfd4198a3c7f6ef828501f7 : SUCCESS in 18m 36s (non-voting)\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/6002f374f32e47ac86ba64912a66803b : SUCCESS in 52m 43s (non-voting)\n- ipa-tempest-ironic-inspector-src https://zuul.opendev.org/t/openstack/build/f6109427307f4fc5806d0ec41f4b7554 : SUCCESS in 1h 29m 01s (non-voting)\n- ironic-python-agent-builder-tox-codespell https://zuul.opendev.org/t/openstack/build/9bf4fd41c7ee40bdb2a0392db979db9e : FAILURE in 1m 36s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"bb348e748a95d7f6db119388353133dc4f37bf03","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2025-07-10 07:53:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"dc48ae378e190250022083686aa53c971da8a7eb","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2025-07-10 12:02:19.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"075bb396e616b38a151c2ab311c31352d4f9ff05","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-10 12:02:43.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"faecc25cea9d93edd8d2eb2ec28661e54eea158f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-10 14:02:06.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fda8e904113a425c8d5acb4f62b8241a\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a6cf8e41bf2143d3bee2f0f51880a603 : SUCCESS in 9m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a768428f589d49098a2712b91d4c154f : SUCCESS in 2m 42s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/8bf450ebd32f4ceb8e426995fa85fb93 : SUCCESS in 54m 52s\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/22679c3bb50f4972bf75845f396e018b : SUCCESS in 9m 38s\n- ironic-python-agent-check-image-dib-centos9-extra https://zuul.opendev.org/t/openstack/build/c41003a39832476da85e73b4bb976d84 : SUCCESS in 10m 46s\n- ironic-python-agent-check-image-dib-debian https://zuul.opendev.org/t/openstack/build/d58da42c2a554caeb445ccaa2612414a : SUCCESS in 9m 21s\n- ironic-python-agent-check-image-dib-debian-arm64 https://zuul.opendev.org/t/openstack/build/b2ad39d967814f8ba475877f79559e44 : SUCCESS in 13m 38s\n- ironic-python-agent-check-image-dib-debian-extra https://zuul.opendev.org/t/openstack/build/4ca23b058ae04660b0bbf11c4eff2c3e : SUCCESS in 8m 07s","accounts_in_message":[],"_revision_number":2},{"id":"8e0635b791fed77a1b2371fb4efca944999e07eb","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-10 14:02:06.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"d86303fe89a5b868e5f86105ce1aad96f48af8c8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-10 14:03:27.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9b269d4c98644d5388f8ac84c548d21f\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ff81239e66e43d68adce4b60ba94c0f : SUCCESS in 42s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e06a6cf64cc8dee786ae728624afbff758939809","revisions":{"da316fef3c94381dac2c7955a5f2e89562ff2c68":{"kind":"REWORK","_number":1,"created":"2025-07-09 15:58:09.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/24/954524/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent-builder","ref":"refs/changes/24/954524/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/1"}}},"commit":{"parents":[{"commit":"608465b83db9d91147f9579b2781a4e4d310d0ed","subject":"Merge \"Add Mellanox Spectrum to firmware to remove list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/608465b83db9d91147f9579b2781a4e4d310d0ed"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2025-07-09 15:54:06.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2025-07-09 15:54:06.000000000","tz":-420},"subject":"Allow dib build to remove firmware in a structure.","message":"Allow dib build to remove firmware in a structure.\n\nIn some cases, a vendor may do many things and we only need to remove\na specific subset of firmware blobs.\n\nAn example is Mellanox and their Spectrum series of switch controllers.\n\nIn change id Ic8ecf289f1e03e5ee7f36cc6ded707a25cb138c8 we added a\ncommand to attempt to remove a huge amount of firmware blobs from\nmultiple revisions of spectrum series switch controllers\n(i.e. spectrum, spectrum2, spectrum3).\n\nWhere as the prior pattern of the removal script was to just remove whole\nfolders, becuase there was a historical pattern of clean delineation.\n\nAnyhow, now we\u0027ll check to see if there is a slash in the path, and only\nthen allow for the glob expansion to take place which was in the original\nlogic of the removal code when it was first submitted, but where we were\nalso concerned someone would override the list and accidently remove all\nfirmware blobs. In this case, we also check to ensure its not an empty\nstring.\n\nChange-Id: Iab766228cac801d29457e8bee5a05834f1a0f04a\nSigned-off-by: Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/da316fef3c94381dac2c7955a5f2e89562ff2c68"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/da316fef3c94381dac2c7955a5f2e89562ff2c68"}]},"branch":"refs/heads/master"},"e06a6cf64cc8dee786ae728624afbff758939809":{"kind":"REWORK","_number":2,"created":"2025-07-09 16:08:09.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/24/954524/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent-builder","ref":"refs/changes/24/954524/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent-builder refs/changes/24/954524/2"}}},"commit":{"parents":[{"commit":"608465b83db9d91147f9579b2781a4e4d310d0ed","subject":"Merge \"Add Mellanox Spectrum to firmware to remove list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/608465b83db9d91147f9579b2781a4e4d310d0ed"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2025-07-09 15:54:06.000000000","tz":-420},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2025-07-09 16:08:04.000000000","tz":-420},"subject":"Allow dib build to remove firmware in a structure.","message":"Allow dib build to remove firmware in a structure.\n\nIn some cases, a vendor may do many things and we only need to remove\na specific subset of firmware blobs.\n\nAn example is Mellanox and their Spectrum series of switch controllers.\n\nIn change id Ic8ecf289f1e03e5ee7f36cc6ded707a25cb138c8 we added a\ncommand to attempt to remove a huge amount of firmware blobs from\nmultiple revisions of spectrum series switch controllers\n(i.e. spectrum, spectrum2, spectrum3).\n\nWhere as the prior pattern of the removal script was to just remove whole\nfolders, becuase there was a historical pattern of clean delineation.\n\nAnyhow, now we\u0027ll check to see if there is a slash in the path, and only\nthen allow for the glob expansion to take place which was in the original\nlogic of the removal code when it was first submitted, but where we were\nalso concerned someone would override the list and accidently remove all\nfirmware blobs. In this case, we also check to ensure its not an empty\nstring.\n\nChange-Id: Iab766228cac801d29457e8bee5a05834f1a0f04a\nSigned-off-by: Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/e06a6cf64cc8dee786ae728624afbff758939809"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent-builder/commit/e06a6cf64cc8dee786ae728624afbff758939809"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}