)]}'
{"ironic_python_agent/efi_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"95eb8ca740ba4b601e1ac20599cccb6b74eb3e36","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                  part_num, device, part_uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if part_uuid:"},{"line_number":50,"context_line":"        return partition_utils.get_partition(device, part_uuid)"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        LOG.warning(\u0027No UUID information provided in sfdisk output for \u0027"},{"line_number":53,"context_line":"                    \u0027partition %s on device %s\u0027, part_num, device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"305b39f7_a383a196","line":50,"updated":"2026-10-21 14:32:10.000000000","message":"Hmm, not sure how I missed that...","commit_id":"0f9cf51efe5f025e78aad0815557d8874951795d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d26a950cef4714d96b4f68416415bf86a6291ba7","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                  part_num, device, part_uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if part_uuid:"},{"line_number":50,"context_line":"        return partition_utils.get_partition(device, part_uuid)"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        LOG.warning(\u0027No UUID information provided in sfdisk output for \u0027"},{"line_number":53,"context_line":"                    \u0027partition %s on device %s\u0027, part_num, device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e713e0f7_4635a8d6","line":50,"updated":"2026-10-20 10:40:30.000000000","message":"In my testing, --part-uuid returns an upper case value, while we used to use lower case before. Is it a concern?","commit_id":"0f9cf51efe5f025e78aad0815557d8874951795d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3ab4da0e89fd8441786842b87e911ec14001aab0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                  part_num, device, part_uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if part_uuid:"},{"line_number":50,"context_line":"        return partition_utils.get_partition(device, part_uuid)"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        LOG.warning(\u0027No UUID information provided in sfdisk output for \u0027"},{"line_number":53,"context_line":"                    \u0027partition %s on device %s\u0027, part_num, device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4e0d5ab4_073fb34c","line":50,"in_reply_to":"4837a44e_c4074e53","updated":"2026-10-22 08:03:09.000000000","message":"Done","commit_id":"0f9cf51efe5f025e78aad0815557d8874951795d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"cdd00273a168354f08d3652feede401e0fe2ca42","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                  part_num, device, part_uuid)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if part_uuid:"},{"line_number":50,"context_line":"        return partition_utils.get_partition(device, part_uuid)"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        LOG.warning(\u0027No UUID information provided in sfdisk output for \u0027"},{"line_number":53,"context_line":"                    \u0027partition %s on device %s\u0027, part_num, device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4837a44e_c4074e53","line":50,"in_reply_to":"e713e0f7_4635a8d6","updated":"2026-10-20 13:04:10.000000000","message":"UUIDs are case-insensitive, RFC 4122 and the updated RFC 9562 specify that parsers must accept uppercase, lowercase, or mixed-case hexadecimal digits (A–F and a–f) interchangeably, but we preserve the previous behavior passing a lowercase value, check L40","commit_id":"0f9cf51efe5f025e78aad0815557d8874951795d"}],"ironic_python_agent/tests/unit/test_efi_utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f3f042c421832df049bbf6bae3496c6d9cb92a1c","unresolved":true,"context_lines":[{"line_number":715,"context_line":"class TestGetPartitionPathByNumber(base.IronicAgentTest):"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def test_ok(self, mock_execute, mock_get_partition):"},{"line_number":718,"context_line":"        mock_execute.return_value \u003d (hardware_samples.SGDISK_INFO_TEMPLATE, \u0027\u0027)"},{"line_number":719,"context_line":"        mock_get_partition.return_value \u003d \u0027/dev/fake1\u0027"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        result \u003d efi_utils.get_partition_path_by_number(\u0027/dev/fake\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"527e0470_626b7db9","side":"PARENT","line":718,"updated":"2026-10-21 14:53:04.000000000","message":"This sample should be removed from hardware_samples.py. Please do so in a follow up.","commit_id":"b0cfb69296af0929506001d59a9c3c9744bb5188"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5c4b6ba01570c109edbb3db892bddadf3dd249a2","unresolved":false,"context_lines":[{"line_number":715,"context_line":"class TestGetPartitionPathByNumber(base.IronicAgentTest):"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def test_ok(self, mock_execute, mock_get_partition):"},{"line_number":718,"context_line":"        mock_execute.return_value \u003d (hardware_samples.SGDISK_INFO_TEMPLATE, \u0027\u0027)"},{"line_number":719,"context_line":"        mock_get_partition.return_value \u003d \u0027/dev/fake1\u0027"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        result \u003d efi_utils.get_partition_path_by_number(\u0027/dev/fake\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb6d8bcf_b9ffc118","side":"PARENT","line":718,"in_reply_to":"527e0470_626b7db9","updated":"2026-10-22 08:02:57.000000000","message":"Acknowledged","commit_id":"b0cfb69296af0929506001d59a9c3c9744bb5188"}]}
