)]}'
{"ironic_python_agent/cmd/agent.py":[{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"395f229d1cf482ea754e69a7d02735f2a694e55e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # in a text file within the virtual media floppy."},{"line_number":50,"context_line":"    if params.get(\u0027boot_method\u0027, None) \u003d\u003d \u0027vmedia\u0027:"},{"line_number":51,"context_line":"        vmedia_params \u003d _get_vmedia_params()"},{"line_number":52,"context_line":"        params.update(vmedia_params)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return params"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_aca840dc","line":52,"updated":"2014-08-26 23:04:49.000000000","message":"What kind of parameters do you expect to be passing in here? Anything that conflicts with the existing kernel command line params? Just making sure we\u0027re explicit about if the vmedia can/will overwrite kernel command line params, which could be confusing to operators.","commit_id":"44970409c6c3857e540dd70b76e11acef1ae099e"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"028f3dcd971354c1dcb81af030cecf45491e8682","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # in a text file within the virtual media floppy."},{"line_number":50,"context_line":"    if params.get(\u0027boot_method\u0027, None) \u003d\u003d \u0027vmedia\u0027:"},{"line_number":51,"context_line":"        vmedia_params \u003d _get_vmedia_params()"},{"line_number":52,"context_line":"        params.update(vmedia_params)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    return params"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_1ea06842","line":52,"in_reply_to":"1abeadc6_aca840dc","updated":"2014-08-27 08:45:12.000000000","message":"This will contain the parameters that are otherwise passed in kernel cmdline when node is booted with pxe.\n\nFor now, only ipa-api-url is passed:\nhttps://review.openstack.org/#/c/115885/4/ironic/drivers/modules/ilo/deploy.py (L193-205)\n\nConflicting parameters are not expected because vmedia kernel cmdline parameters are static (because the boot media is created only once).  Parameters are expected to come via the floppy image only.","commit_id":"44970409c6c3857e540dd70b76e11acef1ae099e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"92a88339710ef18eb6f6bd36fac009233ad81c5a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    vmedia_device_model \u003d \"virtual media\""},{"line_number":61,"context_line":"    for model_file in sysfs_device_models:"},{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            if vmedia_device_model in open(model_file).read().lower():"},{"line_number":64,"context_line":"                vmedia_device \u003d model_file.split(\u0027/\u0027)[4]"},{"line_number":65,"context_line":"                return vmedia_device"},{"line_number":66,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_1e238d05","line":63,"updated":"2014-08-29 17:30:28.000000000","message":"This file isn\u0027t being closed here, should use `with open(...) as...` or a `finally` block.","commit_id":"44970409c6c3857e540dd70b76e11acef1ae099e"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"941e8064384f318c6cdbcbd866fe24c1bd2a9b76","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    vmedia_device_model \u003d \"virtual media\""},{"line_number":61,"context_line":"    for model_file in sysfs_device_models:"},{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            if vmedia_device_model in open(model_file).read().lower():"},{"line_number":64,"context_line":"                vmedia_device \u003d model_file.split(\u0027/\u0027)[4]"},{"line_number":65,"context_line":"                return vmedia_device"},{"line_number":66,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_be777b3a","line":63,"in_reply_to":"1abeadc6_1e238d05","updated":"2014-09-02 04:08:33.000000000","message":"Done","commit_id":"44970409c6c3857e540dd70b76e11acef1ae099e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"92a88339710ef18eb6f6bd36fac009233ad81c5a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    vmedia_device \u003d _get_vmedia_device()"},{"line_number":77,"context_line":"    if not vmedia_device:"},{"line_number":78,"context_line":"        msg \u003d (\"Unable to find virtual media device\")"},{"line_number":79,"context_line":"        raise errors.VirtualMediaBootError(msg)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    vmedia_device_file \u003d os.path.join(\"/dev\", vmedia_device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_3e1e89bb","line":78,"updated":"2014-08-29 17:30:28.000000000","message":"Nit: don\u0027t need parenthesis around this string","commit_id":"44970409c6c3857e540dd70b76e11acef1ae099e"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"941e8064384f318c6cdbcbd866fe24c1bd2a9b76","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    vmedia_device \u003d _get_vmedia_device()"},{"line_number":77,"context_line":"    if not vmedia_device:"},{"line_number":78,"context_line":"        msg \u003d (\"Unable to find virtual media device\")"},{"line_number":79,"context_line":"        raise errors.VirtualMediaBootError(msg)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    vmedia_device_file \u003d os.path.join(\"/dev\", vmedia_device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_de76ff3d","line":78,"in_reply_to":"1abeadc6_3e1e89bb","updated":"2014-09-02 04:08:33.000000000","message":"Done","commit_id":"44970409c6c3857e540dd70b76e11acef1ae099e"}]}