)]}'
{"doc/source/metrics.rst":[{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"6f19ecccc60bff09110333b72cfdffba6c0df992","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Using a context manager"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":"Using the context manager is the reccomended way for sending metrics that time"},{"line_number":22,"context_line":"or count sections of code. However, given that you cannot cache the"},{"line_number":23,"context_line":"MetricsLogger, you have to explicitly call get_metrics_logger() from"},{"line_number":24,"context_line":"ironic-lib every time. For example:"}],"source_content_type":"text/x-rst","patch_set":32,"id":"bacf61ea_93cfcdaf","line":21,"range":{"start_line":21,"start_character":33,"end_line":21,"end_character":44},"updated":"2016-07-28 12:59:52.000000000","message":"s/reccomended/recommended","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a311da891b9126bc3a9be26786fb07c4b618c351","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Using a context manager"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":"Using the context manager is the reccomended way for sending metrics that time"},{"line_number":22,"context_line":"or count sections of code. However, given that you cannot cache the"},{"line_number":23,"context_line":"MetricsLogger, you have to explicitly call get_metrics_logger() from"},{"line_number":24,"context_line":"ironic-lib every time. For example:"}],"source_content_type":"text/x-rst","patch_set":32,"id":"bacf61ea_31540053","line":21,"range":{"start_line":21,"start_character":33,"end_line":21,"end_character":44},"in_reply_to":"bacf61ea_93cfcdaf","updated":"2016-08-03 18:24:50.000000000","message":"Done","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0043a2336eace54b2df70c0d0809b72f0e7d5fa5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  from ironic_lib import metrics_utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  def my_method():"},{"line_number":29,"context_line":"    with metrics_utils.get_metrics_logger(__name__).timer():"},{"line_number":30,"context_line":"      return _do_work()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"As a note, these metric collectors do work for custom HardwareManagers as"}],"source_content_type":"text/x-rst","patch_set":33,"id":"9ad45d7e_75ab061e","line":29,"updated":"2016-08-09 15:17:30.000000000","message":"nit: in the real code you pass the function name to timer(), why wasn\u0027t it done here?","commit_id":"fd874652e3558cc2f9a3512f0c7b4e2f4170ec22"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0043a2336eace54b2df70c0d0809b72f0e7d5fa5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"References"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"For more information, please read the source of the metrics module in"},{"line_number":53,"context_line":"`ironic-lib \u003chttp://git.openstack.org/cgit/openstack/ironic-lib/tree/ironic_lib\u003e`_."}],"source_content_type":"text/x-rst","patch_set":33,"id":"9ad45d7e_55a6c253","line":53,"updated":"2016-08-09 15:17:30.000000000","message":"oh, we need docs there one day...","commit_id":"fd874652e3558cc2f9a3512f0c7b4e2f4170ec22"}],"ironic_python_agent/agent.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               \u0027hostname, FQDN, or IP address.\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027node_uuid\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027This node\\\u0027s Ironic UUID. This will be set automatically \u0027"},{"line_number":47,"context_line":"                    \u0027when the node boots by querying Ironic.\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"cfg.CONF.register_opts(service_opts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_16ff5c67","line":47,"updated":"2015-01-14 17:35:54.000000000","message":"What do you mean by this? That if not specified, the default is it will be set via querying Ironic, or do you mean that regardless of the value, it will be set via querying Ironic, or ?\n\nOk, I saw the code below. Hmm...","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               \u0027hostname, FQDN, or IP address.\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027node_uuid\u0027,"},{"line_number":46,"context_line":"               help\u003d\u0027This node\\\u0027s Ironic UUID. This will be set automatically \u0027"},{"line_number":47,"context_line":"                    \u0027when the node boots by querying Ironic.\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"cfg.CONF.register_opts(service_opts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_6a56af5d","line":47,"in_reply_to":"3a961159_16ff5c67","updated":"2015-06-08 17:18:55.000000000","message":"This could also be used with statically configured agents (for testing or something) where lookup would fail in Ironic. I\u0027ll improve the help text here.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            config \u003d content.get(\u0027config\u0027, {})"},{"line_number":315,"context_line":"            if config.get(\u0027metrics\u0027):"},{"line_number":316,"context_line":"                self.log.info(\u0027Updating metrics config with values from \u0027"},{"line_number":317,"context_line":"                              \u0027Ironic: {}\u0027.format(config))"},{"line_number":318,"context_line":"                metrics.set_config(config[\u0027metrics\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        wsgi \u003d simple_server.make_server("}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_23589930","line":317,"updated":"2015-01-14 17:35:54.000000000","message":"did you want to log the entire config or config[\u0027metrics\u0027]?","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            config \u003d content.get(\u0027config\u0027, {})"},{"line_number":315,"context_line":"            if config.get(\u0027metrics\u0027):"},{"line_number":316,"context_line":"                self.log.info(\u0027Updating metrics config with values from \u0027"},{"line_number":317,"context_line":"                              \u0027Ironic: {}\u0027.format(config))"},{"line_number":318,"context_line":"                metrics.set_config(config[\u0027metrics\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        wsgi \u003d simple_server.make_server("}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_0a1dfbbc","line":317,"in_reply_to":"3a961159_23589930","updated":"2015-06-08 17:18:55.000000000","message":"[\u0027metrics\u0027] is probably better.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"2b63890030f7d4e18dfc31f9747113874a36c2b5","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"            # Use node uuid for the host option for purposes of metrics"},{"line_number":347,"context_line":"            if self.node.get(\u0027uuid\u0027):"},{"line_number":348,"context_line":"                cfg.CONF.host \u003d self.node[\u0027uuid\u0027]"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            # Update config with values from Ironic"},{"line_number":351,"context_line":"            config \u003d content.get(\u0027config\u0027, {})"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_3159b95b","line":348,"updated":"2016-07-28 13:43:38.000000000","message":"Shouldn\u0027t this be cfg.CONF.metrics.host? (or metrics_statsd.host? or both? I haven\u0027t looked)","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a311da891b9126bc3a9be26786fb07c4b618c351","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"            # Use node uuid for the host option for purposes of metrics"},{"line_number":347,"context_line":"            if self.node.get(\u0027uuid\u0027):"},{"line_number":348,"context_line":"                cfg.CONF.host \u003d self.node[\u0027uuid\u0027]"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            # Update config with values from Ironic"},{"line_number":351,"context_line":"            config \u003d content.get(\u0027config\u0027, {})"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_51f7f458","line":348,"in_reply_to":"bacf61ea_3159b95b","updated":"2016-08-03 18:24:50.000000000","message":"This was based on an earlier version of the metrics API, this should just be fully removed.","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0043a2336eace54b2df70c0d0809b72f0e7d5fa5","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            config \u003d content.get(\u0027config\u0027, {})"},{"line_number":348,"context_line":"            if config.get(\u0027metrics\u0027):"},{"line_number":349,"context_line":"                for opt, val in config.items():"},{"line_number":350,"context_line":"                    setattr(cfg.CONF.metrics, opt, val)"},{"line_number":351,"context_line":"            if config.get(\u0027metrics_statsd\u0027):"},{"line_number":352,"context_line":"                for opt, val in config.items():"},{"line_number":353,"context_line":"                    setattr(cfg.CONF.metrics_statsd, opt, val)"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ad45d7e_15ac4a34","line":350,"updated":"2016-08-09 15:17:30.000000000","message":"I wonder if we should use CONF.set_override instead. not sure what the difference is","commit_id":"fd874652e3558cc2f9a3512f0c7b4e2f4170ec22"}],"ironic_python_agent/common/__init__.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"2b63890030f7d4e18dfc31f9747113874a36c2b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"bacf61ea_2c4a02c6","line":1,"updated":"2016-07-28 13:43:38.000000000","message":"This file isn\u0027t needed, right?","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a311da891b9126bc3a9be26786fb07c4b618c351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"bacf61ea_d1b80478","line":1,"in_reply_to":"bacf61ea_2c4a02c6","updated":"2016-08-03 18:24:50.000000000","message":"Done","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"}],"ironic_python_agent/common/metrics.py":[{"author":{"_account_id":11739,"name":"Alex Weeks","email":"alex.weeks@gmail.com","username":"aweeks"},"change_message_id":"5bff34e52089b5da16e4f6ca4a5cb33534735d09","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                duration \u003d time.time() - start"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"                # Log the timing data as a histogram (to make analysis easier)"},{"line_number":155,"context_line":"                self.histogram(parts, duration)"},{"line_number":156,"context_line":"                return result"},{"line_number":157,"context_line":"            return wrapped"},{"line_number":158,"context_line":"        return decorator"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_7d68dc87","line":155,"updated":"2014-10-10 20:07:06.000000000","message":"It occurs to me that depending upon how the backend (statsd for now) is configured, the counter and histogram will be sent with the same metric name, and could interfere with each other.  It might be worth appending a .counter, or .histogram (or similar) to these metrics to disambiguate them.","commit_id":"862d1ce1c68f53c555b9422188605087601ac42e"},{"author":{"_account_id":11739,"name":"Alex Weeks","email":"alex.weeks@gmail.com","username":"aweeks"},"change_message_id":"5bff34e52089b5da16e4f6ca4a5cb33534735d09","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        return self._send(m_name, m_value, self.METER_TYPE)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"class MetricsManager(object):"},{"line_number":236,"context_line":"    \"\"\"Metrics context manager\"\"\""},{"line_number":237,"context_line":"    def __init__(self, prefix, command_name):"},{"line_number":238,"context_line":"        self.logger \u003d getLogger(prefix)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_7dee1cb6","line":235,"updated":"2014-10-10 20:07:06.000000000","message":"I think a name like InstrumentContext might make it clearer what\u0027s going on, when this is used in code.  For example:\n\nwith metrics.InstrumentContext(\"prefix\", \"do_something\"):\n    do_something()\n\n\nIt might also be worth considering making this class accept a fully-fledged MetricsLogger as a parameter (which you could instantiate with a call to metrics.getLogger()).  This also means that you could add an instrument_context() method to the MetricsLogger class that would return an instance of this class bound to itself, similar to MetricsLogger.instrument() above.  \n\nThen, in code you could do something like:\n\nMETRICS \u003d metrics.getLogger(__name__) # or some other arbitrary prefix\n\nclass Foo(object):\n    ....\n    def bar(self):\n        with METRICS.instrument_context(\"Foo\", \"bar\", \"do_something\"):\n            do_something()","commit_id":"862d1ce1c68f53c555b9422188605087601ac42e"},{"author":{"_account_id":11739,"name":"Alex Weeks","email":"alex.weeks@gmail.com","username":"aweeks"},"change_message_id":"5bff34e52089b5da16e4f6ca4a5cb33534735d09","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    \"\"\"Metrics context manager\"\"\""},{"line_number":237,"context_line":"    def __init__(self, prefix, command_name):"},{"line_number":238,"context_line":"        self.logger \u003d getLogger(prefix)"},{"line_number":239,"context_line":"        self.parts \u003d (prefix, command_name)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __enter__(self):"},{"line_number":242,"context_line":"        self.logger.counter(self.parts, 1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_3d50145e","line":239,"updated":"2014-10-10 20:07:06.000000000","message":"By calling getLogger(prefix), and also including prefix in self.parts, I think the prefix will be included twice in the metric names that are generated.","commit_id":"862d1ce1c68f53c555b9422188605087601ac42e"},{"author":{"_account_id":11739,"name":"Alex Weeks","email":"alex.weeks@gmail.com","username":"aweeks"},"change_message_id":"5bff34e52089b5da16e4f6ca4a5cb33534735d09","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def __exit__(self, exc_type, exc_val, exc_tb):"},{"line_number":247,"context_line":"        duration \u003d time.time() - self.start_time"},{"line_number":248,"context_line":"        # Log the timing data as a histogram (to make analysis easier)"},{"line_number":249,"context_line":"        self.logger.histogram(self.parts, duration)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_1dc9905a","line":248,"updated":"2014-10-10 20:07:06.000000000","message":"The metric naming here could have similar problems to the one mentioned in the instrument() function earlier in this file.","commit_id":"862d1ce1c68f53c555b9422188605087601ac42e"},{"author":{"_account_id":11739,"name":"Alex Weeks","email":"alex.weeks@gmail.com","username":"aweeks"},"change_message_id":"ace0d7f5254aa9f9614f9ead095749d627627eec","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        return self._send(m_name, m_value, self.METER_TYPE)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"class InstrumentContext(object):"},{"line_number":245,"context_line":"    \"\"\"Metrics instrumentation context manager\"\"\""},{"line_number":246,"context_line":"    def __init__(self, prefix, *parts):"},{"line_number":247,"context_line":"        self.logger \u003d getLogger(prefix)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_3ff1c16a","line":244,"updated":"2014-12-17 19:08:02.000000000","message":"It looks like you need to modify this in the same way as instrument() below.","commit_id":"7959b17679479d0a2b2089590db5b1562cdd1564"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"metrics_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027backend\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027noop\u0027,"},{"line_number":31,"context_line":"               help\u003d\u0027Backend to use for the metrics system.\u0027),"},{"line_number":32,"context_line":"    cfg.BoolOpt(\u0027prepend_host\u0027,"},{"line_number":33,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_83678db7","line":30,"updated":"2015-01-14 17:35:54.000000000","message":"that\u0027s an interesting default value. Ok, I see, you have a NoopMetricLogger.\n\nMaybe the help should mention the possible values.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"metrics_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027backend\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027noop\u0027,"},{"line_number":31,"context_line":"               help\u003d\u0027Backend to use for the metrics system.\u0027),"},{"line_number":32,"context_line":"    cfg.BoolOpt(\u0027prepend_host\u0027,"},{"line_number":33,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_f9a95f7c","line":30,"in_reply_to":"3a961159_83678db7","updated":"2015-06-08 17:18:55.000000000","message":"I left off a list because it\u0027s pluggable (though the code isn\u0027t very pluggable yet). I\u0027ll add what\u0027s included by default though.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.BoolOpt(\u0027prepend_uuid\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Prepend the node\\\u0027s Ironic UUID to all metric names \u0027"},{"line_number":44,"context_line":"                     \u0027(after the global_prefix).\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027global_prefix\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Prefix all metric names with this value (before the\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_03fabd76","line":44,"updated":"2015-01-14 17:35:54.000000000","message":"what\u0027s the order? Based on the code, it looks like global_prefix\u003cdelim\u003euuid\u003cdelim\u003ehost\u003cdelim\u003e\u003cmetric-name\u003e","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.BoolOpt(\u0027prepend_uuid\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Prepend the node\\\u0027s Ironic UUID to all metric names \u0027"},{"line_number":44,"context_line":"                     \u0027(after the global_prefix).\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027global_prefix\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Prefix all metric names with this value (before the\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_ffffffa7","line":44,"in_reply_to":"3a961159_03fabd76","updated":"2015-06-08 17:18:55.000000000","message":"I\u0027ll update all these config options to make it clear (you shouldn\u0027t have to read the code to understand). That\u0027s the correct order though.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     \u0027(after the global_prefix).\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027global_prefix\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Prefix all metric names with this value (before the\u0027"},{"line_number":48,"context_line":"                    \u0027host, if prepend_host is set).\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027statsd_host\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027localhost\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_037e3d1b","line":47,"updated":"2015-01-14 17:35:54.000000000","message":"missing a blank space after \u0027the\u0027","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     \u0027(after the global_prefix).\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027global_prefix\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Prefix all metric names with this value (before the\u0027"},{"line_number":48,"context_line":"                    \u0027host, if prepend_host is set).\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027statsd_host\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027localhost\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_c4d47a48","line":47,"in_reply_to":"3a961159_037e3d1b","updated":"2015-06-08 17:18:55.000000000","message":"Done","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                             \"[0.0, 1.0]\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if sample_rate is None or random.random() \u003c sample_rate:"},{"line_number":103,"context_line":"            return self._counter(self._getMetricName(m_parts) + \u0027.counter\u0027,"},{"line_number":104,"context_line":"                                 m_value, sample_rate\u003dsample_rate)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def timer(self, m_parts, m_value):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_83014d09","line":103,"updated":"2015-01-14 17:35:54.000000000","message":"so regardless of the delimiter value, you want the name to end in \u0027.counter\u0027?\n\nAlso, why do you add .counter here, but no .gauge or .timer or .meter in the other methods?","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                             \"[0.0, 1.0]\")"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if sample_rate is None or random.random() \u003c sample_rate:"},{"line_number":103,"context_line":"            return self._counter(self._getMetricName(m_parts) + \u0027.counter\u0027,"},{"line_number":104,"context_line":"                                 m_value, sample_rate\u003dsample_rate)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def timer(self, m_parts, m_value):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_aadee73c","line":103,"in_reply_to":"3a961159_83014d09","updated":"2015-06-08 17:18:55.000000000","message":"Yeah, that\u0027s definitely incorrect. I\u0027ll fix it to use the delimiter. I\u0027m told adding \u0027.counter\u0027 is somewhat of a convention, but I\u0027m going to drop it (statsd doesn\u0027t actually care about it).","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            metric \u003d \u0027%s:%s|%s@%s\u0027 % (m_name, m_value, m_type, sample_rate)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        LOG.info(\u0027statsd: sending %(metric)s to %(target)s\u0027 %"},{"line_number":203,"context_line":"                 {\u0027metric\u0027: metric, \u0027target\u0027: self._target})"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # Ideally, we\u0027d cache a sending socket in self, but that"},{"line_number":206,"context_line":"        # results in a socket getting shared by multiple green threads."}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_8644fbb8","line":203,"updated":"2015-01-14 17:35:54.000000000","message":"won\u0027t this cause a lot of logs? Did you want debug instead? Or maybe you want it as info, I think you guys like logs.\n\nYou might want to avoid using string interpolation [1]\n\n1] https://stackoverflow.com/questions/11615053/why-use-multiple-arguments-to-log-instead-of-interpolation","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            metric \u003d \u0027%s:%s|%s@%s\u0027 % (m_name, m_value, m_type, sample_rate)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        LOG.info(\u0027statsd: sending %(metric)s to %(target)s\u0027 %"},{"line_number":203,"context_line":"                 {\u0027metric\u0027: metric, \u0027target\u0027: self._target})"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # Ideally, we\u0027d cache a sending socket in self, but that"},{"line_number":206,"context_line":"        # results in a socket getting shared by multiple green threads."}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_5904f348","line":203,"in_reply_to":"3a961159_8644fbb8","updated":"2015-06-08 17:18:55.000000000","message":"Heh we do love our logs! But yeah, debug is probably the correct level. +1 on avoiding interpolation.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"def getLogger(prefix):"},{"line_number":284,"context_line":"    \"\"\"Return a metric logger with the specified prefix.\"\"\""},{"line_number":285,"context_line":"    if isinstance(prefix, basestring):"},{"line_number":286,"context_line":"        prefix \u003d [prefix]"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_66e38f05","line":284,"updated":"2015-01-14 17:35:54.000000000","message":"it can be more than the \u0027prefix\u0027 parameter.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"def getLogger(prefix):"},{"line_number":284,"context_line":"    \"\"\"Return a metric logger with the specified prefix.\"\"\""},{"line_number":285,"context_line":"    if isinstance(prefix, basestring):"},{"line_number":286,"context_line":"        prefix \u003d [prefix]"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_04ef32b1","line":284,"in_reply_to":"3a961159_66e38f05","updated":"2015-06-08 17:18:55.000000000","message":"This is very poorly worded :/ the whole logger is prefixed with global_prefix.uuid.host.prefix","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        prefix \u003d [CONF.metrics.global_prefix] + prefix"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    if CONF.metrics.backend \u003d\u003d \u0027statsd\u0027:"},{"line_number":303,"context_line":"        return StatsdMetricLogger(prefix, \u0027.\u0027,"},{"line_number":304,"context_line":"                                  host\u003dCONF.metrics.statsd_host,"},{"line_number":305,"context_line":"                                  port\u003dCONF.metrics.statsd_port)"},{"line_number":306,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_b92598af","line":303,"updated":"2015-01-14 17:35:54.000000000","message":"why not make the delimiter configurable instead of hardcoding \u0027.\u0027?","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        prefix \u003d [CONF.metrics.global_prefix] + prefix"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    if CONF.metrics.backend \u003d\u003d \u0027statsd\u0027:"},{"line_number":303,"context_line":"        return StatsdMetricLogger(prefix, \u0027.\u0027,"},{"line_number":304,"context_line":"                                  host\u003dCONF.metrics.statsd_host,"},{"line_number":305,"context_line":"                                  port\u003dCONF.metrics.statsd_port)"},{"line_number":306,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_6adfcf69","line":303,"in_reply_to":"3a961159_b92598af","updated":"2015-06-08 17:18:55.000000000","message":"The delimiter should be configurable within a class (each plugin can have its own delimiter), but Statsd only supports \u0027.\u0027 as the delimiter (at least last time I checked).","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                                  host\u003dCONF.metrics.statsd_host,"},{"line_number":305,"context_line":"                                  port\u003dCONF.metrics.statsd_port)"},{"line_number":306,"context_line":"    else:"},{"line_number":307,"context_line":"        return NoopMetricLogger(prefix, \u0027.\u0027)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"def set_config(config):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_3940c834","line":307,"updated":"2015-01-14 17:35:54.000000000","message":"what if someone set CONF.metrics.backend \u003d\u003d \u0027foo\u0027, or \u0027Statsd\u0027? Would an exception be more useful?","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                                  host\u003dCONF.metrics.statsd_host,"},{"line_number":305,"context_line":"                                  port\u003dCONF.metrics.statsd_port)"},{"line_number":306,"context_line":"    else:"},{"line_number":307,"context_line":"        return NoopMetricLogger(prefix, \u0027.\u0027)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"def set_config(config):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_ffc01f2c","line":307,"in_reply_to":"3a961159_3940c834","updated":"2015-06-08 17:18:55.000000000","message":"Yes, definitely.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"945863482cb1a8b317f458f2e29b48d207adf020","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    lookup call to the conductor."},{"line_number":315,"context_line":"    \"\"\""},{"line_number":316,"context_line":"    for opt, val in config.items():"},{"line_number":317,"context_line":"        setattr(CONF.metrics, opt, val)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_86febbad","line":317,"updated":"2015-01-14 17:35:54.000000000","message":"This could add configs that the agent doesn\u0027t use, eg opt\u003d\u0027foo\u0027, val \u003d \u0027bar\u0027?","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"a3d8ef0bb41f04ce357c3f2035fa07876c587670","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    lookup call to the conductor."},{"line_number":315,"context_line":"    \"\"\""},{"line_number":316,"context_line":"    for opt, val in config.items():"},{"line_number":317,"context_line":"        setattr(CONF.metrics, opt, val)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_cad48348","line":317,"in_reply_to":"3a961159_86febbad","updated":"2015-06-08 17:18:55.000000000","message":"That\u0027s true, but I don\u0027t think that\u0027s an issue. Could be useful for plugins to have additional values if necessary.","commit_id":"8fabef78e60d079042edccbff6b2a2d3197359fa"}],"ironic_python_agent/extensions/base.py":[{"author":{"_account_id":11739,"name":"Alex Weeks","email":"alex.weeks@gmail.com","username":"aweeks"},"change_message_id":"5bff34e52089b5da16e4f6ca4a5cb33534735d09","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def run(self):"},{"line_number":97,"context_line":"        try:"},{"line_number":98,"context_line":"            with metrics.MetricsManager(self.command_name, self.command_name):"},{"line_number":99,"context_line":"                result \u003d self.execute_method(**self.command_params)"},{"line_number":100,"context_line":"            with self.command_state_lock:"},{"line_number":101,"context_line":"                self.command_result \u003d result"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_3864a2e4","line":98,"updated":"2014-10-10 20:07:06.000000000","message":"Do you really want the command_name to appear twice in the metric name?","commit_id":"862d1ce1c68f53c555b9422188605087601ac42e"}],"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"697396a0fbadf37579b166876fb407c44a200027","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # don\u0027t write image again if already cached"},{"line_number":199,"context_line":"        if self.cached_image_id !\u003d image_info[\u0027id\u0027]:"},{"line_number":200,"context_line":"            with metrics.MetricsManager(\u0027cache_image\u0027, \u0027_download_image\u0027):"},{"line_number":201,"context_line":"                _download_image(image_info)"},{"line_number":202,"context_line":"            with metrics.MetricsManager(\u0027cache_image\u0027, \u0027_write_image\u0027):"},{"line_number":203,"context_line":"                _write_image(image_info, device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_fbccbf63","line":200,"updated":"2014-10-21 15:33:10.000000000","message":"prepare_image?","commit_id":"862d1ce1c68f53c555b9422188605087601ac42e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9fbf9803d6cc21af16d1ff376edf42b1caf67022","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        if configdrive is not None:"},{"line_number":217,"context_line":"            with metrics.instrument_context("},{"line_number":218,"context_line":"                    __name__, \u0027cache_image\u0027,"},{"line_number":219,"context_line":"                    \u0027_write_configdrive_to_partition\u0027):"},{"line_number":220,"context_line":"                _write_configdrive_to_partition(configdrive, device)"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_41784f2b","line":218,"updated":"2014-12-10 17:00:35.000000000","message":"s/cache_image/prepare_image/","commit_id":"5aa3d3175ea0a46a137e0c8726d73f3d89f3b75a"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"78013b064839098fe51877c73d3cfebce0c59206","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        if configdrive is not None:"},{"line_number":217,"context_line":"            with metrics.instrument_context("},{"line_number":218,"context_line":"                    __name__, \u0027cache_image\u0027,"},{"line_number":219,"context_line":"                    \u0027_write_configdrive_to_partition\u0027):"},{"line_number":220,"context_line":"                _write_configdrive_to_partition(configdrive, device)"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_5cd90d21","line":218,"in_reply_to":"3a961159_41784f2b","updated":"2014-12-10 23:08:03.000000000","message":"Done","commit_id":"5aa3d3175ea0a46a137e0c8726d73f3d89f3b75a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9fbf9803d6cc21af16d1ff376edf42b1caf67022","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                _write_configdrive_to_partition(configdrive, device)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @base.async_command(\u0027run_image\u0027)"},{"line_number":223,"context_line":"    @metrics.instrument(__name__, \u0027run_image\u0027)"},{"line_number":224,"context_line":"    def run_image(self):"},{"line_number":225,"context_line":"        script \u003d _path_to_script(\u0027shell/reboot.sh\u0027)"},{"line_number":226,"context_line":"        LOG.info(\u0027Rebooting system\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_21cb4354","line":223,"updated":"2014-12-10 17:00:35.000000000","message":"I don\u0027t know if this context manager will ever call its __exit__ as the reboot should hit before the function returns.","commit_id":"5aa3d3175ea0a46a137e0c8726d73f3d89f3b75a"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"78013b064839098fe51877c73d3cfebce0c59206","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                _write_configdrive_to_partition(configdrive, device)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @base.async_command(\u0027run_image\u0027)"},{"line_number":223,"context_line":"    @metrics.instrument(__name__, \u0027run_image\u0027)"},{"line_number":224,"context_line":"    def run_image(self):"},{"line_number":225,"context_line":"        script \u003d _path_to_script(\u0027shell/reboot.sh\u0027)"},{"line_number":226,"context_line":"        LOG.info(\u0027Rebooting system\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_3cd0c1f5","line":223,"in_reply_to":"3a961159_21cb4354","updated":"2014-12-10 23:08:03.000000000","message":"You\u0027re right, I think I\u0027ll just kill this. Also this function isn\u0027t used yet, so far as I can tell.","commit_id":"5aa3d3175ea0a46a137e0c8726d73f3d89f3b75a"}],"ironic_python_agent/utils.py":[{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"6f19ecccc60bff09110333b72cfdffba6c0df992","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"METRICS \u003d None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def execute(*cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_b320119d","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":14},"updated":"2016-07-28 12:59:52.000000000","message":"Is this still needed?","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a311da891b9126bc3a9be26786fb07c4b618c351","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"METRICS \u003d None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def execute(*cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_f1b5487e","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":14},"in_reply_to":"bacf61ea_b320119d","updated":"2016-08-03 18:24:50.000000000","message":"Done","commit_id":"a17b8815ba1a0a1449fa1b4b5611b6f804b87ca7"}]}
