)]}'
{"ironic_python_agent/cmd/agent.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b65151b65482bd3ead2a30920ba5cb4492735442","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def _read_params_from_file(filepath):"},{"line_number":30,"context_line":"    \"\"\"Extract key\u003dvalue pairs from a file."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    :param filepath: path to a file containing key\u003dvalues separated by"},{"line_number":33,"context_line":"                     whitespace or newlines."},{"line_number":34,"context_line":"    :returns: a dictionary representing the content of the file"},{"line_number":35,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_6cc8d455","line":32,"updated":"2014-09-11 09:04:08.000000000","message":"I guess \u0027key\u003dvalue pairs\u0027 instead of \u0027key\u003dvalues\u0027 would be better here","commit_id":"96c6790b4be120ccb95aae3e8d83fa23c641e26a"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"d507a6714bf18f6f43f52c2697f7a3093c61e752","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Parameters can be passed using either the kernel commandline or through"},{"line_number":54,"context_line":"    virtual media. If boot_method is vmedia, merge params provided via vmedia"},{"line_number":55,"context_line":"    with those read from the kernel command line."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    :returns: a dict of potential configuration parameters for the agent"},{"line_number":58,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_67513262","line":55,"updated":"2014-09-22 17:43:29.000000000","message":"It might be worth mentioning who wins if the same parameter is given in both vmedia and command line (if that\u0027s even possible). From the code, it looks like vmedia wins.","commit_id":"4029f6c379e0b997fa57a5d1800b41486c8bb3ad"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b72f984fcd580154f7a8d3f25332c571199aa191","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Parameters can be passed using either the kernel commandline or through"},{"line_number":54,"context_line":"    virtual media. If boot_method is vmedia, merge params provided via vmedia"},{"line_number":55,"context_line":"    with those read from the kernel command line."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    :returns: a dict of potential configuration parameters for the agent"},{"line_number":58,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_a263c3da","line":55,"in_reply_to":"da9df570_39963cf1","updated":"2014-09-24 16:35:01.000000000","message":"I\u0027ll both note: 1) Who wins and 2) Why it should never happen :)","commit_id":"4029f6c379e0b997fa57a5d1800b41486c8bb3ad"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"aca07d58163d92dd9e832fe6163047be1cf95212","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Parameters can be passed using either the kernel commandline or through"},{"line_number":54,"context_line":"    virtual media. If boot_method is vmedia, merge params provided via vmedia"},{"line_number":55,"context_line":"    with those read from the kernel command line."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    :returns: a dict of potential configuration parameters for the agent"},{"line_number":58,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_39963cf1","line":55,"in_reply_to":"da9df570_67513262","updated":"2014-09-24 05:50:15.000000000","message":"Normally this is not possible.  In a vmedia boot, the parameters in kernel command line are static(they don\u0027t differ across boots and are static within the ISOs and only \u0027boot_method\u0027 is provided).","commit_id":"4029f6c379e0b997fa57a5d1800b41486c8bb3ad"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9a66f57efc0acb601ec1570c75561666fbf9f5da","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    vmedia_device \u003d _get_vmedia_device()"},{"line_number":97,"context_line":"    if not vmedia_device:"},{"line_number":98,"context_line":"        msg \u003d \"Unable to find virtual media device\""},{"line_number":99,"context_line":"        raise errors.VirtualMediaBootError(msg)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    vmedia_device_file \u003d os.path.join(\"/dev\", vmedia_device)"},{"line_number":102,"context_line":"    os.mkdir(vmedia_mount_point)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_603e008e","line":99,"updated":"2014-09-26 08:01:48.000000000","message":"Oh, missed it, raises should be also added to docstring.","commit_id":"4029f6c379e0b997fa57a5d1800b41486c8bb3ad"}]}