)]}'
{"ironic_python_agent/extensions/base.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c72fa369edc86efbaa1c106001cc23a266418d0f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        thread_name \u003d \u0027agent-command-{0}\u0027.format(self.id)"},{"line_number":75,"context_line":"        self.execution_thread \u003d threading.Thread(target\u003dself.run,"},{"line_number":76,"context_line":"                                                 name\u003dthread_name)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def serialize(self):"},{"line_number":79,"context_line":"        with self.command_state_lock:"},{"line_number":80,"context_line":"            return super(AsyncCommandResult, self).serialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_a8962fee","side":"PARENT","line":77,"updated":"2014-09-11 03:03:03.000000000","message":"this blank line should not be removed I think.","commit_id":"96c6790b4be120ccb95aae3e8d83fa23c641e26a"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"61c817b35409d64329881c8f6c3181469d1e1be4","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        :param command_name: name of command to execute"},{"line_number":97,"context_line":"        :param command_params: parameters passed to command"},{"line_number":98,"context_line":"        :param execute_method: a callable to be executed asynchronously"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        super(AsyncCommandResult, self).__init__(command_name, command_params)"},{"line_number":101,"context_line":"        self.agent \u003d agent"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_9edcbb48","line":98,"updated":"2014-11-19 01:14:09.000000000","message":":param agent: ...","commit_id":"abccd60fc837fcb59dee1d9a0b807800231a8641"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7e86e44930a33b64c615365486a74e232ddd030b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                                 name\u003dthread_name)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def serialize(self):"},{"line_number":111,"context_line":"        \"\"\"Locks, then serializes the AsyncCommandResult into a dict."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :returns: dict containing serializable fields in AsyncCommandResult"},{"line_number":114,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_e59ac312","line":111,"updated":"2014-11-25 17:43:21.000000000","message":"I don\u0027t think you need \"Locks, then\" here.","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6a803e278a5bc0220a96510e3ff30fc4a3d6596e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                                                 name\u003dthread_name)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def serialize(self):"},{"line_number":111,"context_line":"        \"\"\"Locks, then serializes the AsyncCommandResult into a dict."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :returns: dict containing serializable fields in AsyncCommandResult"},{"line_number":114,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_7b9d9465","line":111,"in_reply_to":"5a890539_e59ac312","updated":"2014-11-25 18:19:46.000000000","message":"Done","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7e86e44930a33b64c615365486a74e232ddd030b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        return self"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def join(self, timeout\u003dNone):"},{"line_number":124,"context_line":"        \"\"\"Join the thread to synchronously execute command."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        :param timeout: float indicating max seconds to wait for command"},{"line_number":127,"context_line":"                        to complete. Defaults to None."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_a58c3bd8","line":124,"updated":"2014-11-25 17:43:21.000000000","message":"I think this might be better worded as \"Block until command has completed, and return result.\" or something.","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6a803e278a5bc0220a96510e3ff30fc4a3d6596e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        return self"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def join(self, timeout\u003dNone):"},{"line_number":124,"context_line":"        \"\"\"Join the thread to synchronously execute command."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        :param timeout: float indicating max seconds to wait for command"},{"line_number":127,"context_line":"                        to complete. Defaults to None."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_9b988076","line":124,"in_reply_to":"5a890539_a58c3bd8","updated":"2014-11-25 18:19:46.000000000","message":"Done","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7e86e44930a33b64c615365486a74e232ddd030b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        return self"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def is_done(self):"},{"line_number":133,"context_line":"        \"\"\"Locks, then checks to see if command is still RUNNING."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        :returns: True if command is done, False if still RUNNING"},{"line_number":136,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_c5bea764","line":133,"updated":"2014-11-25 17:43:21.000000000","message":"I don\u0027t think you need \"locks, then\" here.","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6a803e278a5bc0220a96510e3ff30fc4a3d6596e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        return self"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def is_done(self):"},{"line_number":133,"context_line":"        \"\"\"Locks, then checks to see if command is still RUNNING."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        :returns: True if command is done, False if still RUNNING"},{"line_number":136,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_fb80a4f8","line":133,"in_reply_to":"5a890539_c5bea764","updated":"2014-11-25 18:19:46.000000000","message":"Done","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7e86e44930a33b64c615365486a74e232ddd030b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            return super(AsyncCommandResult, self).is_done()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def run(self):"},{"line_number":141,"context_line":"        \"\"\"Used by start() to run a command synchronously in a thread.\"\"\""},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            result \u003d self.execute_method(**self.command_params)"},{"line_number":144,"context_line":"            with self.command_state_lock:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_25468b7b","line":141,"updated":"2014-11-25 17:43:21.000000000","message":"I think this should be \"run a command\". This method has nothing to do with threads, and that it\u0027s used by start() doesn\u0027t matter as far as docs go. If we don\u0027t want it to be used outside of this class, we should rename it to _run.","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6a803e278a5bc0220a96510e3ff30fc4a3d6596e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            return super(AsyncCommandResult, self).is_done()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def run(self):"},{"line_number":141,"context_line":"        \"\"\"Used by start() to run a command synchronously in a thread.\"\"\""},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            result \u003d self.execute_method(**self.command_params)"},{"line_number":144,"context_line":"            with self.command_state_lock:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_1b849009","line":141,"in_reply_to":"5a890539_25468b7b","updated":"2014-11-25 18:19:46.000000000","message":"Done","commit_id":"f18f619b5aa54616417aba0a9c191fe33b3f4e2d"}]}