)]}'
{"imagebuild/coreos/coreos-oem-inject.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6cedacc45d9d1c662d602486b4d33daba2ebc8fe","unresolved":false,"context_lines":[{"line_number":95,"context_line":"def validate_digests(digests, target, hash_type\u003d\u0027sha1\u0027):"},{"line_number":96,"context_line":"    cmd_chain \u003d (\u0027grep -i -A1 ^# \u0027 + hash_type + \u0027 HASH$ \u0027 + digests + \u0027 | \u0027 +"},{"line_number":97,"context_line":"                 \u0027grep \u0027 + os.path.basename(target) + \u0027 | \u0027 +"},{"line_number":98,"context_line":"                 hash_type + \u0027sum -c /dev/stdin\u0027)"},{"line_number":99,"context_line":"    subprocess.Popen(cmd_chain, shell\u003dTrue, cwd\u003dos.path.dirname(digests))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_372393a8","line":98,"updated":"2014-09-19 17:04:01.000000000","message":"Would prefer to use python string formatting here.","commit_id":"3179c910520d6a708f81d7fd4daddc5147e54b1a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a4baacbce715abe81da9a540ffc63914c3c90291","unresolved":false,"context_lines":[{"line_number":95,"context_line":"def validate_digests(digests, target, hash_type\u003d\u0027sha1\u0027):"},{"line_number":96,"context_line":"    cmd_chain \u003d (\u0027grep -i -A1 ^# \u0027 + hash_type + \u0027 HASH$ \u0027 + digests + \u0027 | \u0027 +"},{"line_number":97,"context_line":"                 \u0027grep \u0027 + os.path.basename(target) + \u0027 | \u0027 +"},{"line_number":98,"context_line":"                 hash_type + \u0027sum -c /dev/stdin\u0027)"},{"line_number":99,"context_line":"    subprocess.Popen(cmd_chain, shell\u003dTrue, cwd\u003dos.path.dirname(digests))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_d787f90d","line":98,"in_reply_to":"fa98f980_372393a8","updated":"2014-09-22 12:38:47.000000000","message":"Done","commit_id":"3179c910520d6a708f81d7fd4daddc5147e54b1a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6cedacc45d9d1c662d602486b4d33daba2ebc8fe","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"def gpg_key():"},{"line_number":167,"context_line":"    # GPG_LONG_ID \u003d \"50E0885593D2DCB4\""},{"line_number":168,"context_line":"    GPG_KEY \u003d \"\"\"-----BEGIN PGP PUBLIC KEY BLOCK-----"},{"line_number":169,"context_line":"    Version: GnuPG v2.0.20 (GNU/Linux)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_17a5af03","line":167,"updated":"2014-09-19 17:04:01.000000000","message":"Why was this commented out? Looks like it isn\u0027t needed, just remove it?\n\nMaybe even just remove this function and reference the key directly where this function is used.","commit_id":"3179c910520d6a708f81d7fd4daddc5147e54b1a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a4baacbce715abe81da9a540ffc63914c3c90291","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"def gpg_key():"},{"line_number":167,"context_line":"    # GPG_LONG_ID \u003d \"50E0885593D2DCB4\""},{"line_number":168,"context_line":"    GPG_KEY \u003d \"\"\"-----BEGIN PGP PUBLIC KEY BLOCK-----"},{"line_number":169,"context_line":"    Version: GnuPG v2.0.20 (GNU/Linux)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_f77b1d27","line":167,"in_reply_to":"fa98f980_17a5af03","updated":"2014-09-22 12:38:47.000000000","message":"Done","commit_id":"3179c910520d6a708f81d7fd4daddc5147e54b1a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cd35fa738e0a9f29eea65f5a5b28793992a54d02","unresolved":false,"context_lines":[{"line_number":95,"context_line":"def validate_digests(digests, target, hash_type\u003d\u0027sha1\u0027):"},{"line_number":96,"context_line":"    cmd_chain \u003d \u0027grep -i -A1 ^# {0} HASH$ {1} | grep {2} | \u0027 \\"},{"line_number":97,"context_line":"                \u0027{0}sum -c /dev/stdin\u0027.format(hash_type, digests,"},{"line_number":98,"context_line":"                                              os.path.basename(target))"},{"line_number":99,"context_line":"    execute(cmd_chain, shell\u003dTrue, cwd\u003dos.path.dirname(digests))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_4dfff534","line":98,"updated":"2014-09-22 14:27:12.000000000","message":"Ironic\u0027s standard is to use named formatting parameters when there is more than one parameter, I think we should follow that here.","commit_id":"99c5cc4d05f0c0ffa506866508db811d366e55f5"}]}