)]}'
{"ironic_python_agent/cmd/agent.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"55b45d1dc7e325b134b0cc9e6858446e2a4c508a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"cli_opts \u003d ["},{"line_number":116,"context_line":"    cfg.StrOpt(\u0027api-url\u0027,"},{"line_number":117,"context_line":"                  required\u003d(\u0027ipa-api-url\u0027 not in KPARAMS),"},{"line_number":118,"context_line":"                  default\u003dKPARAMS.get(\u0027ipa-api-url\u0027),"},{"line_number":119,"context_line":"                  deprecated_name\u003d\u0027api_url\u0027,"},{"line_number":120,"context_line":"                  help\u003d\u0027URL of the Ironic API\u0027),"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5ff072c9","line":118,"updated":"2014-11-19 18:20:59.000000000","message":"Should we also make the ipa-api-url and similar keys in the kernel command line take _ as well as - too?","commit_id":"fa060cbd8bcf8010a5605f476b901c94e6a64414"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"87baed0d9c6323ea1c39c57eadc57dd1a88ba691","unresolved":false,"context_lines":[{"line_number":115,"context_line":"cli_opts \u003d ["},{"line_number":116,"context_line":"    cfg.StrOpt(\u0027api-url\u0027,"},{"line_number":117,"context_line":"                  required\u003d(\u0027ipa-api-url\u0027 not in KPARAMS),"},{"line_number":118,"context_line":"                  default\u003dKPARAMS.get(\u0027ipa-api-url\u0027),"},{"line_number":119,"context_line":"                  deprecated_name\u003d\u0027api_url\u0027,"},{"line_number":120,"context_line":"                  help\u003d\u0027URL of the Ironic API\u0027),"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_4baa6ad5","line":118,"in_reply_to":"5a890539_5ff072c9","updated":"2014-11-19 23:41:36.000000000","message":"Wondering this myself.","commit_id":"fa060cbd8bcf8010a5605f476b901c94e6a64414"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"55b45d1dc7e325b134b0cc9e6858446e2a4c508a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    cfg.StrOpt(\u0027api-url\u0027,"},{"line_number":117,"context_line":"                  required\u003d(\u0027ipa-api-url\u0027 not in KPARAMS),"},{"line_number":118,"context_line":"                  default\u003dKPARAMS.get(\u0027ipa-api-url\u0027),"},{"line_number":119,"context_line":"                  deprecated_name\u003d\u0027api_url\u0027,"},{"line_number":120,"context_line":"                  help\u003d\u0027URL of the Ironic API\u0027),"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    cfg.StrOpt(\u0027listen-host\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5f195221","line":119,"updated":"2014-11-19 18:20:59.000000000","message":"The deprecated_name should be the old value, not the new one.","commit_id":"fa060cbd8bcf8010a5605f476b901c94e6a64414"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"87baed0d9c6323ea1c39c57eadc57dd1a88ba691","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    cfg.StrOpt(\u0027api-url\u0027,"},{"line_number":117,"context_line":"                  required\u003d(\u0027ipa-api-url\u0027 not in KPARAMS),"},{"line_number":118,"context_line":"                  default\u003dKPARAMS.get(\u0027ipa-api-url\u0027),"},{"line_number":119,"context_line":"                  deprecated_name\u003d\u0027api_url\u0027,"},{"line_number":120,"context_line":"                  help\u003d\u0027URL of the Ironic API\u0027),"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    cfg.StrOpt(\u0027listen-host\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_2b419e0b","line":119,"in_reply_to":"5a890539_5f195221","updated":"2014-11-19 23:41:36.000000000","message":"Technically, you\u0027re right, but I almost think this is fine... The weird thing is, if we go this route, we can\u0027t actually deprecate anything.\n\nI think we should change the names to use _, use - for deprecated names for a cycle(?), and then cut over completely to _.","commit_id":"fa060cbd8bcf8010a5605f476b901c94e6a64414"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"41bcc7e4a5d905fbd93bd1e5f7634170f60cdba9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    cfg.StrOpt(\u0027api_url\u0027,"},{"line_number":117,"context_line":"                  required\u003d(\u0027ipa_api_url\u0027 not in KPARAMS),"},{"line_number":118,"context_line":"                  default\u003dKPARAMS.get(\u0027ipa_api_url\u0027),"},{"line_number":119,"context_line":"                  deprecated_name\u003d\u0027api-url\u0027,"},{"line_number":120,"context_line":"                  help\u003d\u0027URL of the Ironic API\u0027),"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    cfg.StrOpt(\u0027listen_host\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_eb86b615","line":119,"updated":"2014-11-28 15:04:09.000000000","message":"I have some questions on using the deprecated name here.  I assume the intent is to work with an older Ironic system that is sending \u0027ipa-api-url\u0027  instead of \u0027ipa_api_url\u0027.  If that is the purpose, I think using it in deprecated name wouldn\u0027t work.  Instead we should modify the above line.\n\ndefault \u003d KPARAMS.get(\u0027ipa_api_url\u0027) or KPARAMS.get(\u0027ipa-api-url\u0027)\n\nI don\u0027t think we need to use deprecated_name here as IPA will never read from any configuration files.","commit_id":"b816a48c9fc3c39689a1c93aa604a7dff308ab2f"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45db88d71f515953076fac606d89563021906b2c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    cfg.StrOpt(\u0027api_url\u0027,"},{"line_number":117,"context_line":"                  required\u003d(\u0027ipa_api_url\u0027 not in KPARAMS),"},{"line_number":118,"context_line":"                  default\u003dKPARAMS.get(\u0027ipa_api_url\u0027),"},{"line_number":119,"context_line":"                  deprecated_name\u003d\u0027api-url\u0027,"},{"line_number":120,"context_line":"                  help\u003d\u0027URL of the Ironic API\u0027),"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    cfg.StrOpt(\u0027listen_host\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_3ebabe6e","line":119,"in_reply_to":"5a890539_eb86b615","updated":"2014-11-28 15:59:59.000000000","message":"After talking to Jim, I came to know that we want to use config files with IPA.  So ignore my comment \"don\u0027t think we need to use deprecated_name\", Just that we need to fix the kernel params as well.","commit_id":"b816a48c9fc3c39689a1c93aa604a7dff308ab2f"}]}