)]}'
{"id":"openstack%2Fironic-python-agent~131632","triplet_id":"openstack%2Fironic-python-agent~master~Ie10a548191effa2a505309d9d4ee32003f9676a2","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1386486","hashtags":[],"change_id":"Ie10a548191effa2a505309d9d4ee32003f9676a2","subject":"Use _ instead of - for config options","status":"MERGED","created":"2014-10-29 04:31:33.000000000","updated":"2014-12-03 19:46:12.000000000","submitted":"2014-12-03 19:46:12.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"13a78d23a02c6d1a3b1604e0d8cbba1d78efb62b","_number":131632,"virtual_id_number":131632,"owner":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},{"value":2,"date":"2014-12-03 19:46:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":2,"date":"2014-12-03 17:51:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2014-12-03 16:09:30.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":2,"date":"2014-12-03 19:41:17.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"all":[{"value":0,"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":1,"date":"2014-12-03 19:41:17.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-29 04:31:44.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2014-11-24 16:05:32.000000000","updated_by":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"reviewer":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"state":"REVIEWER"},{"updated":"2014-11-28 15:04:09.000000000","updated_by":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"reviewer":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"state":"REVIEWER"},{"updated":"2014-12-03 16:09:30.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2014-12-03 17:51:54.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2014-12-03 19:41:17.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2014-12-03 19:46:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"07a1c50e89888067dc773081d52b6e3358f477ab","author":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"date":"2014-10-29 04:31:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2293268fb7c08cd8b110465db7ab33f2c7916840","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2014-10-29 04:31:44.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. The more you\n    participate in the community the more rewarding it is for you. You may also\n    notice that the more you get to know people and get to be known, the faster\n    your patches will be reviewed and eventually approved. Get to know others\n    and become known by doing code reviews: anybody can do it, and it\u0027s a\n    great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: https://wiki.openstack.org/wiki/Gerrit_Workflow\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"03c5eb9da7d329399230b7039d3e05e21a11690b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-29 04:46:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/32/131632/1/check/gate-ironic-python-agent-pep8/ebfb6de : SUCCESS in 28s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/32/131632/1/check/gate-ironic-python-agent-python26/051cf07 : SUCCESS in 42s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/32/131632/1/check/gate-ironic-python-agent-python27/9ec6f00 : SUCCESS in 34s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/32/131632/1/check/gate-ironic-python-agent-buildimage-coreos/e81bb49 : SUCCESS in 2m 26s\n- check-tempest-dsvm-ironic-agent_ssh-src-nv http://logs.openstack.org/32/131632/1/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/31ad0e2 : FAILURE in 14m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"85e19e5aca63a2febaeed2972c4ac1541f4affef","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-11-11 17:15:00.000000000","message":"Patch Set 1: Code-Review-1\n\nA few problems:\n\n1) The commit message does not meet OpenStack requirements. Please see: https://wiki.openstack.org/wiki/GitCommitMessages for information on how to properly format these.\n\n2) This breaks backwards compatibility with all existing agents. We must continue to accept the old values if this is to change.","accounts_in_message":[],"_revision_number":1},{"id":"532c81fd2fadce691f468ec18a7bf8ab452d2a8d","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-11-11 17:15:36.000000000","message":"Patch Set 1:\n\nAdditionally, this doesn\u0027t change the values we look for in the kernel command line.","accounts_in_message":[],"_revision_number":1},{"id":"ba20fce1c137fd9becc2410363863029f0e87865","author":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"date":"2014-11-12 03:31:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cda67be1082987570b557312eab4d4cc80ccda16","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-12 03:48:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/32/131632/2/check/gate-ironic-python-agent-pep8/a68dbcf : SUCCESS in 29s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/32/131632/2/check/gate-ironic-python-agent-python26/eaad51b : SUCCESS in 44s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/32/131632/2/check/gate-ironic-python-agent-python27/4e68219 : SUCCESS in 38s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/32/131632/2/check/gate-ironic-python-agent-buildimage-coreos/5251f5c : SUCCESS in 3m 15s\n- check-tempest-dsvm-ironic-agent_ssh-src-nv http://logs.openstack.org/32/131632/2/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/a7e2889 : FAILURE in 16m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"55b45d1dc7e325b134b0cc9e6858446e2a4c508a","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-11-19 18:20:59.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3290420bcb4d2ab6cb7d0b4002e9151eacbdb19f","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-11-19 18:40:41.000000000","message":"Patch Set 2: Code-Review-1\n\nHonestly, I think I like the first patch better; the second is kind of hacky.\n\n/me tests the first one","accounts_in_message":[],"_revision_number":2},{"id":"87baed0d9c6323ea1c39c57eadc57dd1a88ba691","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-11-19 23:41:36.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nThe first patch doesn\u0027t work, the second does. There\u0027s still a bit of work to do, mentioned inline, but I mostly think this is fine. Thanks for this. :)","accounts_in_message":[],"_revision_number":2},{"id":"b117d62697e644f6c63e4dda844de69195385058","author":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"date":"2014-11-20 02:47:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"02f5d2f2e35776b8affa98fac48203a8140af839","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-11-20 03:25:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/32/131632/3/check/gate-ironic-python-agent-pep8/98b0234 : SUCCESS in 32s\n- gate-ironic-python-agent-python26 http://logs.openstack.org/32/131632/3/check/gate-ironic-python-agent-python26/a07aefd : SUCCESS in 36s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/32/131632/3/check/gate-ironic-python-agent-python27/97916d9 : SUCCESS in 1m 19s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/32/131632/3/check/gate-ironic-python-agent-buildimage-coreos/e4e540f : SUCCESS in 4m 48s\n- check-tempest-dsvm-ironic-agent_ssh-src-nv http://logs.openstack.org/32/131632/3/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/3f61a47 : FAILURE in 37m 41s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"3a1ab1f349e1b1fabf6ac5a8a8c00e28d5818f96","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2014-11-24 16:05:32.000000000","message":"Patch Set 3: Code-Review-1\n\njiangfei, thanks for the patch. Commit message should be wrapped at 70 characters.","accounts_in_message":[],"_revision_number":3},{"id":"ffc22cc9765f86620069795722691845e4876f0b","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-11-24 16:59:44.000000000","message":"Patch Set 3: Code-Review-1\n\nThis is going to break Ironic, as Ironic still passes e.g. ipa-api-url (this is why the tempest job is failing). Not sure what\u0027s best to do about this, going to mull it over and post again.","accounts_in_message":[],"_revision_number":3},{"id":"cbabb5b44c285624aea08533d31ee53b4bc2908e","author":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"date":"2014-11-25 03:29:31.000000000","message":"Patch Set 3:\n\n@Jim Rollenhagen: yes, we should add the other patach to ironic for agent-driver.","accounts_in_message":[],"_revision_number":3},{"id":"90fe0f23038f03a5d44d58fd656d287e4dc41e46","author":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"date":"2014-11-28 02:58:43.000000000","message":"Patch Set 3:\n\n@Jim Rollenhagen:publish the other patch, https://review.openstack.org/#/c/137550/  ,thks.","accounts_in_message":[],"_revision_number":3},{"id":"41bcc7e4a5d905fbd93bd1e5f7634170f60cdba9","author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"date":"2014-11-28 15:04:09.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nA question on usage of deprecated_name.","accounts_in_message":[],"_revision_number":3},{"id":"0559205fbe710540c0287f666f152741869458ef","author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"date":"2014-11-28 15:04:17.000000000","message":"Patch Set 3: Code-Review-1","accounts_in_message":[],"_revision_number":3},{"id":"5031c88dd914914e7294b2e063648424b376cb2f","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-11-28 15:25:51.000000000","message":"Patch Set 3:\n\nThanks for posting that.\n\nI think the better way to go is leave the kernel parameters as is, and only change the CONF options. If the kernel parameters are changed, then Ironic and the deploy ramdisk need to be upgraded at the same time; this is a backwards compatibility nightmare.\n\nThe other option, if we really want to change the kernel parameters, is to allow both options kernel parameters for a cycle or so.\n\nI\u0027d rather just leave the kernel parameters as is, personally.","accounts_in_message":[],"_revision_number":3},{"id":"45db88d71f515953076fac606d89563021906b2c","author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"date":"2014-11-28 15:59:59.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nI agree with Jim in that we need to accept both ipa-api-url and ipa_api_url for a while.","accounts_in_message":[],"_revision_number":3},{"id":"e85757032164648f4ef7898dd450f017686efad0","author":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"date":"2014-12-03 06:57:31.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"6e870535920590850b0b109ad8346c53cf16b7db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-03 07:30:56.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-python26 http://logs.openstack.org/32/131632/4/check/gate-ironic-python-agent-python26/3be9d6a : SUCCESS in 39s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/32/131632/4/check/gate-ironic-python-agent-pep8/2be5ae0 : SUCCESS in 36s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/32/131632/4/check/gate-ironic-python-agent-python27/cc040a0 : SUCCESS in 41s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/32/131632/4/check/gate-ironic-python-agent-buildimage-coreos/7aabd0f : SUCCESS in 3m 46s\n- check-tempest-dsvm-ironic-agent_ssh-src-nv http://logs.openstack.org/32/131632/4/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/a2e5e77 : SUCCESS in 33m 21s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"66a19bc8885d8ccf024805790acc1ba44f75c6a6","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-12-03 15:23:52.000000000","message":"Patch Set 4: Code-Review+2\n\nThis LGTM, I think the commit message could be better, but I\u0027ll just take care of that now.","accounts_in_message":[],"_revision_number":4},{"id":"f91d4d4a08a638df71d4439856935839eebe73da","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-12-03 16:09:17.000000000","message":"Patch Set 5: Commit message was updated","accounts_in_message":[],"_revision_number":5},{"id":"08eb5aa81e435e2584ac3d3b288772e9e585688d","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-12-03 16:09:30.000000000","message":"Patch Set 5: Code-Review+2\n\nUpdated commit message","accounts_in_message":[],"_revision_number":5},{"id":"5d0b94ce0769d536d5ed41c618747f1bdcf20298","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-03 16:59:10.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-python26 http://logs.openstack.org/32/131632/5/check/gate-ironic-python-agent-python26/e16c2b0 : SUCCESS in 41s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/32/131632/5/check/gate-ironic-python-agent-pep8/a75da82 : SUCCESS in 33s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/32/131632/5/check/gate-ironic-python-agent-python27/55cc430 : SUCCESS in 40s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/32/131632/5/check/gate-ironic-python-agent-buildimage-coreos/32072bc : SUCCESS in 4m 12s\n- check-tempest-dsvm-ironic-agent_ssh-src-nv http://logs.openstack.org/32/131632/5/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/f54f092 : SUCCESS in 38m 15s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"2e92f55b14e291bfd479345c80cf84773e6a615d","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-12-03 17:51:54.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"e03c341cebabffa76e9ae1d89fe972242394d618","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2014-12-03 19:41:17.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"9072cf385a1ac4f7d826b9ae06c2a6b83609d78e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-03 19:41:18.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"f205ebefcbc3e6465999a988ac26d0fafcb69800","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-03 19:46:12.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-python26 http://logs.openstack.org/32/131632/5/gate/gate-ironic-python-agent-python26/bd3325a : SUCCESS in 32s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/32/131632/5/gate/gate-ironic-python-agent-pep8/96c12c0 : SUCCESS in 35s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/32/131632/5/gate/gate-ironic-python-agent-python27/4de455c : SUCCESS in 51s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/32/131632/5/gate/gate-ironic-python-agent-buildimage-coreos/2dddfbc : SUCCESS in 4m 26s","accounts_in_message":[],"_revision_number":5},{"id":"9b8f010ce137677a8ac9c7f31d22ad890da6569d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-03 19:46:12.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"597d6245b159ecd46e27e60c5df6469db48b9700","revisions":{"c46a138e4cf45c76ddb68c6dd7e527c9dff76e5f":{"kind":"REWORK","_number":1,"created":"2014-10-29 04:31:33.000000000","uploader":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"ref":"refs/changes/32/131632/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/32/131632/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/1"}}},"commit":{"parents":[{"commit":"e53e297a5e920ca4621acfca6c4896a51ba4754d","subject":"Write image directly to disk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e53e297a5e920ca4621acfca6c4896a51ba4754d"}]}],"author":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-10-29 04:28:59.000000000","tz":480},"committer":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-10-29 04:28:59.000000000","tz":480},"subject":"modify for CONF Fixes: bug 1386486","message":"modify for CONF\nFixes: bug 1386486\n\nChange-Id: Ie10a548191effa2a505309d9d4ee32003f9676a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c46a138e4cf45c76ddb68c6dd7e527c9dff76e5f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c46a138e4cf45c76ddb68c6dd7e527c9dff76e5f"}]},"branch":"refs/heads/master"},"fa060cbd8bcf8010a5605f476b901c94e6a64414":{"kind":"REWORK","_number":2,"created":"2014-11-12 03:31:56.000000000","uploader":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"ref":"refs/changes/32/131632/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/32/131632/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/2"}}},"commit":{"parents":[{"commit":"e53e297a5e920ca4621acfca6c4896a51ba4754d","subject":"Write image directly to disk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e53e297a5e920ca4621acfca6c4896a51ba4754d"}]}],"author":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-10-29 04:28:59.000000000","tz":480},"committer":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-11-12 03:19:54.000000000","tz":480},"subject":"add deprecated_name to the config variables","message":"add deprecated_name to the config variables\n\nwe should modify our config variables with a _ (i.e. api_url), the current is use - (i.e. api-url).\napi-url is read frome /proc/cmdline ,and listen-host is read from ironic-python-agent.conf.\nwe use CONF.listen-host in the code, but we can\u0027t find it in the config, because the os.config replace \u0027-\u0027 with \u0027_\u0027, so we add deprecated_name to config variables\n\nCloses-Bug: #1386486\n\nChange-Id: Ie10a548191effa2a505309d9d4ee32003f9676a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fa060cbd8bcf8010a5605f476b901c94e6a64414"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fa060cbd8bcf8010a5605f476b901c94e6a64414"}]},"branch":"refs/heads/master"},"b816a48c9fc3c39689a1c93aa604a7dff308ab2f":{"kind":"REWORK","_number":3,"created":"2014-11-20 02:47:41.000000000","uploader":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"ref":"refs/changes/32/131632/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/32/131632/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/3"}}},"commit":{"parents":[{"commit":"e53e297a5e920ca4621acfca6c4896a51ba4754d","subject":"Write image directly to disk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e53e297a5e920ca4621acfca6c4896a51ba4754d"}]}],"author":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-10-29 04:28:59.000000000","tz":480},"committer":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-11-20 02:46:46.000000000","tz":480},"subject":"add deprecated_name to the config variables","message":"add deprecated_name to the config variables\n\nwe should modify our config variables with a _ (i.e. api_url), the current is use - (i.e. api-url).\napi-url is read frome /proc/cmdline ,and listen-host is read from ironic-python-agent.conf.\nwe use CONF.listen-host in the code, but we can\u0027t find it in the config, because the os.config replace \u0027-\u0027 with \u0027_\u0027, so we add deprecated_name to config variables\n\nCloses-Bug: #1386486\n\nChange-Id: Ie10a548191effa2a505309d9d4ee32003f9676a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b816a48c9fc3c39689a1c93aa604a7dff308ab2f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b816a48c9fc3c39689a1c93aa604a7dff308ab2f"}]},"branch":"refs/heads/master"},"976c2b248123a927d6fab9d7265a41af8af31be1":{"kind":"REWORK","_number":4,"created":"2014-12-03 06:57:31.000000000","uploader":{"_account_id":13762,"name":"jiangfei","email":"jiangfei0622@huawei.com","username":"jiangfei"},"ref":"refs/changes/32/131632/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/32/131632/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/4"}}},"commit":{"parents":[{"commit":"e53e297a5e920ca4621acfca6c4896a51ba4754d","subject":"Write image directly to disk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e53e297a5e920ca4621acfca6c4896a51ba4754d"}]}],"author":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-10-29 04:28:59.000000000","tz":480},"committer":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-12-03 06:56:58.000000000","tz":480},"subject":"add deprecated_name to the config variables","message":"add deprecated_name to the config variables\n\nwe should modify our config variables with a _ (i.e. api_url),\nthe current is use - (i.e. api-url).api-url is read from\n/proc/cmdline,listen-host is read from ironic-python-agent.conf.\nwe use CONF.listen-host in the code, but we can\u0027t find it in the\nconfig, because the os.config replace \u0027-\u0027 with \u0027_\u0027,so we add\ndeprecated_name to config variables\n\nCloses-Bug: #1386486\n\nChange-Id: Ie10a548191effa2a505309d9d4ee32003f9676a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/976c2b248123a927d6fab9d7265a41af8af31be1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/976c2b248123a927d6fab9d7265a41af8af31be1"}]},"branch":"refs/heads/master"},"597d6245b159ecd46e27e60c5df6469db48b9700":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2014-12-03 16:09:17.000000000","uploader":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"ref":"refs/changes/32/131632/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/32/131632/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/32/131632/5"}}},"commit":{"parents":[{"commit":"e53e297a5e920ca4621acfca6c4896a51ba4754d","subject":"Write image directly to disk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e53e297a5e920ca4621acfca6c4896a51ba4754d"}]}],"author":{"name":"jiangfei","email":"jiangfei0622@huawei.com","date":"2014-10-29 04:28:59.000000000","tz":480},"committer":{"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","date":"2014-12-03 16:09:17.000000000","tz":0},"subject":"Use _ instead of - for config options","message":"Use _ instead of - for config options\n\nConfig options containing \"-\" don\u0027t work when reading\nconfiguration from a file; change these to \"_\". Leave\nthe old options for backwards compatibility.\n\nCloses-Bug: #1386486\n\nChange-Id: Ie10a548191effa2a505309d9d4ee32003f9676a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/597d6245b159ecd46e27e60c5df6469db48b9700"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/597d6245b159ecd46e27e60c5df6469db48b9700"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}