)]}'
{"id":"openstack%2Fironic-python-agent~139269","triplet_id":"openstack%2Fironic-python-agent~master~I4cdf1defee7487785967a092c81c906d40bf3214","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1367917","hashtags":[],"change_id":"I4cdf1defee7487785967a092c81c906d40bf3214","subject":"Fix badly named function _get_kernel_params()","status":"MERGED","created":"2014-12-04 23:55:58.000000000","updated":"2014-12-05 01:15:54.000000000","submitted":"2014-12-05 01:15:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bc4bf4d7db6e0f20c28594dc95f0728fda47854e","_number":139269,"virtual_id_number":139269,"owner":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-12-05 01:15:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":2,"date":"2014-12-05 00:41:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2014-12-05 01:08:46.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":1,"date":"2014-12-05 01:10:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-12-04 23:56:07.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2014-12-05 01:08:46.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2014-12-05 01:10:14.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2014-12-05 01:15:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"071faf68183b4100660d5c5a8f79e2cd3ae710c0","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2014-12-04 23:55:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"02e687eff280039e47655d07154705850139fb52","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2014-12-04 23:56:07.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. The more you\n    participate in the community the more rewarding it is for you. You may also\n    notice that the more you get to know people and get to be known, the faster\n    your patches will be reviewed and eventually approved. Get to know others\n    and become known by doing code reviews: anybody can do it, and it\u0027s a\n    great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: https://wiki.openstack.org/wiki/Gerrit_Workflow\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"09e6821cebb42e40ec8c1abc2ed9973812fdf87a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-05 00:28:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-ironic-python-agent-python26 http://logs.openstack.org/69/139269/1/check/gate-ironic-python-agent-python26/bb24ee9 : FAILURE in 40s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/69/139269/1/check/gate-ironic-python-agent-pep8/e7f6c28 : SUCCESS in 30s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/69/139269/1/check/gate-ironic-python-agent-python27/62992c6 : FAILURE in 37s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/69/139269/1/check/gate-ironic-python-agent-buildimage-coreos/19af401 : SUCCESS in 3m 48s\n- check-tempest-dsvm-ironic-agent_ssh-src-nv http://logs.openstack.org/69/139269/1/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/803b692 : SUCCESS in 32m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dbd6f420868e5ad5b64a4ad63e9f2512a0c035d8","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2014-12-05 00:35:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"66b8d49d737541c1848d6fbc67204dd7a742c7fa","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-12-05 00:41:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"95db7aa5a0ca761b6faae29193e4a779a32eeac9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-05 01:03:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-python26 http://logs.openstack.org/69/139269/2/check/gate-ironic-python-agent-python26/1814fc4 : SUCCESS in 58s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/69/139269/2/check/gate-ironic-python-agent-pep8/3bcc4b3 : SUCCESS in 34s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/69/139269/2/check/gate-ironic-python-agent-python27/e7e00f7 : SUCCESS in 53s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/69/139269/2/check/gate-ironic-python-agent-buildimage-coreos/41a07f7 : SUCCESS in 3m 48s\n- check-tempest-dsvm-ironic-agent_ssh-src-nv http://logs.openstack.org/69/139269/2/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/72050aa : SUCCESS in 27m 54s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f08e62a79401465fd32a9341f703f3745d9be190","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2014-12-05 01:08:46.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nI\u0027m fine with this, but see inline comment, would rather that happened.","accounts_in_message":[],"_revision_number":2},{"id":"5595656cc88f7ab34162753b744d54be6e136fb9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-05 01:10:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"508be20b471731acb3a169bd2462394f5e3a04a0","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-12-05 01:10:14.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4265af0dd5d6f8de8d0bd96c8c825ed96846dc77","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2014-12-05 01:14:33.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f734a05d2dbb18459315e990b9011949ca9756aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-05 01:15:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-python26 http://logs.openstack.org/69/139269/2/gate/gate-ironic-python-agent-python26/b7a8d39 : SUCCESS in 35s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/69/139269/2/gate/gate-ironic-python-agent-pep8/0f04802 : SUCCESS in 30s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/69/139269/2/gate/gate-ironic-python-agent-python27/7f851b8 : SUCCESS in 40s\n- gate-ironic-python-agent-buildimage-coreos http://logs.openstack.org/69/139269/2/gate/gate-ironic-python-agent-buildimage-coreos/a181874 : SUCCESS in 4m 02s","accounts_in_message":[],"_revision_number":2},{"id":"368929c663600b72788c38e81e1ad883a5b08621","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-12-05 01:15:54.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7341511b98924ef62769e841bd558698af0efe64","revisions":{"b638992ba8df3ff479a6fb2b14db199a9a86f5cb":{"kind":"REWORK","_number":1,"created":"2014-12-04 23:55:58.000000000","uploader":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"ref":"refs/changes/69/139269/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/69/139269/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/1"}}},"commit":{"parents":[{"commit":"00812813a0ef873579ae796790a48dcd8a3f2203","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/00812813a0ef873579ae796790a48dcd8a3f2203"}]}],"author":{"name":"Clif Houck","email":"me@clifhouck.com","date":"2014-12-04 23:38:06.000000000","tz":0},"committer":{"name":"Clif Houck","email":"me@clifhouck.com","date":"2014-12-04 23:55:49.000000000","tz":0},"subject":"Fix badly named function _get_kernel_params()","message":"Fix badly named function _get_kernel_params()\n\nRenamed _get_kernel_params() to _get_agent_params() and\nappropriate module-level attribute KPARAMS to APARAMS.\n\nChange-Id: I4cdf1defee7487785967a092c81c906d40bf3214\nCloses-Bug: #1367917\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b638992ba8df3ff479a6fb2b14db199a9a86f5cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b638992ba8df3ff479a6fb2b14db199a9a86f5cb"}]},"branch":"refs/heads/master"},"7341511b98924ef62769e841bd558698af0efe64":{"kind":"REWORK","_number":2,"created":"2014-12-05 00:35:44.000000000","uploader":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"ref":"refs/changes/69/139269/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/69/139269/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/69/139269/2"}}},"commit":{"parents":[{"commit":"00812813a0ef873579ae796790a48dcd8a3f2203","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/00812813a0ef873579ae796790a48dcd8a3f2203"}]}],"author":{"name":"Clif Houck","email":"me@clifhouck.com","date":"2014-12-04 23:38:06.000000000","tz":0},"committer":{"name":"Clif Houck","email":"me@clifhouck.com","date":"2014-12-05 00:34:39.000000000","tz":0},"subject":"Fix badly named function _get_kernel_params()","message":"Fix badly named function _get_kernel_params()\n\nRenamed _get_kernel_params() to _get_agent_params() and\nappropriate module-level attribute KPARAMS to APARAMS.\n\nUpdated agent tests to match new function name.\n\nChange-Id: I4cdf1defee7487785967a092c81c906d40bf3214\nCloses-Bug: #1367917\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7341511b98924ef62769e841bd558698af0efe64"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7341511b98924ef62769e841bd558698af0efe64"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}