)]}'
{"id":"openstack%2Fironic-python-agent~146133","triplet_id":"openstack%2Fironic-python-agent~master~Iedc82b3446d1ee41d6ae94ee43391e12ef4899a7","project":"openstack/ironic-python-agent","branch":"master","topic":"jay/BetterHWManager","hashtags":[],"change_id":"Iedc82b3446d1ee41d6ae94ee43391e12ef4899a7","subject":"HardwareManagerMethodNotFound requires a method","status":"MERGED","created":"2015-01-09 16:49:23.000000000","updated":"2015-01-15 18:32:13.000000000","submitted":"2015-01-15 18:32:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c90277bed32b6d72d05d2fab1053be514c103c6f","_number":146133,"virtual_id_number":146133,"owner":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-01-15 18:32:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":2,"date":"2015-01-13 20:14:59.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2015-01-15 17:59:30.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":1,"date":"2015-01-15 17:59:30.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-09 16:52:07.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2015-01-13 20:14:59.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-01-15 17:59:30.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2015-01-15 18:32:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"286e1eabe7652ff76739f1c07f887938202bbdb5","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-01-09 16:49:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c36538207bd6ed9238d962949fbf3e937eff291d","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-01-09 16:52:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nA note on the comment there","accounts_in_message":[],"_revision_number":1},{"id":"3cbf6dce306d37f12cbab6a64ec78c2deae21464","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-01-09 16:54:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c9072e903eb542fc46d15d45f163d61179adc8ea","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-01-09 16:59:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0c804c7fa1112e9e3e256895bbf50eb6f961a678","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-09 17:53:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/33/146133/2/check/gate-ironic-python-agent-pep8/00291fc/ : SUCCESS in 1m 50s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/33/146133/2/check/gate-ironic-python-agent-python27/faf5618/ : SUCCESS in 58s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/33/146133/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/af4127d/ : SUCCESS in 37m 36s","accounts_in_message":[],"_revision_number":2},{"id":"c8c9d632e3c1aeb56decd5cfa570fc5690262f43","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-01-13 20:14:59.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Jay. There\u0027s another patch that has unit tests, so one will have to be rebased, depending on which lands first.","accounts_in_message":[],"_revision_number":2},{"id":"671d7e8675e871157318c73e1f585a574b10d6fe","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-01-15 17:59:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM!","accounts_in_message":[],"_revision_number":2},{"id":"cbe8c4a6d5397c75052e0d2324804d8ce4e3b39a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-15 17:59:40.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7fdcafa973db87abee9a12933d244211078f7eed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-15 18:32:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/33/146133/2/gate/gate-ironic-python-agent-pep8/a5ae5eb/ : SUCCESS in 33s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/33/146133/2/gate/gate-ironic-python-agent-python27/a4a7379/ : SUCCESS in 43s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/33/146133/2/gate/gate-tempest-dsvm-ironic-agent_ssh-src/6757239/ : SUCCESS in 32m 24s","accounts_in_message":[],"_revision_number":2},{"id":"b9dadf2a93908e03375e6eccd4e79a259a69b9fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-15 18:32:13.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"49d547d97eedda85ef422078f38f023472a73dd7","revisions":{"6b2a4629fe390059a307d3a0a4d9d9ed5467402f":{"kind":"REWORK","_number":1,"created":"2015-01-09 16:49:23.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/33/146133/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/33/146133/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/1"}}},"commit":{"parents":[{"commit":"2bbec5770c459b339b0924e8ffcd1382e22d44df","subject":"Allow use of multiple simultaneous HW managers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2bbec5770c459b339b0924e8ffcd1382e22d44df"}]}],"author":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2015-01-09 16:50:36.000000000","tz":-480},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2015-01-09 16:50:36.000000000","tz":-480},"subject":"HardwareManagerMethodNotFound requires a method","message":"HardwareManagerMethodNotFound requires a method\n\nIf this exception is called, it should contain a method argument. If\nnot, allow the incorrect call to bubble up rather than setting it to\nNone. This will ensure this error is never called without the method\nargument.\n\nChange-Id: Iedc82b3446d1ee41d6ae94ee43391e12ef4899a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6b2a4629fe390059a307d3a0a4d9d9ed5467402f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6b2a4629fe390059a307d3a0a4d9d9ed5467402f"}]},"branch":"refs/heads/master"},"49d547d97eedda85ef422078f38f023472a73dd7":{"kind":"REWORK","_number":2,"created":"2015-01-09 16:59:19.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/33/146133/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/33/146133/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/33/146133/2"}}},"commit":{"parents":[{"commit":"2bbec5770c459b339b0924e8ffcd1382e22d44df","subject":"Allow use of multiple simultaneous HW managers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2bbec5770c459b339b0924e8ffcd1382e22d44df"}]}],"author":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2015-01-09 16:50:36.000000000","tz":-480},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2015-01-09 17:02:37.000000000","tz":0},"subject":"HardwareManagerMethodNotFound requires a method","message":"HardwareManagerMethodNotFound requires a method\n\nIf this exception is called, it should contain a method argument. If\nnot, allow the incorrect call to bubble up rather than setting it to\nNone. This will ensure this error is never called without the method\nargument.\n\nChange-Id: Iedc82b3446d1ee41d6ae94ee43391e12ef4899a7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/49d547d97eedda85ef422078f38f023472a73dd7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/49d547d97eedda85ef422078f38f023472a73dd7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}