)]}'
{"id":"openstack%2Fironic-python-agent~152755","triplet_id":"openstack%2Fironic-python-agent~master~I23bae25a83881e7013c93d73f858c622ea941253","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1408080","hashtags":[],"change_id":"I23bae25a83881e7013c93d73f858c622ea941253","subject":"Add additional logging and return results for IPA extensions","status":"MERGED","created":"2015-02-04 01:04:55.000000000","updated":"2015-02-24 19:27:30.000000000","submitted":"2015-02-24 19:27:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":37,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"34c66ba3306a52c7704fd11cb040d6014f7ad616","_number":152755,"virtual_id_number":152755,"owner":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},{"value":2,"date":"2015-02-24 19:27:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"recommended":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"all":[{"value":0,"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-02-18 21:17:55.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2015-02-24 18:44:35.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2015-02-19 15:54:27.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2015-02-24 18:38:37.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2015-02-24 18:44:35.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-04 04:16:13.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-02-05 23:41:44.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2015-02-18 21:17:55.000000000","updated_by":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"reviewer":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"state":"REVIEWER"},{"updated":"2015-02-19 15:54:27.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-02-24 18:38:37.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2015-02-24 18:44:35.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2015-02-24 19:27:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f04a1ed8f5c376a1ea7ea656f5a23c43e5110b64","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 01:04:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00f5ef54dde9cfb3efd1e2773f7fcf1be23d49ab","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 01:06:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"97af479d92f12ee1e022c92ba9d6b825b2c38560","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 01:14:08.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2b828f1e37254d92bf1915fa212f57d4f32e85a0","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-02-04 01:16:20.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nWill give this a proper review later, one thing I noticed.","accounts_in_message":[],"_revision_number":3},{"id":"97818226b1366140883f361f71c1b8cebb5f2b1f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 01:44:24.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/3/check/gate-ironic-python-agent-pep8/b68e358/ : SUCCESS in 48s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/3/check/gate-ironic-python-agent-python27/155d605/ : SUCCESS in 42s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/3/check/gate-tempest-dsvm-ironic-agent_ssh-src/0ca3547/ : FAILURE in 29m 45s","accounts_in_message":[],"_revision_number":3},{"id":"2c0f6d6dc103fc3e3b6796bc6e7ea073eafa4631","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2015-02-04 03:52:53.000000000","message":"Patch Set 3: Code-Review-1\n\n(7 comments)\n\nMainly you can avoid the need for the _time function if you use the \u0027from time import time\u0027 directive.\n\nInstead of adding code to time each function separately, and also testing the timing behavior of each function separately, you would be better served by writing a decorator that adds timing to the decorated function, and just testing the decorator once.","accounts_in_message":[],"_revision_number":3},{"id":"5ededdf9b3906f43118c8b75936890459bb5d3bd","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-02-04 04:16:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"05aa97855650cd88d700cca6c8bc8a2c5c367987","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-02-04 07:31:09.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nOverall it\u0027s looking fine. I see a lot of overlap with https://review.openstack.org/#/c/119981/, though the spec for that isn\u0027t approved yet.","accounts_in_message":[],"_revision_number":3},{"id":"9ae0620e901cf4f381232d4e88fe1e27df77eb2c","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 12:56:41.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nThanks for the comments so far, everyone.\n\n@Josh there is some overlap as far as the metrics/timing goes, but I could see this being useful if a deployer does not, for some reason, setup a metrics reporting environment.","accounts_in_message":[],"_revision_number":3},{"id":"eca6a3a5832225ecb06be6bb50cb108e981b81b7","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 13:35:28.000000000","message":"Patch Set 3:\n\n!recheck","accounts_in_message":[],"_revision_number":3},{"id":"e5d808d3278b055eb925d2a5d470316e06c061ea","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 15:05:56.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"d3fa09301f8d612ccce98f8c4c4ee7ae5899a06a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 15:53:15.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/3/check/gate-ironic-python-agent-pep8/9c5a04d/ : SUCCESS in 54s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/3/check/gate-ironic-python-agent-python27/0a8ffcc/ : SUCCESS in 46s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/3/check/gate-tempest-dsvm-ironic-agent_ssh-src/3f998e6/ : FAILURE in 33m 56s","accounts_in_message":[],"_revision_number":3},{"id":"94eb5aa8f1f4f0a1f1099e2c650446e83cb77373","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2015-02-04 16:01:46.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e6a72e166478c4cbf5be3b59336ae4a1f8d58e81","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-02-04 17:45:10.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)\n\nI think that the timing stuff is ambitious but probably not needed; and that would simplify your testing and a bunch of other stuff.","accounts_in_message":[],"_revision_number":3},{"id":"f6c9adc4d096df5fa2127907514359329f018209","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 22:18:34.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e655dcee87975d1b8837c5eab1dc6eca57228254","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-04 22:20:19.000000000","message":"Patch Set 4:\n\nI removed the timing details from the tests and from the extensions code. the `time.time` method is used in the standby extension but it was there prior to this change set.","accounts_in_message":[],"_revision_number":4},{"id":"217ee626e6bba97b7feed93ba75f188d3db7f17a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 22:49:37.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/4/check/gate-ironic-python-agent-pep8/5096ec0/ : SUCCESS in 1m 13s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/4/check/gate-ironic-python-agent-python27/9974b77/ : SUCCESS in 49s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/4/check/gate-tempest-dsvm-ironic-agent_ssh-src/833042f/ : FAILURE in 31m 01s","accounts_in_message":[],"_revision_number":4},{"id":"fe44054a44dc2b435e6d47aae2560ff7922943b3","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-02-04 22:51:45.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"897fcb6dd3f8a27e837f49b8a3aa9c21cacbeddc","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-02-04 22:52:04.000000000","message":"Patch Set 4: -Code-Review\n\nThis isn\u0027t passing tempest for some reason... hrm","accounts_in_message":[],"_revision_number":4},{"id":"03228cde0bc4d4162faec02fba4957c0cb2d9c5f","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-05 02:18:17.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"25af41a0321912e95530ed72d63ef304f414e1d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-05 02:53:25.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/5/check/gate-ironic-python-agent-pep8/9066fb9/ : SUCCESS in 53s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/5/check/gate-ironic-python-agent-python27/df270e0/ : SUCCESS in 59s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/5/check/gate-tempest-dsvm-ironic-agent_ssh-src/a64bae3/ : SUCCESS in 31m 57s","accounts_in_message":[],"_revision_number":5},{"id":"84245a58a956beeb222c248c232ea9c04973a3d7","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-05 22:35:14.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"5c59510615b69638aa6af1515894e7d7d341db16","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-05 23:22:32.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/6/check/gate-ironic-python-agent-pep8/d6a63ff/ : SUCCESS in 45s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/6/check/gate-ironic-python-agent-python27/373d3ff/ : SUCCESS in 1m 10s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/6/check/gate-tempest-dsvm-ironic-agent_ssh-src/b8b8155/ : SUCCESS in 39m 05s","accounts_in_message":[],"_revision_number":6},{"id":"b5d1ff1f732c6543f1560adbb5f385073092948f","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-02-05 23:41:44.000000000","message":"Patch Set 6: Code-Review+2\n\nThanks Kyle","accounts_in_message":[],"_revision_number":6},{"id":"b44e4bcd9e48145d120a38585e3d089346f4771e","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-05 23:46:41.000000000","message":"Patch Set 6:\n\nThanks, Jay!","accounts_in_message":[],"_revision_number":6},{"id":"f7742a16b458df71218644ae870029d18fdd7dfd","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-02-06 17:17:55.000000000","message":"Patch Set 6:\n\nrecheck for science","accounts_in_message":[],"_revision_number":6},{"id":"b00bd4753893e92ec1aa585596a0c2110075ea52","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2015-02-06 17:20:47.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"2141ff6f6ac5fca03e3d36c7eba2464c5f004e12","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-06 18:14:52.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/6/check/gate-ironic-python-agent-pep8/7e3f6f4/ : SUCCESS in 48s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/6/check/gate-ironic-python-agent-python27/c174868/ : SUCCESS in 51s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/6/check/gate-tempest-dsvm-ironic-agent_ssh-src/bb65928/ : FAILURE in 39m 40s","accounts_in_message":[],"_revision_number":6},{"id":"88ebfa12d5568a9a979e56f8f026da058e453f0e","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-02-06 23:25:30.000000000","message":"Patch Set 6:\n\nrecheck bug 1418833","accounts_in_message":[],"_revision_number":6},{"id":"08bb84e9112519a8a5c1dfd07b61fcf3814090ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-07 00:04:52.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/6/check/gate-ironic-python-agent-pep8/d163d0d/ : SUCCESS in 1m 18s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/6/check/gate-ironic-python-agent-python27/a5d0751/ : SUCCESS in 52s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/6/check/gate-tempest-dsvm-ironic-agent_ssh-src/41ca1c7/ : SUCCESS in 39m 21s","accounts_in_message":[],"_revision_number":6},{"id":"3d60b80f89624cd859136113bec9d9bd1abf07fb","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-02-10 15:59:21.000000000","message":"Patch Set 6:\n\n(5 comments)\n\nHi Kyle, this looks good. It made me wonder...\n\nIt looks like the methods of interest all have decorators. If that\u0027s the case, maybe the docstrings for the decorators ought to be updated to indicate that the commands should return a value -- string with status or whatever.\n\nWhat happens if a command/extension doesn\u0027t return a value? (Eg, someone adds a new extension.) Looks like the code is OK with that. Is that the intent? Just wondering if you wanted to enforce the return of a value or not.","accounts_in_message":[],"_revision_number":6},{"id":"323fa3a2c0bcf8ef133308439dbb01f9ee71610a","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-02-10 17:16:14.000000000","message":"Patch Set 6:\n\nThe value returned in these cases are what Ironic ends up logging. I filed 1408080 originally because it seems absurd that our most used functions don\u0027t return anything at all useful in the logs.\n\nI don\u0027t think we should enforce a requirement to log overall though.","accounts_in_message":[],"_revision_number":6},{"id":"cc30aec203037cd3a43f2a62c079cd9269953750","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-10 23:40:03.000000000","message":"Patch Set 6:\n\n(5 comments)\n\nHi Ruby, thank you for taking the time to review my patch! As far as forcing a return value for all commands, I agree with Jay.\n\nIf a command/extension doesn\u0027t have a return value, nothing \"blows up\". These methods previously did not return any values and there has been no modification to the code base that forces a return value.\n\nI\u0027ll go ahead and submit another patch with the addition of the decorators approach you mentioned in standby.py.\n\nThanks again for the review!","accounts_in_message":[],"_revision_number":6},{"id":"58fa82943c4f0f02efd43d74bc2eae08d034215a","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-18 20:01:47.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"9e191099013af574d60182f63fa7df539a7f519d","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-18 20:09:57.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nImplemented changes discussed in patch #6, in patch #7.","accounts_in_message":[],"_revision_number":6},{"id":"27461e8f8d7705abaefd53ae00668b2c61a85228","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-18 20:49:55.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/7/check/gate-ironic-python-agent-pep8/35b3d38/ : SUCCESS in 39s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/7/check/gate-ironic-python-agent-python27/bd370f0/ : SUCCESS in 54s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/7/check/gate-tempest-dsvm-ironic-agent_ssh-src/0a650c8/ : SUCCESS in 42m 05s","accounts_in_message":[],"_revision_number":7},{"id":"c7364e33dac42a6697558e1385f68f9537cad5d7","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2015-02-18 20:52:55.000000000","message":"Patch Set 7: Code-Review+1\n\n(3 comments)\n\nCouple of nits, but otherwise LGTM.","accounts_in_message":[],"_revision_number":7},{"id":"8a47082eaa73b4ef391f921a9d61b8640a61b2b7","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-18 21:13:09.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"25930d6c0f5cb96b2f983fb8f2875cb3f3305bba","author":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"date":"2015-02-18 21:14:01.000000000","message":"Patch Set 7:\n\n(3 comments)\n\nThanks for the review, Clif! New patch uploaded to fix the nitpicks.","accounts_in_message":[],"_revision_number":7},{"id":"adade047f46cd01e347276ee4fe0190eb8a19eff","author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"date":"2015-02-18 21:17:55.000000000","message":"Patch Set 8: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":8},{"id":"cdacbc3e70f26cd9afe9fee7f5305ec22cbdd88e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-18 22:02:43.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/8/check/gate-ironic-python-agent-pep8/a90ce39/ : SUCCESS in 53s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/8/check/gate-ironic-python-agent-python27/3303c28/ : SUCCESS in 53s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/8/check/gate-tempest-dsvm-ironic-agent_ssh-src/c2d937e/ : SUCCESS in 36m 16s","accounts_in_message":[],"_revision_number":8},{"id":"9c8bbca21bc5be9adeb1c4f9cf36b0740dfa2205","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-02-19 15:54:27.000000000","message":"Patch Set 8: Code-Review+2\n\nThanks Kyle.","accounts_in_message":[],"_revision_number":8},{"id":"9b422db4b72345cd212cc4a4509f8333adeb5f1c","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-02-19 15:54:43.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"4e2926c4bcc7a9b65879cd43d482aa402c2c3374","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-02-24 18:38:37.000000000","message":"Patch Set 8: Code-Review+2\n\nThanks Kyle!","accounts_in_message":[],"_revision_number":8},{"id":"9b056bd84ca930bb02cb57d507644376f0d7524e","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-02-24 18:44:35.000000000","message":"Patch Set 8: Code-Review+2 Workflow+1\n\n(2 comments)\n\nSeems mostly fine, one thing inline; please post a followup patch for that. :)","accounts_in_message":[],"_revision_number":8},{"id":"e69185e016ed609047aaf0511ccb14a43ea73101","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-24 18:44:36.000000000","message":"Patch Set 8: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"52c2ec37a5a9f3db61f5d10e60bc0f3891a034fb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-24 19:27:29.000000000","message":"Patch Set 8: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/55/152755/8/gate/gate-ironic-python-agent-pep8/c199a69/ : SUCCESS in 54s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/55/152755/8/gate/gate-ironic-python-agent-python27/46e51d0/ : SUCCESS in 48s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/55/152755/8/gate/gate-tempest-dsvm-ironic-agent_ssh-src/56a997c/ : SUCCESS in 42m 27s","accounts_in_message":[],"_revision_number":8},{"id":"b8dfcb9b578440cf3a6d846468fdb93627ddb980","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-24 19:27:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"f1dec5c2e2972cf571af9845b201bbb22bbc8cea","revisions":{"30208605d58bea8a2404c1612121ea54beb8d225":{"kind":"REWORK","_number":1,"created":"2015-02-04 01:04:55.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/1"}}},"commit":{"parents":[{"commit":"69b118aa3fea16684c46123948e40b9ec30d5a18","subject":"Merge \"Make all IPA error classes inherit from RESTError\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/69b118aa3fea16684c46123948e40b9ec30d5a18"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-04 01:04:37.000000000","tz":-480},"subject":"Add log and return results to IPA extensions","message":"Add log and return results to IPA extensions\n\nSome of the extensions in IPA currently do not return any values from their respective command methods. This results in a lack of a paper trail of the command_result value to the point where it is not possible to know more information than a boolean result of if a command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return values which are used in the command_result property on commands to provide useful debugging information.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/30208605d58bea8a2404c1612121ea54beb8d225"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/30208605d58bea8a2404c1612121ea54beb8d225"}]},"branch":"refs/heads/master"},"e6329949e4b4d70f0a431e4c014aaf170eefd615":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-02-04 01:06:45.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/2"}}},"commit":{"parents":[{"commit":"69b118aa3fea16684c46123948e40b9ec30d5a18","subject":"Merge \"Make all IPA error classes inherit from RESTError\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/69b118aa3fea16684c46123948e40b9ec30d5a18"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-04 01:06:08.000000000","tz":-480},"subject":"Add additional logging and return results for IPA extensions","message":"Add additional logging and return results for IPA extensions\n\nSome of the extensions in IPA currently do not return any values from their respective command methods. This results in a lack of a paper trail of the command_result value to the point where it is not possible to know more information than a boolean result of if a command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return values which are used in the command_result property on commands to provide useful debugging information.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e6329949e4b4d70f0a431e4c014aaf170eefd615"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e6329949e4b4d70f0a431e4c014aaf170eefd615"}]},"branch":"refs/heads/master"},"9b511a021c994abc1bb36e0134113277e5f20cfb":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-02-04 01:14:08.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/3"}}},"commit":{"parents":[{"commit":"69b118aa3fea16684c46123948e40b9ec30d5a18","subject":"Merge \"Make all IPA error classes inherit from RESTError\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/69b118aa3fea16684c46123948e40b9ec30d5a18"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-04 01:12:47.000000000","tz":-480},"subject":"Add additional logging and return results for IPA extensions","message":"Add additional logging and return results for IPA extensions\n\nSome of the extensions in IPA currently do not return any values\nfrom their respective command methods. This results in a lack of a\npaper trail of the command_result value to the point where it is\nnot possible to know more information than a boolean result of if\na command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return\nvalues which are used in the command_result property on commands to\nprovide useful debugging information.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9b511a021c994abc1bb36e0134113277e5f20cfb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9b511a021c994abc1bb36e0134113277e5f20cfb"}]},"branch":"refs/heads/master"},"b69b3556244c6e0104bd69727a8594b8669f51f2":{"kind":"REWORK","_number":4,"created":"2015-02-04 22:18:34.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/4"}}},"commit":{"parents":[{"commit":"69b118aa3fea16684c46123948e40b9ec30d5a18","subject":"Merge \"Make all IPA error classes inherit from RESTError\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/69b118aa3fea16684c46123948e40b9ec30d5a18"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-04 22:18:31.000000000","tz":-480},"subject":"Add additional logging and return results for IPA extensions","message":"Add additional logging and return results for IPA extensions\n\nSome of the extensions in IPA currently do not return any values\nfrom their respective command methods. This results in a lack of a\npaper trail of the command_result value to the point where it is\nnot possible to know more information than a boolean result of if\na command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return\nvalues which are used in the command_result property on commands to\nprovide useful debugging information.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b69b3556244c6e0104bd69727a8594b8669f51f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b69b3556244c6e0104bd69727a8594b8669f51f2"}]},"branch":"refs/heads/master"},"6704ea0bdf97b8a4fd04a0e8ddfe9f9bed6d836e":{"kind":"REWORK","_number":5,"created":"2015-02-05 02:18:17.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/5"}}},"commit":{"parents":[{"commit":"69b118aa3fea16684c46123948e40b9ec30d5a18","subject":"Merge \"Make all IPA error classes inherit from RESTError\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/69b118aa3fea16684c46123948e40b9ec30d5a18"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-05 02:18:09.000000000","tz":-480},"subject":"Add additional logging and return results for IPA extensions","message":"Add additional logging and return results for IPA extensions\n\nSome of the extensions in IPA currently do not return any values\nfrom their respective command methods. This results in a lack of a\npaper trail of the command_result value to the point where it is\nnot possible to know more information than a boolean result of if\na command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return\nvalues which are used in the command_result property on commands to\nprovide useful debugging information.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6704ea0bdf97b8a4fd04a0e8ddfe9f9bed6d836e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6704ea0bdf97b8a4fd04a0e8ddfe9f9bed6d836e"}]},"branch":"refs/heads/master"},"7f32915e5031beea1c95b38cbf4c660c961474c7":{"kind":"REWORK","_number":6,"created":"2015-02-05 22:35:14.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/6"}}},"commit":{"parents":[{"commit":"69b118aa3fea16684c46123948e40b9ec30d5a18","subject":"Merge \"Make all IPA error classes inherit from RESTError\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/69b118aa3fea16684c46123948e40b9ec30d5a18"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-05 22:34:33.000000000","tz":-480},"subject":"Add additional logging and return results for IPA extensions","message":"Add additional logging and return results for IPA extensions\n\nSome of the extensions in IPA currently do not return any values\nfrom their respective command methods. This results in a lack of a\npaper trail of the command_result value to the point where it is\nnot possible to know more information than a boolean result of if\na command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return\nvalues which are used in the command_result property on\n(Async|Sync)CommandResult instances to provide useful debug info.\n\nWhile creating this patch several unit tests for *CommandResult objects\nwere found to be using invalid data that would not pass validation\nif returned in API results. Those have been corrected in this patch.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7f32915e5031beea1c95b38cbf4c660c961474c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7f32915e5031beea1c95b38cbf4c660c961474c7"}]},"branch":"refs/heads/master"},"4b457bf4bd9f4a9c34bc0dd6642cab22a49d2cf5":{"kind":"REWORK","_number":7,"created":"2015-02-18 20:01:47.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/7"}}},"commit":{"parents":[{"commit":"ee93744b9a22df2f500b77567587177f12fbbf9c","subject":"Merge \"Log required troubleshooting info on image dl fail\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ee93744b9a22df2f500b77567587177f12fbbf9c"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-18 20:00:59.000000000","tz":-480},"subject":"Add additional logging and return results for IPA extensions","message":"Add additional logging and return results for IPA extensions\n\nSome of the extensions in IPA currently do not return any values\nfrom their respective command methods. This results in a lack of a\npaper trail of the command_result value to the point where it is\nnot possible to know more information than a boolean result of if\na command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return\nvalues which are used in the command_result property on\n(Async|Sync)CommandResult instances to provide useful debug info.\n\nWhile creating this patch several unit tests for *CommandResult objects\nwere found to be using invalid data that would not pass validation\nif returned in API results. Those have been corrected in this patch.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4b457bf4bd9f4a9c34bc0dd6642cab22a49d2cf5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4b457bf4bd9f4a9c34bc0dd6642cab22a49d2cf5"}]},"branch":"refs/heads/master"},"f1dec5c2e2972cf571af9845b201bbb22bbc8cea":{"kind":"REWORK","_number":8,"created":"2015-02-18 21:13:09.000000000","uploader":{"_account_id":9856,"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","username":"kylestev"},"ref":"refs/changes/55/152755/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/55/152755/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/55/152755/8"}}},"commit":{"parents":[{"commit":"ee93744b9a22df2f500b77567587177f12fbbf9c","subject":"Merge \"Log required troubleshooting info on image dl fail\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ee93744b9a22df2f500b77567587177f12fbbf9c"}]}],"author":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-01-27 21:56:05.000000000","tz":-480},"committer":{"name":"Kyle Stevenson","email":"kyle@kylestevenson.me","date":"2015-02-18 21:12:44.000000000","tz":-480},"subject":"Add additional logging and return results for IPA extensions","message":"Add additional logging and return results for IPA extensions\n\nSome of the extensions in IPA currently do not return any values\nfrom their respective command methods. This results in a lack of a\npaper trail of the command_result value to the point where it is\nnot possible to know more information than a boolean result of if\na command succeeded or failed.\n\nThis change adds more logging to the extensions and provides return\nvalues which are used in the command_result property on\n(Async|Sync)CommandResult instances to provide useful debug info.\n\nWhile creating this patch several unit tests for *CommandResult objects\nwere found to be using invalid data that would not pass validation\nif returned in API results. Those have been corrected in this patch.\n\nChange-Id: I23bae25a83881e7013c93d73f858c622ea941253\nCloses-Bug: 1408080\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f1dec5c2e2972cf571af9845b201bbb22bbc8cea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f1dec5c2e2972cf571af9845b201bbb22bbc8cea"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}