)]}'
{"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d862d17be1965caf655c57c3a931b767e9ab8445","unresolved":false,"context_lines":[{"line_number":119,"context_line":"def _request_url(image_info, url):"},{"line_number":120,"context_line":"    resp \u003d requests.get(url, stream\u003dTrue)"},{"line_number":121,"context_line":"    if resp.status_code !\u003d 200:"},{"line_number":122,"context_line":"        msg \u003d \u0027Received status code {0} from {1}, expected 202\u0027.format("},{"line_number":123,"context_line":"                image_info[\u0027id\u0027], url)"},{"line_number":124,"context_line":"        raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":125,"context_line":"    return resp"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8f506233","line":122,"updated":"2015-02-11 22:31:20.000000000","message":"aren\u0027t you expecting 200?","commit_id":"5e627c97dbc948905a13182076431666ac14da52"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fa40d43b82811c5fa1de66c8bc825f2be5e17b35","unresolved":false,"context_lines":[{"line_number":119,"context_line":"def _request_url(image_info, url):"},{"line_number":120,"context_line":"    resp \u003d requests.get(url, stream\u003dTrue)"},{"line_number":121,"context_line":"    if resp.status_code !\u003d 200:"},{"line_number":122,"context_line":"        msg \u003d \u0027Received status code {0} from {1}, expected 202\u0027.format("},{"line_number":123,"context_line":"                image_info[\u0027id\u0027], url)"},{"line_number":124,"context_line":"        raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":125,"context_line":"    return resp"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c2b231e4","line":122,"in_reply_to":"da86d52c_8f506233","updated":"2015-02-11 22:50:28.000000000","message":"You\u0027re right, nice catch. Will fix.","commit_id":"5e627c97dbc948905a13182076431666ac14da52"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d862d17be1965caf655c57c3a931b767e9ab8445","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            break"},{"line_number":142,"context_line":"    if resp is None:"},{"line_number":143,"context_line":"        msg \u003d \"empty response recieved\""},{"line_number":144,"context_line":"        raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    image_location \u003d _image_location(image_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_4f52ea35","line":143,"updated":"2015-02-11 22:31:20.000000000","message":"s/recieved/received/","commit_id":"5e627c97dbc948905a13182076431666ac14da52"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fa40d43b82811c5fa1de66c8bc825f2be5e17b35","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            break"},{"line_number":142,"context_line":"    if resp is None:"},{"line_number":143,"context_line":"        msg \u003d \"empty response recieved\""},{"line_number":144,"context_line":"        raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    image_location \u003d _image_location(image_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_02c8c953","line":143,"in_reply_to":"da86d52c_4f52ea35","updated":"2015-02-11 22:50:28.000000000","message":"Gah, thought I got them all. Will fix.","commit_id":"5e627c97dbc948905a13182076431666ac14da52"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"32d5249479a3c610bacfdfce69adbdfcab14babf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    resp \u003d requests.get(url, stream\u003dTrue)"},{"line_number":121,"context_line":"    if resp.status_code !\u003d 200:"},{"line_number":122,"context_line":"        msg \u003d \u0027Received status code {0} from {1}, expected 200\u0027.format("},{"line_number":123,"context_line":"                image_info[\u0027id\u0027], url)"},{"line_number":124,"context_line":"        raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":125,"context_line":"    return resp"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_22030d11","line":123,"updated":"2015-02-11 23:03:15.000000000","message":"Should this be \u0027resp.status_code\u0027?","commit_id":"5bb965bb2c410420d55973a4ea56b04923a788d3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9a02349f21dd25c8aab5f8b728aa91ae6cd28cff","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    resp \u003d requests.get(url, stream\u003dTrue)"},{"line_number":121,"context_line":"    if resp.status_code !\u003d 200:"},{"line_number":122,"context_line":"        msg \u003d \u0027Received status code {0} from {1}, expected 200\u0027.format("},{"line_number":123,"context_line":"                image_info[\u0027id\u0027], url)"},{"line_number":124,"context_line":"        raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":125,"context_line":"    return resp"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_23fa1875","line":123,"in_reply_to":"da86d52c_05945389","updated":"2015-02-12 13:42:42.000000000","message":"I think the response body may be useful here as well.","commit_id":"5bb965bb2c410420d55973a4ea56b04923a788d3"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1a84a8c4e4d764b3d6e75cc451436254a6ef0535","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    resp \u003d requests.get(url, stream\u003dTrue)"},{"line_number":121,"context_line":"    if resp.status_code !\u003d 200:"},{"line_number":122,"context_line":"        msg \u003d \u0027Received status code {0} from {1}, expected 200\u0027.format("},{"line_number":123,"context_line":"                image_info[\u0027id\u0027], url)"},{"line_number":124,"context_line":"        raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":125,"context_line":"    return resp"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_05945389","line":123,"in_reply_to":"da86d52c_22030d11","updated":"2015-02-11 23:08:40.000000000","message":"As a thought, could use:\n\n error_message \u003d httplib.responses[resp.status_code]\n\nAnd maybe add the error_message to the \u0027msg\u0027","commit_id":"5bb965bb2c410420d55973a4ea56b04923a788d3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9a02349f21dd25c8aab5f8b728aa91ae6cd28cff","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            for chunk in resp.iter_content(IMAGE_CHUNK_SIZE):"},{"line_number":150,"context_line":"                f.write(chunk)"},{"line_number":151,"context_line":"        except Exception:"},{"line_number":152,"context_line":"            msg \u003d \u0027Unable to write image to {0}\u0027.format(image_location)"},{"line_number":153,"context_line":"            raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    totaltime \u003d time.time() - starttime"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_83702409","line":152,"updated":"2015-02-12 13:42:42.000000000","message":"This could also be a failure to get all the content or something, as this streams the response to disk.","commit_id":"5bb965bb2c410420d55973a4ea56b04923a788d3"}],"ironic_python_agent/tests/errors.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"32d5249479a3c610bacfdfce69adbdfcab14babf","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                 (errors.LookupAgentIPError(DETAILS), SAME_DETAILS),"},{"line_number":95,"context_line":"                 (errors.LookupAgentInterfaceError(DETAILS), SAME_DETAILS),"},{"line_number":96,"context_line":"                 (errors.ImageDownloadError(\u0027image_id\u0027, DETAILS),"},{"line_number":97,"context_line":"                     DIFF_CL_DETAILS),"},{"line_number":98,"context_line":"                 (errors.ImageChecksumError(\u0027image_id\u0027), DIFF_CL_DETAILS),"},{"line_number":99,"context_line":"                 (errors.ImageWriteError(\u0027device\u0027, \u0027exit_code\u0027, \u0027stdout\u0027,"},{"line_number":100,"context_line":"                                         \u0027stderr\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c25cf17f","line":97,"updated":"2015-02-11 23:03:15.000000000","message":"nit: indentation","commit_id":"5bb965bb2c410420d55973a4ea56b04923a788d3"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c27de907e29c8f40d963e27702fa77c08d4c76ce","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                 (errors.LookupAgentIPError(DETAILS), SAME_DETAILS),"},{"line_number":95,"context_line":"                 (errors.LookupAgentInterfaceError(DETAILS), SAME_DETAILS),"},{"line_number":96,"context_line":"                 (errors.ImageDownloadError(\u0027image_id\u0027, DETAILS),"},{"line_number":97,"context_line":"                     DIFF_CL_DETAILS),"},{"line_number":98,"context_line":"                 (errors.ImageChecksumError(\u0027image_id\u0027), DIFF_CL_DETAILS),"},{"line_number":99,"context_line":"                 (errors.ImageWriteError(\u0027device\u0027, \u0027exit_code\u0027, \u0027stdout\u0027,"},{"line_number":100,"context_line":"                                         \u0027stderr\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_2243e913","line":97,"updated":"2015-02-12 16:16:28.000000000","message":"indentation","commit_id":"e5d88be8cb98298323b4644dff08b38fc970f1cd"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"01e77744685c08c82bc959c59c4fad127e540d65","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                 (errors.LookupAgentIPError(DETAILS), SAME_DETAILS),"},{"line_number":95,"context_line":"                 (errors.LookupAgentInterfaceError(DETAILS), SAME_DETAILS),"},{"line_number":96,"context_line":"                 (errors.ImageDownloadError(\u0027image_id\u0027, DETAILS),"},{"line_number":97,"context_line":"                     DIFF_CL_DETAILS),"},{"line_number":98,"context_line":"                 (errors.ImageChecksumError(\u0027image_id\u0027), DIFF_CL_DETAILS),"},{"line_number":99,"context_line":"                 (errors.ImageWriteError(\u0027device\u0027, \u0027exit_code\u0027, \u0027stdout\u0027,"},{"line_number":100,"context_line":"                                         \u0027stderr\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_ac2b4780","line":97,"in_reply_to":"da86d52c_2243e913","updated":"2015-02-12 18:11:32.000000000","message":"TBH if it passes pep8, it should be fine. We can\u0027t rely on human eyes for enforcing style.","commit_id":"e5d88be8cb98298323b4644dff08b38fc970f1cd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"eaac033d8ae985a14e7f1dcda5398364af6194c1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                 (errors.LookupAgentIPError(DETAILS), SAME_DETAILS),"},{"line_number":95,"context_line":"                 (errors.LookupAgentInterfaceError(DETAILS), SAME_DETAILS),"},{"line_number":96,"context_line":"                 (errors.ImageDownloadError(\u0027image_id\u0027, DETAILS),"},{"line_number":97,"context_line":"                     DIFF_CL_DETAILS),"},{"line_number":98,"context_line":"                 (errors.ImageChecksumError(\u0027image_id\u0027), DIFF_CL_DETAILS),"},{"line_number":99,"context_line":"                 (errors.ImageWriteError(\u0027device\u0027, \u0027exit_code\u0027, \u0027stdout\u0027,"},{"line_number":100,"context_line":"                                         \u0027stderr\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_9fb77984","line":97,"in_reply_to":"da86d52c_ac2b4780","updated":"2015-02-13 01:19:40.000000000","message":"My mistake :(","commit_id":"e5d88be8cb98298323b4644dff08b38fc970f1cd"}]}