)]}'
{"ironic_python_agent/netutils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e35797d62a2b80b55c24800060553f5d6e5b445b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# FIXME(lucasagomes): If you don\u0027t import the agent module the tests in"},{"line_number":26,"context_line":"# this file will fail, it was working before because the agent module was"},{"line_number":27,"context_line":"# being at tests/agent.py"},{"line_number":28,"context_line":"from ironic_python_agent.cmd import agent  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_661f8b5c","line":27,"updated":"2015-03-10 16:46:19.000000000","message":"being imported at*","commit_id":"5959bd0ef01d739a3d56c187b484d99b314bb729"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"018e2620f9a6f4de1e4f2d85f7b473feadd1b644","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# FIXME(lucasagomes): If you don\u0027t import the agent module the tests in"},{"line_number":26,"context_line":"# this file will fail, it was working before because the agent module was"},{"line_number":27,"context_line":"# being imported at tests/agent.py"},{"line_number":28,"context_line":"from ironic_python_agent.cmd import agent  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_cd004b38","line":28,"updated":"2015-03-10 20:39:23.000000000","message":"This seems odd but I\u0027m not familiar with the code.\n\nWhy not put this in tests/netutils.py? Is it needed to run this code, or needed to run the tests?","commit_id":"c6cd3a8190332b4b778e6ac63b2985eee72135e9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cfe410ffa9e7767135e64c1099ce51094a1e8285","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# FIXME(lucasagomes): If you don\u0027t import the agent module the tests in"},{"line_number":26,"context_line":"# this file will fail, it was working before because the agent module was"},{"line_number":27,"context_line":"# being imported at tests/agent.py"},{"line_number":28,"context_line":"from ironic_python_agent.cmd import agent  # noqa"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0d57c327","line":28,"in_reply_to":"9a80dd14_cd004b38","updated":"2015-03-10 20:43:33.000000000","message":"Hi Ruby,\n\nTo run the tests, it may be because the cmd.agent does setup the logs and config options. So there\u0027s a race somewhere.\n\nSince the problem already existed (it was working by accident) and the problem is not related to what the patch is proposing I just added this FIXME here in the code and I will look at it later.","commit_id":"c6cd3a8190332b4b778e6ac63b2985eee72135e9"}]}