)]}'
{"id":"openstack%2Fironic-python-agent~164805","triplet_id":"openstack%2Fironic-python-agent~master~I4724bd15ee923a9272aa872641430f3dfbef3fec","project":"openstack/ironic-python-agent","branch":"master","topic":"(detached","hashtags":[],"change_id":"I4724bd15ee923a9272aa872641430f3dfbef3fec","subject":"Fix nit in test_get_agent_params_from_cache","status":"MERGED","created":"2015-03-16 18:00:51.000000000","updated":"2015-03-17 02:13:02.000000000","submitted":"2015-03-17 02:13:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"96fca12795c916333fbf0fa04055db0695db1310","_number":164805,"virtual_id_number":164805,"owner":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":2,"date":"2015-03-17 02:13:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"all":[{"value":2,"date":"2015-03-16 18:46:03.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":2,"date":"2015-03-17 01:30:14.000000000","_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"all":[{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":1,"date":"2015-03-17 01:30:14.000000000","_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-16 18:46:03.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2015-03-17 01:30:14.000000000","updated_by":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"reviewer":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"state":"REVIEWER"},{"updated":"2015-03-17 02:13:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5734e54f05a69a4380e02087ea0b1bb04ac1dc78","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2015-03-16 18:00:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f9239aa876f2c184a2636f246f7a18e6f9af6d4c","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-03-16 18:46:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d522fe4d63d85503e11eef01ca765661bb4c632f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-16 19:28:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/05/164805/1/check/gate-ironic-python-agent-pep8/0b95c39/ : SUCCESS in 40s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/05/164805/1/check/gate-ironic-python-agent-python27/f4fd162/ : SUCCESS in 46s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/05/164805/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/a9868cb/ : SUCCESS in 41m 01s","accounts_in_message":[],"_revision_number":1},{"id":"0fce1c025fbb8295dd14c89f812a95876013d7a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-17 01:30:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5cec6fab7c00b9d01e4fbd5326c2cdb134d88e2c","author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"date":"2015-03-17 01:30:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"8ed072616a4774916673aa9239e4c97f542bea02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-17 02:13:02.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"75ff47125291a846510bdf4630f5620bb6137c5d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-17 02:13:02.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/05/164805/1/gate/gate-ironic-python-agent-pep8/0d9d61a/ : SUCCESS in 55s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/05/164805/1/gate/gate-ironic-python-agent-python27/9ce504f/ : SUCCESS in 56s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/05/164805/1/gate/gate-tempest-dsvm-ironic-agent_ssh-src/c9d01d8/ : SUCCESS in 42m 45s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4f2ad2104ef5e972ac4c36c296cfed776504eab3","revisions":{"4f2ad2104ef5e972ac4c36c296cfed776504eab3":{"kind":"REWORK","_number":1,"created":"2015-03-16 18:00:51.000000000","uploader":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"ref":"refs/changes/05/164805/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/05/164805/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/05/164805/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/05/164805/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/05/164805/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/05/164805/1"}}},"commit":{"parents":[{"commit":"c7b3c73d65de0616302a32a988b20c71018e5b6b","subject":"Cache agent parameters for later invocations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c7b3c73d65de0616302a32a988b20c71018e5b6b"}]}],"author":{"name":"Devananda van der Veen","email":"devananda.vdv@gmail.com","date":"2015-03-16 17:59:40.000000000","tz":-420},"committer":{"name":"Devananda van der Veen","email":"devananda.vdv@gmail.com","date":"2015-03-16 18:00:24.000000000","tz":-420},"subject":"Fix nit in test_get_agent_params_from_cache","message":"Fix nit in test_get_agent_params_from_cache\n\nAddress a nit in previous review: test_get_agent_params_from_cache\nshould assert that _set_cached_params is never called.\n\nChange-Id: I4724bd15ee923a9272aa872641430f3dfbef3fec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4f2ad2104ef5e972ac4c36c296cfed776504eab3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4f2ad2104ef5e972ac4c36c296cfed776504eab3"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c7b3c73d65de0616302a32a988b20c71018e5b6b","is_merged_in_target_branch":true,"change_id":"Ia8c7020c91c987ec884c5640421f0583dbf1c3d9","change_number":164596,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
