)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"b2432187fa9d9438f4959168b30c8697d7d4e17a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":74,"context_line":"        LOG.warning(\"Couldn\u0027t re-read the partition table \""},{"line_number":75,"context_line":"                    \"on device %s\" % device)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    for attempt in range(1, 4):"},{"line_number":78,"context_line":"        part_device \u003d _find_partition_from_lsblk(device, uuid)"},{"line_number":79,"context_line":"        if part_device:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_12fb3248","line":76,"updated":"2015-03-17 18:55:36.000000000","message":"may also help to issue a udevsettle here. ( http://linux.die.net/man/8/udevsettle ) which would all uuids to sync up maybe preventing the need to loop below? Just a thought.","commit_id":"d1154dd1995f00a5c87ec3d967c6fc8e4de445e9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f981a378da52ea85d319810c673971fc749e08cd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":74,"context_line":"        LOG.warning(\"Couldn\u0027t re-read the partition table \""},{"line_number":75,"context_line":"                    \"on device %s\" % device)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    for attempt in range(1, 4):"},{"line_number":78,"context_line":"        part_device \u003d _find_partition_from_lsblk(device, uuid)"},{"line_number":79,"context_line":"        if part_device:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_26124fb4","line":76,"in_reply_to":"9a80dd14_12fb3248","updated":"2015-03-19 17:25:47.000000000","message":"I prefer this approach if it works","commit_id":"d1154dd1995f00a5c87ec3d967c6fc8e4de445e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"f7276e273362ed3eba3ccfcb75ca1d20a91ef46b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        LOG.warning(\"Couldn\u0027t re-read the partition table \""},{"line_number":75,"context_line":"                    \"on device %s\" % device)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    for attempt in range(1, 4):"},{"line_number":78,"context_line":"        part_device \u003d _find_partition_from_lsblk(device, uuid)"},{"line_number":79,"context_line":"        if part_device:"},{"line_number":80,"context_line":"            LOG.debug(\"Partition %(uuid)s found on device \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_095af229","line":77,"updated":"2015-03-18 18:36:42.000000000","message":"Why not use the \u0027attempts\u0027 parameter to utils.execute(\u0027lsblk\u0027), like what is done for the \u0027partx\u0027 command above, instead of reinventing the wheel here?","commit_id":"d1154dd1995f00a5c87ec3d967c6fc8e4de445e9"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f5a62e60620da8b772c1308270cb608cc3f187bd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        LOG.warning(\"Couldn\u0027t re-read the partition table \""},{"line_number":75,"context_line":"                    \"on device %s\" % device)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    for attempt in range(1, 4):"},{"line_number":78,"context_line":"        part_device \u003d _find_partition_from_lsblk(device, uuid)"},{"line_number":79,"context_line":"        if part_device:"},{"line_number":80,"context_line":"            LOG.debug(\"Partition %(uuid)s found on device \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_58549753","line":77,"in_reply_to":"9a80dd14_095af229","updated":"2015-03-19 09:26:59.000000000","message":"lsblk doesn\u0027t return with non-zero return code here. It exits with 0, but doesn\u0027t have the UUID.   attempts can be given only when process exits with non-zero return code first time.\n\nhttp://paste.openstack.org/show/192820/\n\nSee lines 11-13 when it fails \nAnd lines 21,22 when it goes through (on attempting again).","commit_id":"d1154dd1995f00a5c87ec3d967c6fc8e4de445e9"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"4a23fbfaeb50bdba257d7de04047f7e8d4c7f5dc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        LOG.warning(\"Couldn\u0027t re-read the partition table \""},{"line_number":75,"context_line":"                    \"on device %s\" % device)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    for attempt in range(1, 4):"},{"line_number":78,"context_line":"        part_device \u003d _find_partition_from_lsblk(device, uuid)"},{"line_number":79,"context_line":"        if part_device:"},{"line_number":80,"context_line":"            LOG.debug(\"Partition %(uuid)s found on device \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_86d21bcf","line":77,"in_reply_to":"9a80dd14_58549753","updated":"2015-03-19 16:57:38.000000000","message":"Thanks for explaining!","commit_id":"d1154dd1995f00a5c87ec3d967c6fc8e4de445e9"}]}