)]}'
{"id":"openstack%2Fironic-python-agent~199088","triplet_id":"openstack%2Fironic-python-agent~master~Ifef196ec774371474c15a2aede5c2d2509397d64","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"Ifef196ec774371474c15a2aede5c2d2509397d64","subject":"Disable local disks shredding if agent_erase_devices_iterations is 0","status":"NEW","created":"2015-07-07 13:09:42.000000000","updated":"2017-12-18 03:53:30.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"72050ec003967d7d193ab70b2c355f41f6be8ec9","_number":199088,"virtual_id_number":199088,"owner":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"date":"2016-04-11 11:40:21.000000000","_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"disliked":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":-1,"date":"2017-01-25 13:05:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},{"value":-1,"date":"2015-08-20 07:24:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":1,"date":"2015-07-07 13:21:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":-1,"date":"2015-07-24 02:08:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":1,"date":"2015-07-09 16:30:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":-1,"date":"2015-07-23 23:46:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":-1,"date":"2017-03-24 20:43:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"value":2,"date":"2015-07-23 11:35:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2017-03-27 11:08:30.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-07 13:21:30.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2015-07-09 16:30:59.000000000","updated_by":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"reviewer":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"state":"REVIEWER"},{"updated":"2015-07-23 11:35:04.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2015-07-23 23:46:54.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2015-07-24 02:08:46.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-08-20 07:24:20.000000000","updated_by":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"reviewer":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"state":"REVIEWER"},{"updated":"2017-01-25 13:05:02.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2017-03-24 20:43:59.000000000","updated_by":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"reviewer":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"state":"REVIEWER"},{"updated":"2017-03-27 11:08:30.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"}],"messages":[{"id":"d54e9825eee66c8eceb034e4c711bfac8101db05","author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"date":"2015-07-07 13:09:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dec7595fe1076d527a02007c15082f4aeb77bf00","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2015-07-07 13:21:30.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good, although I think there should likely be additional documentation around that so users know how it can be used.","accounts_in_message":[],"_revision_number":1},{"id":"d218b724b519d9f43749e817e5adebf126b5e693","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-07 14:03:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/88/199088/1/check/gate-ironic-python-agent-pep8/0aa8efa/ : SUCCESS in 52s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/88/199088/1/check/gate-ironic-python-agent-docs/68e7921//doc/build/html/ : SUCCESS in 1m 21s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/88/199088/1/check/gate-ironic-python-agent-python27/5dbb0f8/ : SUCCESS in 1m 09s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/88/199088/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/80716fd/ : SUCCESS in 46m 06s\n- check-tempest-dsvm-ironic-pxe_ipa-src-nv http://logs.openstack.org/88/199088/1/check/check-tempest-dsvm-ironic-pxe_ipa-src-nv/80f6b1d/ : SUCCESS in 51m 14s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6b8f9457e99e8749c07cf107a87c9b5d02de6eda","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2015-07-09 16:30:59.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c25f399db476516bc114f0fe009482dc8f921e28","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-07-23 11:35:04.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e6d11eb2cad60fffd205e71dc25e71986c0499ec","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-07-23 20:47:45.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nI\u0027m good with this but I\u0027d actually like Josh to take a look because I\u0027m not familiar with this code.","accounts_in_message":[],"_revision_number":1},{"id":"2f2e39e3db1d776d241e035d496381b4cff29fd6","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-07-23 23:46:54.000000000","message":"Patch Set 1: Code-Review-1\n\nA couple things:\n\nThis should have a test case that ensures this is skipped, and that\u0027s the only reason I\u0027m -1ing (sorry! hate to do that with 2 +2\u0027s and its been up for a bit)\n\nOn the overriding erase_devices(), you actually have a few options. If your custom hardware manager is a higher service level than the generic (generic is level 2 I believe, custom managers are encouraged to return 3 or higher from evalute_hardware support), you can return a clean step called \u0027erase_devices\u0027 with priority 0 and it will disable it, or a different priority and your manager will be called during clean before the generic one.\n\nThat being said, this code is still good. I tried to run shred with iterations set to 0 and it shredded anyway, much to my dismay, so that\u0027s a bug that this patch is fixing. Thanks :)","accounts_in_message":[],"_revision_number":1},{"id":"25baff27d91b5ae805da5c06ac96a0600c5e6ab5","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-07-24 02:08:46.000000000","message":"Patch Set 1: Code-Review-1\n\nThose darn unit tests :-(","accounts_in_message":[],"_revision_number":1},{"id":"89a7578b6070ea95fda69ba30ee2966f9e8bb161","author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"date":"2015-08-20 07:24:20.000000000","message":"Patch Set 1: Code-Review-1\n\nDavide,\n\nThanks for the patch.\nI just reviewed this patch because status hasn\u0027t been changed since Jul. 24th.\nI think unit test is necessary too.\n\nBest regards,\nNaohiro","accounts_in_message":[],"_revision_number":1},{"id":"cce6b3446781342a36bde08a7f8e30dae4cf5bc7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-05 09:42:31.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"d91a3611f04e6b52ca0298277293e343fdc887a1","author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"date":"2016-04-11 11:15:26.000000000","message":"Patch Set 1: Code-Review-1\n\nJust leaving a -1 here to notify everyone of the following:\nThe number of passes passed to shred is the number of *random* passes to do. The --zero flag will ensure shred runs a *final* pass of zeroes on the device.\n\nThis means n\u003d0 is a perfectly valid option (and should be the default IMO). Right now we are doing 2 passes, one \"random\" and one \"zeroize\".\n\nubuntu@ubuntu:~$ shred -v -n1 --zero test\nshred: test: pass 1/2 (random)...\nshred: test: pass 2/2 (000000)...\nubuntu@ubuntu:~$ shred -v -n0 --zero test\nshred: test: pass 1/1 (000000)...\n\nhttp://linux.die.net/man/1/shred","accounts_in_message":[],"_revision_number":1},{"id":"4d02671a04bcd309f8aff0e3f368941724a08f0c","author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"date":"2016-04-11 11:40:21.000000000","message":"Patch Set 1:\n\nHi Mathieu,\nI am no longer supporting this patch as I don\u0027t work with Ironic/OpenStack anymore.\nIf someone is willing to resume the work here, please be my guest :)\n\nAnyway, about your comment: please keep in mind that this patch is about skipping local disks erasure if \u0027agent_erase_devices_iterations\u0027 is 0. The user configuring that option doesn\u0027t have to know about shred.\n \nI believe that what you are pointing out is an unrelated bug of the Ironic agent: we are always doing 1 more iteration (zeroing iteration) wrt the value specified in \u0027agent_erase_devices_iterations\u0027, so you may want to fix this elsewhere.\n\nFrom my point of view, if \u0027agent_erase_devices_iterations\u0027 is 0 we should just skip disks erasure as one might expect :)","accounts_in_message":[],"_revision_number":1},{"id":"9ed9c7b2955027700aee6c569e4c69ca989313df","author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"date":"2016-04-11 11:45:46.000000000","message":"Patch Set 1:\n\nThank you for your reply Davide,\n\nAfter submitting my comment I noticed the date on your change. I went ahead and created a bug report https://bugs.launchpad.net/ironic/+bug/1568811 and will change the description for the configuration option. I will also add a release notes notice to ensure everyone understands the setting correctly.\n\nI agree with you deployers shouldn\u0027t have to know shred\u0027s internals or even parameters. FWIW I think we all assumed (myself included) n\u003d1 meant only one \"zero\" pass. Let\u0027s see where the discussion takes us in my change set.\n\nThanks again for your past contributions to Ironic :)","accounts_in_message":[],"_revision_number":1},{"id":"46feee160254cc73cda38a58d373cb7ccdfed480","author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"date":"2016-04-11 12:01:12.000000000","message":"Patch Set 1:\n\nIt has been a pleasure and a privilege working with this awesome community :-)","accounts_in_message":[],"_revision_number":1},{"id":"945e0bd97ca011f474f16fd2da31ee997c4b5bfa","author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"date":"2016-06-15 15:42:31.000000000","message":"Removed the following votes:\n\n* Code-Review-1 by Mathieu Mitchell \u003cmmitchell@iweb.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"f86cf65508823b92dcca3b3db290eec7922faf9d","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2017-01-25 13:05:02.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks for the patch Davide,\n\nI agree with others saying that this is a good thing to have fixed. I will put a patch-set up rebasing this and adding the unittest.","accounts_in_message":[],"_revision_number":1},{"id":"6110309b788fd3db070d7b216fdcf3708269e9d7","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2017-01-25 13:20:22.000000000","message":"Patch Set 1:\n\nApparently it was already fixed by https://review.openstack.org/#/c/304578/ ?","accounts_in_message":[],"_revision_number":1},{"id":"83da8a307618cd28822b418e26dc16d9ccef8430","author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"date":"2017-03-24 20:43:59.000000000","message":"Patch Set 1: Code-Review-1\n\n@Lucas - the patch you referenced just ensures that the last erasure overwrites the disk with zeroes; it doesn\u0027t actually disable the shred: https://www.gnu.org/software/coreutils/manual/html_node/shred-invocation.html\n\n-1 until this is rebased \u0026 tested","accounts_in_message":[],"_revision_number":1},{"id":"72050ec003967d7d193ab70b2c355f41f6be8ec9","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 03:53:30.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1afb44012b15cfe154931b99c6f2c0f004d1b03c","revisions":{"1afb44012b15cfe154931b99c6f2c0f004d1b03c":{"kind":"REWORK","_number":1,"created":"2015-07-07 13:09:42.000000000","uploader":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"ref":"refs/changes/88/199088/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/88/199088/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/199088/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/199088/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/199088/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/88/199088/1"}}},"commit":{"parents":[{"commit":"a0f7485460509287cd0306d466753a0bda91d8c8","subject":"Merge \"Convert Int to String for shred execute\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a0f7485460509287cd0306d466753a0bda91d8c8"}]}],"author":{"name":"Davide Guerri","email":"davide.guerri@gmail.com","date":"2015-07-07 13:05:19.000000000","tz":60},"committer":{"name":"Davide Guerri","email":"davide.guerri@gmail.com","date":"2015-07-07 13:09:21.000000000","tz":60},"subject":"Disable local disks shredding if agent_erase_devices_iterations is 0","message":"Disable local disks shredding if agent_erase_devices_iterations is 0\n\nIt is possible to define multiple steps in the cleaning phase.\nGenericHardwareManager defines erase_devices() step which execute a\nshred of local disks.\nIf there are custom hardware managers, we might want to skip the\nshredding step or even override it with hardware specific operations\nwhile executing other steps.\nDisabling cleaning, would not only disable the shredding step but all\ncustom steps as well.\n\nChange-Id: Ifef196ec774371474c15a2aede5c2d2509397d64\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1afb44012b15cfe154931b99c6f2c0f004d1b03c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1afb44012b15cfe154931b99c6f2c0f004d1b03c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY"},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"}},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}