)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f6867c1f24cda5cc30817704e46210159178517d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d log.getLogger()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _list_block_devices():"},{"line_number":38,"context_line":"    \"\"\"List all physical block devices"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    The switches we use for lsblk: P for KEY\u003d\"value\" output,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_0712be09","line":37,"updated":"2015-08-10 14:12:57.000000000","message":"If the intention is to allow other HW managers to use this, shouldn\u0027t this be not-private? (IOW drop the leading underscore from the name).","commit_id":"77a8202ef877098ab8d7dccd7ca4a2741b56c47b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b475d0e150abb864e8ad2bab6897faceb8430108","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            return Memory(int(psutil.phymem_usage().total))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def list_block_devices(self):"},{"line_number":340,"context_line":"        return list_block_devices()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _get_device_vendor(self, dev):"},{"line_number":343,"context_line":"        \"\"\"Get the vendor name of a given device.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_70157199","line":340,"updated":"2015-08-10 16:22:45.000000000","message":"I will admit that I find it slightly confusing to have two functions with the same name.","commit_id":"91c6ffc8484871678c57d3a90d5e5be3d95a3148"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"1c5b52dadb7e87e1e225af893534ca8a1590d984","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            return Memory(int(psutil.phymem_usage().total))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def list_block_devices(self):"},{"line_number":340,"context_line":"        return list_block_devices()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _get_device_vendor(self, dev):"},{"line_number":343,"context_line":"        \"\"\"Get the vendor name of a given device.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_bc5f06e4","line":340,"in_reply_to":"1a4dcd0f_70157199","updated":"2015-08-11 21:23:28.000000000","message":"I\u0027ll change it.","commit_id":"91c6ffc8484871678c57d3a90d5e5be3d95a3148"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a85054a08c28ed6fa42505e6f7bbbeddb3eabc0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"UNIT_CONVERTER.define(\u0027GB \u003d 1024 MB\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def list_all_block_devices():"},{"line_number":43,"context_line":"    \"\"\"List all physical block devices"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    The switches we use for lsblk: P for KEY\u003d\"value\" output, b for size output"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_814ed994","line":42,"updated":"2015-09-02 06:42:03.000000000","message":"nit: not sure why you added _all_, list_block_devices was retty ok","commit_id":"c014549804096a29bafe5cc95b11a60f0cffc453"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"148022b6891bea365ba01630ba9178628432c65c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"UNIT_CONVERTER.define(\u0027GB \u003d 1024 MB\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def list_all_block_devices():"},{"line_number":43,"context_line":"    \"\"\"List all physical block devices"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    The switches we use for lsblk: P for KEY\u003d\"value\" output, b for size output"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_8f201bb2","line":42,"in_reply_to":"da20952f_814ed994","updated":"2015-09-02 21:37:18.000000000","message":"Heh I agree, that\u0027s how I started, but people were concerned about having the same function name in the hardware manager and the global scope here.","commit_id":"c014549804096a29bafe5cc95b11a60f0cffc453"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"11219f1168f4d560a0245e58518b83adcc69c29a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    :return: A list of BlockDevices"},{"line_number":53,"context_line":"    \"\"\""},{"line_number":54,"context_line":"    report \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbdioKNAME,MODEL,SIZE,ROTA,TYPE\u0027,"},{"line_number":55,"context_line":"                           check_exit_code\u003d[0])[0]"},{"line_number":56,"context_line":"    lines \u003d report.split(\u0027\\n\u0027)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_b2d676ef","line":54,"updated":"2015-08-28 18:08:10.000000000","message":"Why does it ask for \u0027TYPE\u0027?\n\nDoesn\u0027t seem to be used.","commit_id":"c014549804096a29bafe5cc95b11a60f0cffc453"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7a85054a08c28ed6fa42505e6f7bbbeddb3eabc0","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    :return: A list of BlockDevices"},{"line_number":53,"context_line":"    \"\"\""},{"line_number":54,"context_line":"    report \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbdioKNAME,MODEL,SIZE,ROTA,TYPE\u0027,"},{"line_number":55,"context_line":"                           check_exit_code\u003d[0])[0]"},{"line_number":56,"context_line":"    lines \u003d report.split(\u0027\\n\u0027)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_21434d6e","line":54,"updated":"2015-09-02 06:42:03.000000000","message":"used on line #66","commit_id":"c014549804096a29bafe5cc95b11a60f0cffc453"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"d2d329bc3e3e87b9794548142b9a64ae55e2f9ac","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    :return: A list of BlockDevices"},{"line_number":53,"context_line":"    \"\"\""},{"line_number":54,"context_line":"    report \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbdioKNAME,MODEL,SIZE,ROTA,TYPE\u0027,"},{"line_number":55,"context_line":"                           check_exit_code\u003d[0])[0]"},{"line_number":56,"context_line":"    lines \u003d report.split(\u0027\\n\u0027)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_26ba916f","line":54,"in_reply_to":"da20952f_b2d676ef","updated":"2015-09-01 22:32:31.000000000","message":"+1","commit_id":"c014549804096a29bafe5cc95b11a60f0cffc453"}]}