)]}'
{"id":"openstack%2Fironic-python-agent~210626","triplet_id":"openstack%2Fironic-python-agent~master~Ib20e68a8916590513c0a825e44407a110cfbb441","project":"openstack/ironic-python-agent","branch":"master","topic":"(HEAD","hashtags":[],"change_id":"Ib20e68a8916590513c0a825e44407a110cfbb441","subject":"Refactor list_block_devices to its own function","status":"MERGED","created":"2015-08-07 22:45:24.000000000","updated":"2015-09-02 22:17:45.000000000","submitted":"2015-09-02 22:17:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fe53bd2e923b6dfb15d1d104036f338e6aa66ba5","_number":210626,"virtual_id_number":210626,"owner":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-09-02 22:17:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"date":"2015-08-28 18:08:10.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"date":"2015-09-02 21:37:18.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"recommended":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":1,"date":"2015-09-01 18:30:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2015-09-02 21:22:33.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":1,"date":"2015-09-01 22:32:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"value":2,"date":"2015-09-02 06:42:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":1,"date":"2015-09-02 21:22:33.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-10 14:27:54.000000000","updated_by":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"reviewer":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"state":"REVIEWER"},{"updated":"2015-08-11 00:26:33.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2015-08-28 18:08:10.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-09-01 22:32:31.000000000","updated_by":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"reviewer":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"state":"REVIEWER"},{"updated":"2015-09-02 06:42:03.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2015-09-02 21:22:33.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-09-02 22:17:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9ec0b45b394227111974b00752eb3e9f4706f761","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-07 22:45:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cab79b11584740cc061734603143105669210ffb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 23:48:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/26/210626/1/check/gate-ironic-python-agent-pep8/ce8f10b/ : SUCCESS in 51s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/26/210626/1/check/gate-ironic-python-agent-docs/8b701ad//doc/build/html/ : SUCCESS in 1m 15s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/26/210626/1/check/gate-ironic-python-agent-python27/ebe7034/ : SUCCESS in 1m 04s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/26/210626/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/c5a5087/ : SUCCESS in 44m 19s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/26/210626/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/adfba8f/ : SUCCESS in 54m 43s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/26/210626/1/check/gate-ironic-python-agent-python34/805cd71/ : SUCCESS in 1m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f6867c1f24cda5cc30817704e46210159178517d","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-08-10 14:12:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c986971111e50e2cb48f455e377a348089c5d8ea","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-10 14:20:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e0b1f35bd24f32dd60b69d6bbeb2cbef7eb99ead","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2015-08-10 14:27:54.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"14909c1f6a7c2c5fb5d7a1a8fb3f2f8392e4056d","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-10 14:48:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b2c9a40af4f4b3cec4667d4bbdbd133649f3d04a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-10 15:33:05.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/26/210626/3/check/gate-ironic-python-agent-pep8/983f70a/ : SUCCESS in 48s\n- gate-ironic-python-agent-docs http://logs.openstack.org/26/210626/3/check/gate-ironic-python-agent-docs/c81cd2d/ : FAILURE in 1m 34s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/26/210626/3/check/gate-ironic-python-agent-python27/c6684c3/ : SUCCESS in 1m 09s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/26/210626/3/check/gate-tempest-dsvm-ironic-agent_ssh-src/bc84d81/ : FAILURE in 43m 37s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/26/210626/3/check/gate-tempest-dsvm-ironic-pxe_ipa-src/a9454b2/ : SUCCESS in 41m 20s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/26/210626/3/check/gate-ironic-python-agent-python34/3532224/ : SUCCESS in 1m 36s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b475d0e150abb864e8ad2bab6897faceb8430108","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-08-10 16:22:45.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"afaf38ac5917f947ad23e4b9ed1f4443a16ae808","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-08-10 17:26:37.000000000","message":"Patch Set 3:\n\nrecheck\n\nImage rebuilds should be completed now.\n\nhttps://review.openstack.org/#/c/211239/","accounts_in_message":[],"_revision_number":3},{"id":"39f83f2ec23a34551c97548feb192d61263cdb7e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-10 18:10:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/26/210626/3/check/gate-ironic-python-agent-pep8/50d1e69/ : SUCCESS in 1m 47s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/26/210626/3/check/gate-ironic-python-agent-docs/e6d0ef0//doc/build/html/ : SUCCESS in 3m 49s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/26/210626/3/check/gate-ironic-python-agent-python27/dbe926d/ : SUCCESS in 1m 05s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/26/210626/3/check/gate-tempest-dsvm-ironic-agent_ssh-src/030a84e/ : SUCCESS in 42m 56s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/26/210626/3/check/gate-tempest-dsvm-ironic-pxe_ipa-src/fd19aed/ : SUCCESS in 38m 56s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/26/210626/3/check/gate-ironic-python-agent-python34/8926f9b/ : SUCCESS in 1m 24s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"7ad70df4216dbc31f8eedc62e0ffdb269ff96371","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-08-11 00:26:33.000000000","message":"Patch Set 3: Code-Review-1\n\nIt just occurred to me that the tests should be changed to call the new function, and then a test for the old one that makes sure the new one is called. I think. Maybe it\u0027s fine.","accounts_in_message":[],"_revision_number":3},{"id":"987e6be9d8d433c9a924469f1dbbf8107ec8964a","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-11 21:22:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e067d5fa2b0c719d1c7c300ee95b9934980117b8","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-11 21:23:05.000000000","message":"Patch Set 4:\n\nChanged the named, added tests.","accounts_in_message":[],"_revision_number":4},{"id":"1c5b52dadb7e87e1e225af893534ca8a1590d984","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-11 21:23:28.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nThanks for the reviews!","accounts_in_message":[],"_revision_number":3},{"id":"0eb180b3b3563ef02813d60bbcd33ed9a97ce0fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-11 22:11:45.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/26/210626/4/check/gate-ironic-python-agent-pep8/1a0eb27/ : SUCCESS in 58s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/26/210626/4/check/gate-ironic-python-agent-docs/55906da//doc/build/html/ : SUCCESS in 1m 52s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/26/210626/4/check/gate-ironic-python-agent-python27/1da7bef/ : SUCCESS in 1m 11s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/26/210626/4/check/gate-tempest-dsvm-ironic-agent_ssh-src/4fcbc11/ : SUCCESS in 46m 48s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/26/210626/4/check/gate-tempest-dsvm-ironic-pxe_ipa-src/088e396/ : SUCCESS in 38m 11s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/26/210626/4/check/gate-ironic-python-agent-python34/f53c0b1/ : SUCCESS in 1m 12s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"d861a0f2f52795c72acdae74c64579b0677298cd","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-08-12 20:22:22.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"473277b16a99b4428afe967ab66b3c6abd0fbb8a","author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"date":"2015-08-17 22:06:17.000000000","message":"Patch Set 4: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":4},{"id":"4e07b1c84c83ab86ba4be4bc589e3ff5ae607772","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 17:06:44.000000000","message":"Patch Set 4: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"42e947994ed99716d3f2a9b6675798cc5fab8540","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-28 17:04:11.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"0c0bac6a0a115b1e79637749bc03f02f50b6e11d","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-28 17:04:25.000000000","message":"Patch Set 4:\n\nRebased to fix conflicts.","accounts_in_message":[],"_revision_number":4},{"id":"295d6907a746196e9869737305a3e0721d7a00e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-28 18:05:35.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/26/210626/5/check/gate-ironic-python-agent-pep8/151fe2b/ : SUCCESS in 55s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/26/210626/5/check/gate-ironic-python-agent-docs/b82f1fc//doc/build/html/ : SUCCESS in 1m 35s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/26/210626/5/check/gate-ironic-python-agent-python27/507f23d/ : SUCCESS in 59s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/26/210626/5/check/gate-ironic-python-agent-python34/496eff8/ : SUCCESS in 1m 37s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/26/210626/5/check/gate-tempest-dsvm-ironic-agent_ssh-src/1a60c27/ : SUCCESS in 50m 00s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/26/210626/5/check/gate-tempest-dsvm-ironic-pxe_ipa-src/7b34c43/ : SUCCESS in 44m 54s","accounts_in_message":[],"_revision_number":5},{"id":"11219f1168f4d560a0245e58518b83adcc69c29a","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-08-28 18:08:10.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nJust a question","accounts_in_message":[],"_revision_number":5},{"id":"2958471c50efa0174c17a7cf60c9a2d69904b733","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-09-01 18:30:27.000000000","message":"Patch Set 5:\n\nLGTM\n\nThanks Josh.","accounts_in_message":[],"_revision_number":5},{"id":"f5dba184a712ddb49d18e32b8d13341887e6837d","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-09-01 18:30:32.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"d2d329bc3e3e87b9794548142b9a64ae55e2f9ac","author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"date":"2015-09-01 22:32:31.000000000","message":"Patch Set 5: Code-Review+1\n\n(1 comment)\n\nLGTM. I agree with John\u0027s comment about TYPE not being needed, but I\u0027m comfortable with this being merged since it\u0027s not a bug and wasn\u0027t introduced in this patch.","accounts_in_message":[],"_revision_number":5},{"id":"7a85054a08c28ed6fa42505e6f7bbbeddb3eabc0","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-09-02 06:42:03.000000000","message":"Patch Set 5: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"ced86cbab8bd6f254335e7afb7e62e92e47c3605","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-09-02 21:22:33.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"b57b492845c4ba6ce0a9a8c54b073aeddfaac7fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-02 21:22:39.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"148022b6891bea365ba01630ba9178628432c65c","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-09-02 21:37:18.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"2a859795017c6d12e8b5308106eeef99ed956223","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-02 22:17:44.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/26/210626/5/gate/gate-ironic-python-agent-docs/622eeda//doc/build/html/ : SUCCESS in 1m 19s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/26/210626/5/gate/gate-ironic-python-agent-pep8/22b8a00/ : SUCCESS in 52s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/26/210626/5/gate/gate-ironic-python-agent-python27/b3613db/ : SUCCESS in 1m 05s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/26/210626/5/gate/gate-ironic-python-agent-python34/857e110/ : SUCCESS in 1m 12s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/26/210626/5/gate/gate-tempest-dsvm-ironic-agent_ssh-src/44ae67e/ : SUCCESS in 54m 57s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/26/210626/5/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/32ea936/ : SUCCESS in 53m 29s","accounts_in_message":[],"_revision_number":5},{"id":"fd53758639f87efe0be335f6d3802781150bfa25","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-02 22:17:45.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"c014549804096a29bafe5cc95b11a60f0cffc453","revisions":{"77a8202ef877098ab8d7dccd7ca4a2741b56c47b":{"kind":"REWORK","_number":1,"created":"2015-08-07 22:45:24.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/26/210626/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/26/210626/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/1"}}},"commit":{"parents":[{"commit":"1f0378d399eb316cbbb8d55ddc6b528eff2fcd78","subject":"Merge \"Fix logging levels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1f0378d399eb316cbbb8d55ddc6b528eff2fcd78"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-07 22:41:30.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-07 22:45:17.000000000","tz":-420},"subject":"Refactor list_block_devices to its own function","message":"Refactor list_block_devices to its own function\n\nThis function is useful in any HardwareManager that interacts with\ndisks. Subclassing GenericHardwareManager is not ideal for any\nhardware manager that interacts with only specific devices.\n\nChange-Id: Ib20e68a8916590513c0a825e44407a110cfbb441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/77a8202ef877098ab8d7dccd7ca4a2741b56c47b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/77a8202ef877098ab8d7dccd7ca4a2741b56c47b"}]},"branch":"refs/heads/master"},"92c08783f8a44078ad5c39539306e3d23e066ff7":{"kind":"REWORK","_number":2,"created":"2015-08-10 14:20:43.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/26/210626/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/26/210626/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/2"}}},"commit":{"parents":[{"commit":"1f0378d399eb316cbbb8d55ddc6b528eff2fcd78","subject":"Merge \"Fix logging levels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1f0378d399eb316cbbb8d55ddc6b528eff2fcd78"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-07 22:41:30.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-10 14:20:39.000000000","tz":-420},"subject":"Refactor list_block_devices to its own function","message":"Refactor list_block_devices to its own function\n\nThis function is useful in any HardwareManager that interacts with\ndisks. Subclassing GenericHardwareManager is not ideal for any\nhardware manager that interacts with only specific devices.\n\nChange-Id: Ib20e68a8916590513c0a825e44407a110cfbb441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/92c08783f8a44078ad5c39539306e3d23e066ff7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/92c08783f8a44078ad5c39539306e3d23e066ff7"}]},"branch":"refs/heads/master"},"91c6ffc8484871678c57d3a90d5e5be3d95a3148":{"kind":"REWORK","_number":3,"created":"2015-08-10 14:48:39.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/26/210626/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/26/210626/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/3"}}},"commit":{"parents":[{"commit":"1f0378d399eb316cbbb8d55ddc6b528eff2fcd78","subject":"Merge \"Fix logging levels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1f0378d399eb316cbbb8d55ddc6b528eff2fcd78"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-07 22:41:30.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-10 14:48:32.000000000","tz":-420},"subject":"Refactor list_block_devices to its own function","message":"Refactor list_block_devices to its own function\n\nThis function is useful in any HardwareManager that interacts with\ndisks. Subclassing GenericHardwareManager is not ideal for any\nhardware manager that interacts with only specific devices.\n\nChange-Id: Ib20e68a8916590513c0a825e44407a110cfbb441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/91c6ffc8484871678c57d3a90d5e5be3d95a3148"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/91c6ffc8484871678c57d3a90d5e5be3d95a3148"}]},"branch":"refs/heads/master"},"1d604b8615d312c7c25730967546f16ffe11aea6":{"kind":"REWORK","_number":4,"created":"2015-08-11 21:22:36.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/26/210626/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/26/210626/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/4"}}},"commit":{"parents":[{"commit":"1f0378d399eb316cbbb8d55ddc6b528eff2fcd78","subject":"Merge \"Fix logging levels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1f0378d399eb316cbbb8d55ddc6b528eff2fcd78"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-07 22:41:30.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-11 21:22:30.000000000","tz":-420},"subject":"Refactor list_block_devices to its own function","message":"Refactor list_block_devices to its own function\n\nThis function is useful in any HardwareManager that interacts with\ndisks. Subclassing GenericHardwareManager is not ideal for any\nhardware manager that interacts with only specific devices.\n\nChange-Id: Ib20e68a8916590513c0a825e44407a110cfbb441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1d604b8615d312c7c25730967546f16ffe11aea6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1d604b8615d312c7c25730967546f16ffe11aea6"}]},"branch":"refs/heads/master"},"c014549804096a29bafe5cc95b11a60f0cffc453":{"kind":"REWORK","_number":5,"created":"2015-08-28 17:04:11.000000000","uploader":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"ref":"refs/changes/26/210626/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/26/210626/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/26/210626/5"}}},"commit":{"parents":[{"commit":"3de3ca3b2265741daf46c47b119341306555d16f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3de3ca3b2265741daf46c47b119341306555d16f"}]}],"author":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-07 22:41:30.000000000","tz":-420},"committer":{"name":"Josh Gachnang","email":"josh@pcsforeducation.com","date":"2015-08-28 17:03:40.000000000","tz":-420},"subject":"Refactor list_block_devices to its own function","message":"Refactor list_block_devices to its own function\n\nThis function is useful in any HardwareManager that interacts with\ndisks. Subclassing GenericHardwareManager is not ideal for any\nhardware manager that interacts with only specific devices.\n\nChange-Id: Ib20e68a8916590513c0a825e44407a110cfbb441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c014549804096a29bafe5cc95b11a60f0cffc453"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c014549804096a29bafe5cc95b11a60f0cffc453"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}