)]}'
{"ironic_python_agent/errors.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"c2cf608b8949d5c5402fdeecd35cb04d4477a159","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class RESTError(Exception, encoding.Serializable):"},{"line_number":19,"context_line":"    \"\"\"Base class for errors generated in ironic-python-client.\"\"\""},{"line_number":20,"context_line":"    # NOTE(JoshNang) `message` should not end with a period"},{"line_number":21,"context_line":"    message \u003d \u0027An error occurred\u0027"},{"line_number":22,"context_line":"    details \u003d \u0027An unexpected error occurred. Please try back later.\u0027"},{"line_number":23,"context_line":"    status_code \u003d 500"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_bf2db847","line":20,"updated":"2015-08-11 21:58:06.000000000","message":"Why not - just for consistency? Should we enforce this somehow?\n\nMaybe we could check for this in __str__ or __repr__.","commit_id":"108599f3f06ee0069432e97fbcd22ecca94d276a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"834ede6c021f7a24e66f6a1f010d544c099f9421","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class RESTError(Exception, encoding.Serializable):"},{"line_number":19,"context_line":"    \"\"\"Base class for errors generated in ironic-python-client.\"\"\""},{"line_number":20,"context_line":"    # NOTE(JoshNang) `message` should not end with a period"},{"line_number":21,"context_line":"    message \u003d \u0027An error occurred\u0027"},{"line_number":22,"context_line":"    details \u003d \u0027An unexpected error occurred. Please try back later.\u0027"},{"line_number":23,"context_line":"    status_code \u003d 500"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_2dd16657","line":20,"in_reply_to":"1a4dcd0f_bf2db847","updated":"2015-08-12 12:58:33.000000000","message":"I think it\u0027s just because of the sytanx of __repr__ ? Since it adds a \":\" after the message string it would look a bit odd to have something like \"message.: details\".\n\nThis seems to be something that hacking [1] could validate, but I don\u0027t think IPA uses hacking for now so I\u0027m good with the patch as-is.\n\n[1] http://docs.openstack.org/developer/hacking/","commit_id":"108599f3f06ee0069432e97fbcd22ecca94d276a"}]}
