)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"05c9ee7d78f40181fde669d968742fd598c005ae","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        :param node: Ironic node object"},{"line_number":151,"context_line":"        :param ports: list of Ironic port objects"},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        erase_results \u003d {}"},{"line_number":154,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":155,"context_line":"        for block_device in block_devices:"},{"line_number":156,"context_line":"            result \u003d dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d4657be1","line":153,"updated":"2015-08-17 21:50:53.000000000","message":"We should probably define some sort of structure for this (and a :returns docstring would be nice). For example, we could have something like a tuple with a value indicating whether the erase succeeded, fails, or was processed asynchronously with a helpful message of some sort.\n\nOtherwise, someone could have many hardware managers with multiple exception cases and return values, and things could get confusing.","commit_id":"13c925201999244215732bd16c273b69f53b6484"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"5db38a0078da8bd52a33035d7d7081dc9c8fec92","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        :param node: Ironic node object"},{"line_number":151,"context_line":"        :param ports: list of Ironic port objects"},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        erase_results \u003d {}"},{"line_number":154,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":155,"context_line":"        for block_device in block_devices:"},{"line_number":156,"context_line":"            result \u003d dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4f65f11b","line":153,"in_reply_to":"fa1b9901_d4657be1","updated":"2015-08-28 18:04:21.000000000","message":"I think {name: output} is defined well enough. If there\u0027s a failure, it should raise a cleaning error :) And there\u0027s no asynchronicity here. I think spinning off a thread for each disk would be a great optimization though (but a bit challenging..). I\u0027ll definitely add the docstring though.","commit_id":"13c925201999244215732bd16c273b69f53b6484"}]}