)]}'
{"id":"openstack%2Fironic-python-agent~214717","triplet_id":"openstack%2Fironic-python-agent~master~I942fd630617276044edfb4b2ed526a269e80f307","project":"openstack/ironic-python-agent","branch":"master","topic":"proper-cleanup","hashtags":[],"change_id":"I942fd630617276044edfb4b2ed526a269e80f307","subject":"Use addCleanup instead of tearDown","status":"MERGED","created":"2015-08-19 17:16:07.000000000","updated":"2015-08-19 20:18:23.000000000","submitted":"2015-08-19 20:18:23.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"041044119ee7ede448989d357d65d878d246fc36","_number":214717,"virtual_id_number":214717,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-08-19 20:18:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"recommended":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-08-19 19:05:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2015-08-19 17:21:18.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2015-08-19 17:16:45.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":1,"date":"2015-08-19 18:34:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":1,"date":"2015-08-19 19:18:15.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-19 17:21:18.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-08-19 18:34:57.000000000","updated_by":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"reviewer":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"state":"REVIEWER"},{"updated":"2015-08-19 19:05:50.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-08-19 19:18:15.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2015-08-19 20:18:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bd8ec5e2e54b64c1a6ad32d690c38a7ace6a1c0b","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-08-19 17:16:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a599ce36a17a580ef8a519eccce4983f8bc04d5","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-19 17:16:45.000000000","message":"Patch Set 1: Code-Review+2\n\nAhh, good catch.","accounts_in_message":[],"_revision_number":1},{"id":"1857cc28e8c41ca265383a9d154746571a6039a5","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-08-19 17:21:18.000000000","message":"Patch Set 1: Code-Review+2\n\nWill wait for Jenkins to vote before approving.","accounts_in_message":[],"_revision_number":1},{"id":"a19d3faab68070d051f3d7db464914808d552434","author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"date":"2015-08-19 18:34:57.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM! Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"ec52bbc3a2112e9b156f8857a13ec61a36f7f07c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 18:48:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/17/214717/1/check/gate-ironic-python-agent-pep8/1b0b790/ : SUCCESS in 1m 01s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/17/214717/1/check/gate-ironic-python-agent-docs/3cbd979//doc/build/html/ : SUCCESS in 1m 36s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/17/214717/1/check/gate-ironic-python-agent-python27/7c14736/ : SUCCESS in 1m 24s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/17/214717/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/e2798c4/ : SUCCESS in 53m 21s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/17/214717/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/3a8ca8d/ : SUCCESS in 47m 34s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/17/214717/1/check/gate-ironic-python-agent-python34/029e722/ : SUCCESS in 1m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"91bf527bd488d0a33832b0b7377dd78ecdbd9783","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-08-19 19:05:50.000000000","message":"Patch Set 1: Code-Review+1\n\nLearned something new today. Thanks for the patch.","accounts_in_message":[],"_revision_number":1},{"id":"b016ce0c9b04378dad204b8cc6ae5e49f11f432c","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-19 19:18:15.000000000","message":"Patch Set 1: Workflow+1\n\nApproving now that Jenkins is done. Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"17edc2428177a4c7c532d01a6cb6418c3dfa4094","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 19:20:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"917e4c4428c377d6c1ec735c11bca30355a7e114","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 20:18:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/17/214717/1/gate/gate-ironic-python-agent-docs/e6df499//doc/build/html/ : SUCCESS in 2m 32s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/17/214717/1/gate/gate-ironic-python-agent-pep8/b921d25/ : SUCCESS in 58s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/17/214717/1/gate/gate-ironic-python-agent-python27/95a3547/ : SUCCESS in 1m 48s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/17/214717/1/gate/gate-tempest-dsvm-ironic-agent_ssh-src/f5d78d4/ : SUCCESS in 53m 41s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/17/214717/1/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/7ece748/ : SUCCESS in 48m 13s","accounts_in_message":[],"_revision_number":1},{"id":"8482363fb58b63a8907e5f0fd1d6d2e2d877c193","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-19 20:18:23.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0c183edd71854e9c2f5f6c81312f33a011179235","revisions":{"0c183edd71854e9c2f5f6c81312f33a011179235":{"kind":"REWORK","_number":1,"created":"2015-08-19 17:16:07.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/17/214717/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/17/214717/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/214717/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/214717/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/214717/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/17/214717/1"}}},"commit":{"parents":[{"commit":"2d0ba420f1728656cb7f093c82bdf3bc599f0178","subject":"Merge \"Add base for IPA functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2d0ba420f1728656cb7f093c82bdf3bc599f0178"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-08-19 17:15:35.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-08-19 17:15:35.000000000","tz":120},"subject":"Use addCleanup instead of tearDown","message":"Use addCleanup instead of tearDown\n\ntearDown is not guaranteed to run if setUp fails\n\nChange-Id: I942fd630617276044edfb4b2ed526a269e80f307\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0c183edd71854e9c2f5f6c81312f33a011179235"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0c183edd71854e9c2f5f6c81312f33a011179235"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}