)]}'
{"id":"openstack%2Fironic-python-agent~215061","triplet_id":"openstack%2Fironic-python-agent~master~Ic00049bf69f9ecc59ac4e389a3e6afe20ba67aba","project":"openstack/ironic-python-agent","branch":"master","topic":"inspector","hashtags":[],"change_id":"Ic00049bf69f9ecc59ac4e389a3e6afe20ba67aba","subject":"Allow passing node UUID to lookup","status":"MERGED","created":"2015-08-20 10:36:57.000000000","updated":"2015-08-25 23:02:54.000000000","submitted":"2015-08-25 23:02:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fa84db925ad36823b673bcb94ce4e10fd3076df8","_number":215061,"virtual_id_number":215061,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-08-25 23:02:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"date":"2015-08-24 20:23:40.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"date":"2015-08-25 14:23:34.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-08-25 22:04:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2015-08-25 22:08:48.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2015-08-25 16:23:49.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-08-25 22:13:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-24 20:23:40.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2015-08-25 22:08:48.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-08-25 22:13:52.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2015-08-25 23:02:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"da840467ff81577e880848bb26f0942a350a51f7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-08-20 10:36:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d7edd5c7bfe9deb6d724af00f07d4d26a46ee1f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-20 11:30:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/61/215061/1/check/gate-ironic-python-agent-pep8/0a7de7f/ : SUCCESS in 1m 03s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/61/215061/1/check/gate-ironic-python-agent-docs/a76844a//doc/build/html/ : SUCCESS in 1m 49s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/61/215061/1/check/gate-ironic-python-agent-python27/7e3a9c9/ : SUCCESS in 1m 13s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/61/215061/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/db445ed/ : SUCCESS in 50m 22s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/61/215061/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/b4caed5/ : SUCCESS in 48m 04s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/61/215061/1/check/gate-ironic-python-agent-python34/476e12b/ : SUCCESS in 2m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"341f5e13aea2f6939264bbb49e915a90ce65672d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 14:08:43.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"8a7d0b8fd171faf91f0e40b70724985c25b0fcf1","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-08-21 14:25:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c5a55feea336c6d62125a54a2b594c35c1a4adad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 15:58:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/61/215061/2/check/gate-ironic-python-agent-pep8/3a19e72/ : SUCCESS in 1m 16s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/61/215061/2/check/gate-ironic-python-agent-docs/32e6064//doc/build/html/ : SUCCESS in 1m 23s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/61/215061/2/check/gate-ironic-python-agent-python27/56455cd/ : SUCCESS in 1m 03s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/61/215061/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/a96db8c/ : SUCCESS in 39m 24s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/61/215061/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/7db8e1b/ : SUCCESS in 44m 55s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/61/215061/2/check/gate-ironic-python-agent-python34/1dadb87/ : SUCCESS in 1m 33s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0ccbd0f0ef8c200ccf0ad2338bcac96e7e59a72c","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-24 20:23:40.000000000","message":"Patch Set 2:\n\nIs there any value in doing the lookup then? Is the intent to get Ironic to save the data you\u0027re passing in, or is that already passed to Ironic during inspection? If you don\u0027t need the data saved, you could skip lookup and do the first heartbeat right away.\n\nThe original intent for lookup was just to get the UUID, because all other vendor passthru methods (heartbeat here) required a node UUID. It doesn\u0027t do much, and the agent is works without it (in standalone): https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_base_vendor.py#L337","accounts_in_message":[],"_revision_number":2},{"id":"dda99922be9747264e37f3ede880a32ebe5c9c10","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-08-25 14:23:34.000000000","message":"Patch Set 2:\n\nIt is to get configuration values (at least heartbeat period).","accounts_in_message":[],"_revision_number":2},{"id":"9f8b49e0e109663b537bbe00dd19009611336904","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-08-25 16:23:49.000000000","message":"Patch Set 2: Code-Review+2\n\nAhh, duh. That\u0027s totally reasonable. LGTM!","accounts_in_message":[],"_revision_number":2},{"id":"d7f0973a4cdaadcb38cccd4ee2e5ac4a067297fc","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-08-25 22:04:21.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"33f71e3fe77fbbdbdfd483a5011a25abd5062a91","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-08-25 22:08:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"6b8fd11b5eaffa4353ba689d8b9476982d0a9fc3","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-08-25 22:13:52.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4ed1bc0f068ae8f7068ab478f57bbe05bc3c56b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-25 22:13:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7f7a9fcd58f83497eaa6a5cbc81fd28fbcf5b6d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-25 23:02:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/61/215061/2/gate/gate-ironic-python-agent-docs/4feaa78//doc/build/html/ : SUCCESS in 1m 02s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/61/215061/2/gate/gate-ironic-python-agent-pep8/11cbca0/ : SUCCESS in 1m 02s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/61/215061/2/gate/gate-ironic-python-agent-python27/c82b416/ : SUCCESS in 1m 08s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/61/215061/2/gate/gate-tempest-dsvm-ironic-agent_ssh-src/7fa7bf1/ : SUCCESS in 45m 13s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/61/215061/2/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/8adf5c6/ : SUCCESS in 38m 47s","accounts_in_message":[],"_revision_number":2},{"id":"cd1491640c7a4ab3ef045b24dad23e3944bb8531","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-25 23:02:54.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dab1ce983102ad315d073fa39aa2f9531e08f73b","revisions":{"601695b9ac942611eb5a6aeb66947d953b164448":{"kind":"REWORK","_number":1,"created":"2015-08-20 10:36:57.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/61/215061/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/61/215061/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/1"}}},"commit":{"parents":[{"commit":"325b631c62afd4207f00d301f36db0f83a46c059","subject":"Extend hardware manager with data needed for inspector","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/325b631c62afd4207f00d301f36db0f83a46c059"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-08-20 10:35:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-08-20 10:35:37.000000000","tz":120},"subject":"Allow passing node UUID to lookup","message":"Allow passing node UUID to lookup\n\nAfter successful inspection we will know node UUID already, so no need\nto do a proper lookup. In the future we might get rid of lookup completely\nin this case.\n\nChange-Id: Ic00049bf69f9ecc59ac4e389a3e6afe20ba67aba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/601695b9ac942611eb5a6aeb66947d953b164448"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/601695b9ac942611eb5a6aeb66947d953b164448"}]},"branch":"refs/heads/master"},"dab1ce983102ad315d073fa39aa2f9531e08f73b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-08-21 14:25:29.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/61/215061/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/61/215061/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/61/215061/2"}}},"commit":{"parents":[{"commit":"17c7e0523597d15a3659b3dc99a481a0f97714a6","subject":"Extend hardware manager with data needed for inspector","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/17c7e0523597d15a3659b3dc99a481a0f97714a6"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-08-20 10:35:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-08-21 14:25:04.000000000","tz":120},"subject":"Allow passing node UUID to lookup","message":"Allow passing node UUID to lookup\n\nAfter successful inspection we will know node UUID already, so no need\nto do a proper lookup. In the future we might get rid of lookup completely\nin this case.\n\nChange-Id: Ic00049bf69f9ecc59ac4e389a3e6afe20ba67aba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/dab1ce983102ad315d073fa39aa2f9531e08f73b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/dab1ce983102ad315d073fa39aa2f9531e08f73b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}