)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7b89598748090a193362bb15cff258b281c4095e","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        if not root_device_hints:"},{"line_number":388,"context_line":"            # If no hints are passed find the first device larger than"},{"line_number":389,"context_line":"            # 4GB, assume it is the OS disk"},{"line_number":390,"context_line":"            min_size_required \u003d (4 * pow(1024, 3))"},{"line_number":391,"context_line":"            # TODO(russellhaering): This isn\u0027t a valid assumption in"},{"line_number":392,"context_line":"            # all cases, is there a more reasonable default behavior?"},{"line_number":393,"context_line":"            block_devices.sort(key\u003dlambda device: device.size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6a1d8365","line":390,"updated":"2015-09-02 16:09:06.000000000","message":"Seems to be better to use oslo_utils.units.Gi here","commit_id":"56a4ef4f5ed22708698147a474fb5fa76db9376d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"687c144f3a060eb28fb1fb7e2e5f69b17aeb2cf0","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        if not root_device_hints:"},{"line_number":388,"context_line":"            # If no hints are passed find the first device larger than"},{"line_number":389,"context_line":"            # 4GB, assume it is the OS disk"},{"line_number":390,"context_line":"            min_size_required \u003d (4 * pow(1024, 3))"},{"line_number":391,"context_line":"            # TODO(russellhaering): This isn\u0027t a valid assumption in"},{"line_number":392,"context_line":"            # all cases, is there a more reasonable default behavior?"},{"line_number":393,"context_line":"            block_devices.sort(key\u003dlambda device: device.size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_fbe727aa","line":390,"in_reply_to":"da20952f_6a1d8365","updated":"2015-09-02 17:13:37.000000000","message":"Done","commit_id":"56a4ef4f5ed22708698147a474fb5fa76db9376d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"85b1227b401d85466f3969e198f6a7e7d1decd0f","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            if block_devices[-1].size \u003c min_size_required:"},{"line_number":395,"context_line":"                raise errors.DeviceNotFound(\"No suitable device was found \""},{"line_number":396,"context_line":"                    \"for deployment - root device hints were not provided \""},{"line_number":397,"context_line":"                    \"and all found block devices are smaller than %iB.\""},{"line_number":398,"context_line":"                                            % min_size_required)"},{"line_number":399,"context_line":"            for device in block_devices:"},{"line_number":400,"context_line":"                if device.size \u003e\u003d min_size_required:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_7a139565","line":397,"updated":"2015-09-05 19:24:44.000000000","message":"I would prefer logging size in GiB. IIRC we never use size in bytes for disks..","commit_id":"19575d026a62d09ba0cb09591a08b353c27cdbc5"}]}