)]}'
{"id":"openstack%2Fironic-python-agent~220346","triplet_id":"openstack%2Fironic-python-agent~master~I2ad9f85605720ab2295dec3d0436ff0af07847c2","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1367915","hashtags":[],"change_id":"I2ad9f85605720ab2295dec3d0436ff0af07847c2","subject":"Add docstrings for cmd/agent and extensions/clean","status":"MERGED","created":"2015-09-03 23:16:43.000000000","updated":"2015-09-05 20:10:58.000000000","submitted":"2015-09-05 20:10:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1aa56295ffe72b64cb1f82c0b60bf3df1610d1e6","_number":220346,"virtual_id_number":220346,"owner":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-09-05 20:10:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"date":"2015-09-03 23:59:38.000000000","_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-09-04 17:20:34.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2015-09-04 22:09:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2015-09-05 19:21:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":1,"date":"2015-09-05 19:21:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-04 17:20:34.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2015-09-04 22:09:50.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-09-05 19:21:58.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2015-09-05 20:10:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b60ce2ca44dbed915581c59bcc12e10fbeb8baa8","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-09-03 23:16:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f9250a7e14c833608bc76e9f1e5e927559552705","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-03 23:55:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-pep8/13e7b61/ : SUCCESS in 1m 08s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/46/220346/1/check/gate-ironic-python-agent-docs/30c0864//doc/build/html/ : SUCCESS in 1m 25s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-python27/8fd23e3/ : SUCCESS in 1m 11s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-python34/daddd27/ : SUCCESS in 1m 29s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/46/220346/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/180ca46/ : FAILURE in 24m 16s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/46/220346/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/3320da8/ : SUCCESS in 38m 51s","accounts_in_message":[],"_revision_number":1},{"id":"437111c93f75d2ff1cf54634b28b86043cb63d99","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-09-03 23:59:38.000000000","message":"Patch Set 1:\n\nrecheck swift never finished configuring in devstack","accounts_in_message":[],"_revision_number":1},{"id":"178fd6e59497c7ab28bd370089a50355da61ac27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-04 00:39:26.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-pep8/2774c9c/ : SUCCESS in 1m 03s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/46/220346/1/check/gate-ironic-python-agent-docs/169aa4e//doc/build/html/ : SUCCESS in 1m 17s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-python27/77b0a77/ : SUCCESS in 1m 22s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-python34/21a85bb/ : SUCCESS in 1m 31s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/46/220346/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/f79a1d3/ : FAILURE in 20m 35s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/46/220346/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/1d4a152/ : SUCCESS in 39m 42s","accounts_in_message":[],"_revision_number":1},{"id":"9d8a37f11d11e607eb440b87066e48af387ae7af","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2015-09-04 17:20:34.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks, docstring are good even for private (prefixed with _) methods!","accounts_in_message":[],"_revision_number":1},{"id":"141a39e03a28ac42adb1cafb36a2670b766976a6","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-09-04 22:09:50.000000000","message":"Patch Set 1: Code-Review+1\n\nrecheck\n\ngate should be fixed now","accounts_in_message":[],"_revision_number":1},{"id":"10bcfd4852d51623a9c41808ec88aa99030ed018","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-04 23:02:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-pep8/a6bc6f3/ : SUCCESS in 55s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/46/220346/1/check/gate-ironic-python-agent-docs/1c735aa//doc/build/html/ : SUCCESS in 2m 05s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-python27/a42d13f/ : SUCCESS in 1m 09s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/46/220346/1/check/gate-ironic-python-agent-python34/cb9965a/ : SUCCESS in 1m 27s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/46/220346/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/e94350e/ : SUCCESS in 40m 17s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/46/220346/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/07aa8e9/ : SUCCESS in 42m 23s","accounts_in_message":[],"_revision_number":1},{"id":"d06c145e328de997c08c2b8ce142b95e189aa144","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-09-05 19:21:58.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"42385575cd33df03bf106b7467cbcf7afa4c02c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-05 19:22:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6e4bedfa055d8f3640b755e9e2425db855a6c571","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-05 20:10:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/46/220346/1/gate/gate-ironic-python-agent-docs/5339db9//doc/build/html/ : SUCCESS in 1m 05s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/46/220346/1/gate/gate-ironic-python-agent-pep8/65d1356/ : SUCCESS in 51s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/46/220346/1/gate/gate-ironic-python-agent-python27/2739501/ : SUCCESS in 1m 07s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/46/220346/1/gate/gate-ironic-python-agent-python34/7657674/ : SUCCESS in 1m 29s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/46/220346/1/gate/gate-tempest-dsvm-ironic-agent_ssh-src/14de1a5/ : SUCCESS in 48m 51s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/46/220346/1/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/7d363f5/ : SUCCESS in 37m 41s","accounts_in_message":[],"_revision_number":1},{"id":"b853a011542c4bddef91252ede594f340cb339fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-05 20:10:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ac040f5152efae491d6205ad62dc2b7d7b670ced","revisions":{"ac040f5152efae491d6205ad62dc2b7d7b670ced":{"kind":"REWORK","_number":1,"created":"2015-09-03 23:16:43.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/46/220346/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/46/220346/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/46/220346/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/46/220346/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/46/220346/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/46/220346/1"}}},"commit":{"parents":[{"commit":"bc985934164d22a2ebf5fe6e5a361e9bba7f7d8b","subject":"Merge \"Three attempts message is incorrect\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/bc985934164d22a2ebf5fe6e5a361e9bba7f7d8b"}]}],"author":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2015-09-03 23:15:54.000000000","tz":-420},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2015-09-03 23:15:54.000000000","tz":-420},"subject":"Add docstrings for cmd/agent and extensions/clean","message":"Add docstrings for cmd/agent and extensions/clean\n\nAdding documentation for methods in these files that were missing\ndocstrings.\n\nChange-Id: I2ad9f85605720ab2295dec3d0436ff0af07847c2\nPartial-bug: 1367915\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ac040f5152efae491d6205ad62dc2b7d7b670ced"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ac040f5152efae491d6205ad62dc2b7d7b670ced"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}