)]}'
{"ironic_python_agent/inspector.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7a337ce5fa103417e58285ddbf384cdd4b364ac3","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    # root device hints are not set, inspector will use the same root disk as"},{"line_number":234,"context_line":"    # will be used for deploy."},{"line_number":235,"context_line":"    try:"},{"line_number":236,"context_line":"        root_disk \u003d utils.guess_root_disk(inventory[\u0027disks\u0027][:])"},{"line_number":237,"context_line":"    except errors.DeviceNotFound:"},{"line_number":238,"context_line":"        LOG.warn(\u0027no suitable root device detected\u0027)"},{"line_number":239,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1238a79f","line":236,"updated":"2015-09-15 15:16:40.000000000","message":"Why the [:] ?","commit_id":"e727851488908945da745421cdfa3e2b0bb980b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"87267de16640093c8fc77f2943ccdb0b7ec8cdd5","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    # root device hints are not set, inspector will use the same root disk as"},{"line_number":234,"context_line":"    # will be used for deploy."},{"line_number":235,"context_line":"    try:"},{"line_number":236,"context_line":"        root_disk \u003d utils.guess_root_disk(inventory[\u0027disks\u0027][:])"},{"line_number":237,"context_line":"    except errors.DeviceNotFound:"},{"line_number":238,"context_line":"        LOG.warn(\u0027no suitable root device detected\u0027)"},{"line_number":239,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_328ccb34","line":236,"in_reply_to":"ba15a1d1_1238a79f","updated":"2015-09-15 15:17:48.000000000","message":"not too important, but utils.guess_root_disk modifies its argument (sorts is), thus modifying the whole inventory that we plan to send further.","commit_id":"e727851488908945da745421cdfa3e2b0bb980b7"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9bcf0236a7dfed03c59c296435923a83887a730f","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    # root device hints are not set, inspector will use the same root disk as"},{"line_number":234,"context_line":"    # will be used for deploy."},{"line_number":235,"context_line":"    try:"},{"line_number":236,"context_line":"        root_disk \u003d utils.guess_root_disk(inventory[\u0027disks\u0027][:])"},{"line_number":237,"context_line":"    except errors.DeviceNotFound:"},{"line_number":238,"context_line":"        LOG.warn(\u0027no suitable root device detected\u0027)"},{"line_number":239,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_b2f45b87","line":236,"in_reply_to":"ba15a1d1_328ccb34","updated":"2015-09-15 15:19:27.000000000","message":"Ah, it\u0027s a copy. Thanks :)","commit_id":"e727851488908945da745421cdfa3e2b0bb980b7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7cc7c74b86efbc7bb8179b3b85ebb4db6847f3c2","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    try:"},{"line_number":236,"context_line":"        root_disk \u003d utils.guess_root_disk(inventory[\u0027disks\u0027][:])"},{"line_number":237,"context_line":"    except errors.DeviceNotFound:"},{"line_number":238,"context_line":"        LOG.warn(\u0027no suitable root device detected\u0027)"},{"line_number":239,"context_line":"    else:"},{"line_number":240,"context_line":"        data[\u0027root_disk\u0027] \u003d root_disk"},{"line_number":241,"context_line":"        LOG.debug(\u0027default root device is %s\u0027, root_disk.name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_399344a5","line":238,"updated":"2015-09-15 20:35:16.000000000","message":"Add this, I think:\n root_disk \u003d None\n\nAs used on line 252\n\nAlso maybe need a unit test for this code path?","commit_id":"e727851488908945da745421cdfa3e2b0bb980b7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"84ae4acca2f319338e50f03b78366a69db82ab75","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    data[\u0027boot_interface\u0027] \u003d utils.get_agent_params().get(\u0027BOOTIF\u0027)"},{"line_number":245,"context_line":"    LOG.info(\u0027boot devices was %s\u0027, data[\u0027boot_interface\u0027])"},{"line_number":246,"context_line":"    data[\u0027ipmi_address\u0027] \u003d inventory.get(\u0027bmc_address\u0027)"},{"line_number":247,"context_line":"    LOG.info(\u0027BMC IP address: %s\u0027, data[\u0027ipmi_address\u0027])"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    # These 2 calls are required for backward compatibility and should be"},{"line_number":250,"context_line":"    # dropped after inspector is ready (probably in Mitaka cycle)."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_59f4f8f0","line":247,"updated":"2015-09-15 20:35:10.000000000","message":"why are these LOG.info, but the root device is LOG.debug?","commit_id":"e727851488908945da745421cdfa3e2b0bb980b7"}]}