)]}'
{"id":"openstack%2Fironic-python-agent~223054","triplet_id":"openstack%2Fironic-python-agent~master~Ie19b82ff2a914873ff4b2395b02643e086b934b1","project":"openstack/ironic-python-agent","branch":"master","topic":"inspector","hashtags":[],"change_id":"Ie19b82ff2a914873ff4b2395b02643e086b934b1","subject":"inspection: prepare for future deprecations","status":"MERGED","created":"2015-09-14 11:17:30.000000000","updated":"2015-09-17 15:22:53.000000000","submitted":"2015-09-17 15:22:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"23de4e061fcdb2c6f3e900a31fd4ffc6619bd886","_number":223054,"virtual_id_number":223054,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-09-17 15:22:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-09-17 14:31:55.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":1,"date":"2015-09-17 14:46:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2015-09-16 14:38:39.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-09-17 14:31:55.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-16 14:38:39.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-09-17 14:31:55.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2015-09-17 14:46:58.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2015-09-17 15:22:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"10c061e600bc165518bfd22abc4e3d1c48932bfa","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-09-14 11:17:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"043e07128abdfc79b1bdc0357f58ef8daef26380","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-14 12:16:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/54/223054/1/check/gate-ironic-python-agent-pep8/3044ad0/ : SUCCESS in 1m 03s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/54/223054/1/check/gate-ironic-python-agent-docs/b3cba46//doc/build/html/ : SUCCESS in 1m 28s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/54/223054/1/check/gate-ironic-python-agent-python27/cdf9a30/ : SUCCESS in 2m 26s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/54/223054/1/check/gate-ironic-python-agent-python34/a573e69/ : SUCCESS in 1m 21s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/54/223054/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/dd719bc/ : SUCCESS in 54m 58s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/54/223054/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/14a93ad/ : SUCCESS in 39m 44s","accounts_in_message":[],"_revision_number":1},{"id":"7a337ce5fa103417e58285ddbf384cdd4b364ac3","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-09-15 15:16:40.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nLGTM, one quick question inline.","accounts_in_message":[],"_revision_number":1},{"id":"87267de16640093c8fc77f2943ccdb0b7ec8cdd5","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-09-15 15:17:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9bcf0236a7dfed03c59c296435923a83887a730f","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-09-15 15:19:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"84ae4acca2f319338e50f03b78366a69db82ab75","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-09-15 20:35:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7cc7c74b86efbc7bb8179b3b85ebb4db6847f3c2","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-09-15 20:35:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nMinor issue, but I think it should be fixed.","accounts_in_message":[],"_revision_number":1},{"id":"13cb707da743f65b112f7c9c3185d5484ea1791e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-16 12:18:04.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"4440e21836957941cb6ba5ed3f5e8b7d0da592b7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-09-16 12:27:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e761d932f573e063b8e219e68113d1deeaa74adc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-16 13:25:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/54/223054/2/check/gate-ironic-python-agent-pep8/9f538ab/ : SUCCESS in 1m 00s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/54/223054/2/check/gate-ironic-python-agent-docs/3af73cb//doc/build/html/ : SUCCESS in 1m 27s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/54/223054/2/check/gate-ironic-python-agent-python27/9f92eed/ : SUCCESS in 1m 05s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/54/223054/2/check/gate-ironic-python-agent-python34/a690bcd/ : SUCCESS in 1m 17s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/54/223054/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/43c4d06/ : SUCCESS in 56m 01s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/54/223054/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/4ee0bc1/ : SUCCESS in 44m 59s","accounts_in_message":[],"_revision_number":2},{"id":"61ad2e95d0e2e0a17f0d81f2d2de0862c9fbe261","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-09-16 14:38:39.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1c63571d2cd805e43512f53f525b764b5572ddb8","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2015-09-17 14:31:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"fc9ee80df51b370ecf10e125b51f199d76d75b4f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-17 14:34:46.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a0fc80e40d45e4ac646dfa0007ea29b0bbedbc7d","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2015-09-17 14:46:58.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"37d3e84b4026450f91401808fb330f31a62242a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-17 15:22:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/54/223054/2/gate/gate-ironic-python-agent-docs/5392089//doc/build/html/ : SUCCESS in 57s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/54/223054/2/gate/gate-ironic-python-agent-pep8/04ec726/ : SUCCESS in 49s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/54/223054/2/gate/gate-ironic-python-agent-python27/4c68ede/ : SUCCESS in 53s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/54/223054/2/gate/gate-ironic-python-agent-python34/1294cdf/ : SUCCESS in 1m 09s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/54/223054/2/gate/gate-tempest-dsvm-ironic-agent_ssh-src/75a6481/ : SUCCESS in 41m 16s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/54/223054/2/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/e30b649/ : SUCCESS in 40m 34s","accounts_in_message":[],"_revision_number":2},{"id":"65165503e13507349ccc126dcf191ef262c5596c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-17 15:22:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3b70647358de86718ac7d4a354665eca080b3b53","revisions":{"e727851488908945da745421cdfa3e2b0bb980b7":{"kind":"REWORK","_number":1,"created":"2015-09-14 11:17:30.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/54/223054/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/54/223054/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/1"}}},"commit":{"parents":[{"commit":"d5a3d440c23c80816e5f36dcaf0d015a1dba31ad","subject":"Follow-up to inspection patch I00932463d41819fd0a050782e2c88eddf6fc08c6","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d5a3d440c23c80816e5f36dcaf0d015a1dba31ad"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-14 11:16:12.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-14 11:16:12.000000000","tz":120},"subject":"inspection: prepare for future deprecations","message":"inspection: prepare for future deprecations\n\n1. cleanly separate deprecated and non-deprecated properties\n2. add root disk to inspection data, so that we can have a proper\n   fallback when root device hints are not given.\n\nChange-Id: Ie19b82ff2a914873ff4b2395b02643e086b934b1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e727851488908945da745421cdfa3e2b0bb980b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e727851488908945da745421cdfa3e2b0bb980b7"}]},"branch":"refs/heads/master"},"3b70647358de86718ac7d4a354665eca080b3b53":{"kind":"REWORK","_number":2,"created":"2015-09-16 12:27:28.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/54/223054/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/54/223054/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/54/223054/2"}}},"commit":{"parents":[{"commit":"3cd59fac63ffb80f07d54e724031aa5269300786","subject":"Merge \"Follow-up to inspection patch 096830414b\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3cd59fac63ffb80f07d54e724031aa5269300786"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-14 11:16:12.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-16 12:26:57.000000000","tz":120},"subject":"inspection: prepare for future deprecations","message":"inspection: prepare for future deprecations\n\n1. cleanly separate deprecated and non-deprecated properties\n2. add root disk to inspection data, so that we can have a proper\n   fallback when root device hints are not given.\n\nChange-Id: Ie19b82ff2a914873ff4b2395b02643e086b934b1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3b70647358de86718ac7d4a354665eca080b3b53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3b70647358de86718ac7d4a354665eca080b3b53"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}