)]}'
{"id":"openstack%2Fironic-python-agent~225102","triplet_id":"openstack%2Fironic-python-agent~master~I48aa6b6d2d198d16f2f8e387970f7230066cf8a2","project":"openstack/ironic-python-agent","branch":"master","topic":"inspector","hashtags":[],"change_id":"I48aa6b6d2d198d16f2f8e387970f7230066cf8a2","subject":"Expose serial, wwn and vendor on the BlockDevice object","status":"MERGED","created":"2015-09-18 10:53:47.000000000","updated":"2015-09-21 16:24:13.000000000","submitted":"2015-09-21 16:24:12.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6f3b2d7869a63bae6e51cf07f99dc269631ad50e","_number":225102,"virtual_id_number":225102,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-09-21 16:24:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-09-21 13:21:27.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":2,"date":"2015-09-21 15:23:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":2,"date":"2015-09-21 15:31:40.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":1,"date":"2015-09-21 15:31:40.000000000","_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-21 13:21:27.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2015-09-21 15:23:27.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2015-09-21 15:31:40.000000000","updated_by":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"reviewer":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"state":"REVIEWER"},{"updated":"2015-09-21 16:24:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e3480d9ed7359539ce51f9c5775e2b84c5d43cd9","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-09-18 10:53:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58e9428efcab73427529fc7aa975c0dae203307a","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2015-09-18 11:03:39.000000000","message":"Patch Set 1: Code-Review+1\n\n+1 for directions, looks good! Yeah it would be nice to the block device to contain all the information about the device that can also be used in the root device hints","accounts_in_message":[],"_revision_number":1},{"id":"92ff05f76e500f7125f368aa519b4a26c4f99420","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-18 11:54:14.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/02/225102/1/check/gate-ironic-python-agent-pep8/53f8ed5/ : SUCCESS in 56s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/02/225102/1/check/gate-ironic-python-agent-docs/91f58b1//doc/build/html/ : SUCCESS in 1m 31s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/02/225102/1/check/gate-ironic-python-agent-python27/e09ad31/ : FAILURE in 1m 08s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/02/225102/1/check/gate-ironic-python-agent-python34/6ceaee5/ : FAILURE in 1m 32s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/02/225102/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/f09daed/ : SUCCESS in 53m 58s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/02/225102/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/44b53d3/ : SUCCESS in 38m 19s","accounts_in_message":[],"_revision_number":1},{"id":"e394100fa754a2d1cca8b04569ebe27078bb80a3","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-09-21 11:17:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f8dcf37b5f6ff9cec83614abdca234215c72b467","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-21 12:17:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/02/225102/2/check/gate-ironic-python-agent-pep8/dfa80da/ : SUCCESS in 55s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/02/225102/2/check/gate-ironic-python-agent-docs/0f4b56f//doc/build/html/ : SUCCESS in 1m 20s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/02/225102/2/check/gate-ironic-python-agent-python27/1ec45c4/ : SUCCESS in 1m 03s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/02/225102/2/check/gate-ironic-python-agent-python34/e390190/ : SUCCESS in 1m 32s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/02/225102/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/b11b56d/ : SUCCESS in 58m 56s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/02/225102/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/9d27ff8/ : SUCCESS in 45m 14s","accounts_in_message":[],"_revision_number":2},{"id":"fe7383515b8cce6bfb5946a5b0afbcb443e45223","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2015-09-21 13:21:27.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks for adding the tests!\n\nThis LGTM","accounts_in_message":[],"_revision_number":2},{"id":"3eae9bfd4377e61e0fa139d2f588879ff5c7542b","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-09-21 15:23:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4bdcab0e1beda656a2d21ef439905b48687b7569","author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"date":"2015-09-21 15:31:40.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM, nice work!","accounts_in_message":[],"_revision_number":2},{"id":"384002e83a8f0f7d9be8fd3d7ef61e3e3148c902","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-21 15:32:31.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"88ba4636558e1af2e199dcfcf99f725e29690f7e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-21 16:24:12.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/02/225102/2/gate/gate-ironic-python-agent-docs/94bade0//doc/build/html/ : SUCCESS in 1m 29s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/02/225102/2/gate/gate-ironic-python-agent-pep8/28d5cfd/ : SUCCESS in 51s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/02/225102/2/gate/gate-ironic-python-agent-python27/596422f/ : SUCCESS in 1m 01s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/02/225102/2/gate/gate-ironic-python-agent-python34/2a7a3d3/ : SUCCESS in 1m 28s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/02/225102/2/gate/gate-tempest-dsvm-ironic-agent_ssh-src/7d25317/ : SUCCESS in 51m 31s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/02/225102/2/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/a093813/ : SUCCESS in 45m 51s","accounts_in_message":[],"_revision_number":2},{"id":"403346acfe3e54edaf6ba6319641faa297e5dca9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-21 16:24:13.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b569e37d065910cb25e4817951fa75937b7ef357","revisions":{"cbcae2fe3a47bc838ecc91244ffe71fd67cd7b9b":{"kind":"REWORK","_number":1,"created":"2015-09-18 10:53:47.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/02/225102/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/02/225102/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/1"}}},"commit":{"parents":[{"commit":"9a8111f5d2d50b5b3d692100f69dc5242f883168","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9a8111f5d2d50b5b3d692100f69dc5242f883168"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-18 10:52:33.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-18 10:52:33.000000000","tz":120},"subject":"[WIP] Expose serial, wwn and vendor on the BlockDevice object","message":"[WIP] Expose serial, wwn and vendor on the BlockDevice object\n\nCurrently we only use these disk properties for root device hints.\nHowever, they\u0027ll be really useful for inspector, especially for also\nimplementing root device hints.\n\nChange-Id: I48aa6b6d2d198d16f2f8e387970f7230066cf8a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cbcae2fe3a47bc838ecc91244ffe71fd67cd7b9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cbcae2fe3a47bc838ecc91244ffe71fd67cd7b9b"}]},"branch":"refs/heads/master"},"b569e37d065910cb25e4817951fa75937b7ef357":{"kind":"REWORK","_number":2,"created":"2015-09-21 11:17:51.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/02/225102/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/02/225102/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/02/225102/2"}}},"commit":{"parents":[{"commit":"d34f5d857a0f33cafcb530ea83cb494e4eb7f1bd","subject":"Merge \"Create a SerializableComparable class\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d34f5d857a0f33cafcb530ea83cb494e4eb7f1bd"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-18 10:52:33.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-09-21 11:17:20.000000000","tz":120},"subject":"Expose serial, wwn and vendor on the BlockDevice object","message":"Expose serial, wwn and vendor on the BlockDevice object\n\nCurrently we only use these disk properties for root device hints.\nHowever, they\u0027ll be really useful for inspector, especially for also\nimplementing root device hints.\n\nChange-Id: I48aa6b6d2d198d16f2f8e387970f7230066cf8a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b569e37d065910cb25e4817951fa75937b7ef357"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b569e37d065910cb25e4817951fa75937b7ef357"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}