)]}'
{"id":"openstack%2Fironic-python-agent~231658","triplet_id":"openstack%2Fironic-python-agent~master~I5c9a6546d048cbf54695329d9744fda55127bd30","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1503385","hashtags":[],"change_id":"I5c9a6546d048cbf54695329d9744fda55127bd30","subject":"Use mount -t sysfs to avoid host /sys dependencies","status":"MERGED","created":"2015-10-06 18:55:13.000000000","updated":"2015-10-08 09:54:44.000000000","submitted":"2015-10-08 09:54:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"716bd2c133128a21883c8dc8ca9c1dcca362806c","_number":231658,"virtual_id_number":231658,"owner":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-10-08 09:54:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"date":"2015-10-07 17:00:04.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-07 19:51:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":2,"date":"2015-10-08 08:50:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":1,"date":"2015-10-08 08:50:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-07 19:51:39.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2015-10-08 08:50:38.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2015-10-08 09:54:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bee8707c9e9fdd3e0efda04463b5d722cdc565e1","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2015-10-06 18:55:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1084218784d50a1312c4ee73e7d09067892f5751","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-06 19:42:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/58/231658/1/check/gate-ironic-python-agent-pep8/e3229bf/ : FAILURE in 54s\n- gate-ironic-python-agent-docs http://logs.openstack.org/58/231658/1/check/gate-ironic-python-agent-docs/a3df357/ : FAILURE in 41s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/58/231658/1/check/gate-ironic-python-agent-python27/d4079f4/ : FAILURE in 1m 14s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/58/231658/1/check/gate-ironic-python-agent-python34/3acdced/ : FAILURE in 55s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/58/231658/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/85ef6ea/ : FAILURE in 25m 53s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/58/231658/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/1deb302/ : FAILURE in 24m 06s","accounts_in_message":[],"_revision_number":1},{"id":"416b6a5033d872d56f4815c55ad37be410df427b","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-10-06 20:09:40.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"00c238098ae3168fbae14493a170a20a2182eab6","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2015-10-06 20:51:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b8c5093aa1fcba443065bb1577e8c4e06fcf485d","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-10-06 22:15:14.000000000","message":"Patch Set 1:\n\nDan, can you link the DIB element you\u0027re using for this? I\u0027d love to have a look at how it\u0027s setup.","accounts_in_message":[],"_revision_number":1},{"id":"eef02ba5a92e0ed00b157f68d5e75dadebf196eb","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2015-10-07 00:46:24.000000000","message":"Patch Set 1:\n\nJay: sure, here you go:\n\nhttp://git.openstack.org/cgit/openstack/diskimage-builder/tree/elements/enable-serial-console","accounts_in_message":[],"_revision_number":1},{"id":"3ba0373a33a50a67c585555f665d77a72b39b24a","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-10-07 03:29:18.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"647f4aa5c58997f2630198cbbc36139f06b8c510","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-10-07 03:29:38.000000000","message":"Patch Set 2:\n\nRebasing this to fix the python version error in tests, so we can see if it passes tempest.","accounts_in_message":[],"_revision_number":2},{"id":"c60d38cca04f40e19a040c598568281aeac254f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 04:28:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/58/231658/2/check/gate-ironic-python-agent-pep8/1b4a5f8/ : SUCCESS in 44s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/58/231658/2/check/gate-ironic-python-agent-docs/4d11a86//doc/build/html/ : SUCCESS in 1m 16s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/58/231658/2/check/gate-ironic-python-agent-python27/6d11911/ : SUCCESS in 1m 11s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/58/231658/2/check/gate-ironic-python-agent-python34/aff7173/ : SUCCESS in 1m 07s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/58/231658/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/5555c62/ : SUCCESS in 59m 20s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/58/231658/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/e4fa9b3/ : SUCCESS in 39m 56s","accounts_in_message":[],"_revision_number":2},{"id":"43c0a3b39ed465e1ad5fc9a0c4382f39883b99b6","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2015-10-07 17:00:04.000000000","message":"Patch Set 2:\n\nAlso worth noting that our traditional DIB deployment ramdisk (which works for me) used a similar approach here:\n\nhttp://git.openstack.org/cgit/openstack/diskimage-builder/tree/lib/common-functions#n277","accounts_in_message":[],"_revision_number":2},{"id":"52dd63c1499aa9b6d33d04b4b4ca12dc203b36fc","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2015-10-07 19:51:39.000000000","message":"Patch Set 2: Code-Review+2\n\nhttps://gist.github.com/jayofdoom/98cbe8c658b28e974c03\n\nI\u0027ve validated this works in the CoreOS ramdisk.","accounts_in_message":[],"_revision_number":2},{"id":"169afcd048eea98dbe9c1ad535e5d0e696850ae0","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-10-08 08:50:38.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"6d75563bc71a89a0ed998d64c7ced5ac478df549","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 08:50:43.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b6d615e4ac21e9ff15b5956ee1f1b29cbd40a147","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 09:54:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/58/231658/2/gate/gate-ironic-python-agent-docs/a92a15a//doc/build/html/ : SUCCESS in 1m 20s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/58/231658/2/gate/gate-ironic-python-agent-pep8/e98e314/ : SUCCESS in 52s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/58/231658/2/gate/gate-ironic-python-agent-python27/00bb545/ : SUCCESS in 1m 17s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/58/231658/2/gate/gate-ironic-python-agent-python34/6d31c13/ : SUCCESS in 1m 23s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/58/231658/2/gate/gate-tempest-dsvm-ironic-agent_ssh-src/40ed581/ : SUCCESS in 37m 53s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/58/231658/2/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/250d934/ : SUCCESS in 1h 03m 45s","accounts_in_message":[],"_revision_number":2},{"id":"eb4fef90114a331473ec9c06dd2d4410a3511959","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 09:54:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ebd7b076a5d470bf8fe25b329f8da7ed31eea836","revisions":{"042da0506f07a9fe3ba4b069855b69f06b4de8f2":{"kind":"REWORK","_number":1,"created":"2015-10-06 18:55:13.000000000","uploader":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"ref":"refs/changes/58/231658/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/58/231658/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/1"}}},"commit":{"parents":[{"commit":"dcbba2b121da1525feff162aca17a8cc4adf55d6","subject":"Enforce all flake8 rules except E129","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/dcbba2b121da1525feff162aca17a8cc4adf55d6"}]}],"author":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2015-10-06 18:50:55.000000000","tz":-240},"committer":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2015-10-06 18:50:55.000000000","tz":-240},"subject":"Use mount -t sysfs to avoid host /sys dependencies","message":"Use mount -t sysfs to avoid host /sys dependencies\n\nThis patch updates the _install_grub2 function in image.py\nso that we use \u0027mount -t sysfs\u0027 instead of bind mounting\nthe hosts /sys into the chroot.\n\nThis resolves issues which can occur with unmounting\nthe chroot mounts where \u0027target is busy\u0027 errors\nmay occur when you are debugging things with a serial\nconsole.\n\nChange-Id: I5c9a6546d048cbf54695329d9744fda55127bd30\nCloses-bug: #1503385\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/042da0506f07a9fe3ba4b069855b69f06b4de8f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/042da0506f07a9fe3ba4b069855b69f06b4de8f2"}]},"branch":"refs/heads/master"},"ebd7b076a5d470bf8fe25b329f8da7ed31eea836":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-10-07 03:29:18.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/58/231658/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/58/231658/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/58/231658/2"}}},"commit":{"parents":[{"commit":"0414c014d91a1f95b2a6d2d905d76bb5bebc374c","subject":"Merge \"Update the launchpad link for IPA\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0414c014d91a1f95b2a6d2d905d76bb5bebc374c"}]}],"author":{"name":"Dan Prince","email":"dprince@redhat.com","date":"2015-10-06 18:50:55.000000000","tz":-240},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2015-10-07 03:29:18.000000000","tz":0},"subject":"Use mount -t sysfs to avoid host /sys dependencies","message":"Use mount -t sysfs to avoid host /sys dependencies\n\nThis patch updates the _install_grub2 function in image.py\nso that we use \u0027mount -t sysfs\u0027 instead of bind mounting\nthe hosts /sys into the chroot.\n\nThis resolves issues which can occur with unmounting\nthe chroot mounts where \u0027target is busy\u0027 errors\nmay occur when you are debugging things with a serial\nconsole.\n\nChange-Id: I5c9a6546d048cbf54695329d9744fda55127bd30\nCloses-bug: #1503385\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ebd7b076a5d470bf8fe25b329f8da7ed31eea836"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ebd7b076a5d470bf8fe25b329f8da7ed31eea836"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}