)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"76d140634df7ece7e27c7fac2da3bcd86e0fd8fd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if device.get(\u0027TYPE\u0027) !\u003d block_type:"},{"line_number":81,"context_line":"            LOG.debug("},{"line_number":82,"context_line":"                \"TYPE did not match. Wanted: {!r} but found: {!r}\".format("},{"line_number":83,"context_line":"                    block_type, line))"},{"line_number":84,"context_line":"            continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Ensure all required columns are at least present, even if blank"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_d7d673f0","line":83,"updated":"2015-10-08 08:48:49.000000000","message":"Not sure why you used {!r}, both values are strings.. Also we usually use s/Wanted/Expected/","commit_id":"deb50ac5a836c50b37735ebfb950b6829940064f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bb2395feaf4c39bdf191c3f069250f934469981f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if device.get(\u0027TYPE\u0027) !\u003d block_type:"},{"line_number":81,"context_line":"            LOG.debug("},{"line_number":82,"context_line":"                \"TYPE did not match. Wanted: {!r} but found: {!r}\".format("},{"line_number":83,"context_line":"                    block_type, line))"},{"line_number":84,"context_line":"            continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Ensure all required columns are at least present, even if blank"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_e505d979","line":83,"in_reply_to":"7a2fa921_d7d673f0","updated":"2015-10-08 17:44:21.000000000","message":"I used {!r} so that it would get surrounded by quotes.\nFor example: TYPE did not match. Wanted: \u0027disk\u0027 ....\n\nI\u0027m not sure if \u0027expected\u0027 is the correct term. Did we expect to get the result or did we want to get the result...\n\nI sort of feel we \u0027want\u0027 it to match, not that we \u0027expect\u0027 it to match.\n\nBut I can change it :)","commit_id":"deb50ac5a836c50b37735ebfb950b6829940064f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f5629e9c1765cbf98c4a763c89f2097ad418a9ac","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        if device.get(\u0027TYPE\u0027) !\u003d block_type:"},{"line_number":81,"context_line":"            LOG.debug("},{"line_number":82,"context_line":"                \"TYPE did not match. Wanted: {!r} but found: {!r}\".format("},{"line_number":83,"context_line":"                    block_type, line))"},{"line_number":84,"context_line":"            continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Ensure all required columns are at least present, even if blank"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_009e80b8","line":83,"in_reply_to":"7a2fa921_e505d979","updated":"2015-10-09 23:40:35.000000000","message":"As long as it\u0027s not a failure to see non-disk here (it appears to not be), then I actually like the use of \"Wanted\" over \"Expected\", as \"Expected\" implies a problem if it doesn\u0027t match IMO.","commit_id":"deb50ac5a836c50b37735ebfb950b6829940064f"}]}