)]}'
{"ironic_python_agent/extensions/iscsi.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e85d4bf7b3591c832184c9dc8b1488d8599a1148","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        raise errors.ISCSIError(error_msg, e.exit_code, e.stdout, e.stderr)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _wait_for_iscsi_daemon(attempts\u003d6):"},{"line_number":43,"context_line":"    \"\"\"Wait for the ISCSI daemon to start.\"\"\""},{"line_number":44,"context_line":"    # here, iscsi daemon is considered not running in case"},{"line_number":45,"context_line":"    # tgtadm is not able to talk to tgtd to show iscsi targets"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_ce20529e","line":42,"updated":"2015-10-20 09:23:18.000000000","message":"a bit sad to lose interval argument, but I guess it\u0027s fine, as it does not seem to be used\n\nhowever, the new value for attempts bothers me. it looks like the delay now will be between 1.2 and 12 seconds, 6.6 on average, which is less than it used to (10 seconds). I think we need to keep attempts at 10 to have average of 11 seconds.","commit_id":"e970a4c9353d79b8bc712850f5562156e4b00eae"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"83a035032a72a7f4aee4a829612749da0142ff9f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        raise errors.ISCSIError(error_msg, e.exit_code, e.stdout, e.stderr)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _wait_for_iscsi_daemon(attempts\u003d6):"},{"line_number":43,"context_line":"    \"\"\"Wait for the ISCSI daemon to start.\"\"\""},{"line_number":44,"context_line":"    # here, iscsi daemon is considered not running in case"},{"line_number":45,"context_line":"    # tgtadm is not able to talk to tgtd to show iscsi targets"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_c0d1fa58","line":42,"in_reply_to":"3a29b11f_ce20529e","updated":"2015-10-30 00:25:47.000000000","message":"fixed.","commit_id":"e970a4c9353d79b8bc712850f5562156e4b00eae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e85d4bf7b3591c832184c9dc8b1488d8599a1148","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # here, iscsi daemon is considered not running in case"},{"line_number":45,"context_line":"    # tgtadm is not able to talk to tgtd to show iscsi targets"},{"line_number":46,"context_line":"    cmd \u003d [\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027, \u0027target\u0027, \u0027--op\u0027, \u0027show\u0027]"},{"line_number":47,"context_line":"    result \u003d utils.try_execute(*cmd, attempts\u003dattempts, delay_on_retry\u003dTrue)"},{"line_number":48,"context_line":"    if result is None:"},{"line_number":49,"context_line":"        error_msg \u003d \"ISCSI daemon didn\u0027t initialize\""},{"line_number":50,"context_line":"        LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_ee23cea5","line":47,"updated":"2015-10-20 09:23:18.000000000","message":"instead of using try_execute, let\u0027s use execute, capture the actual exception, and add it to the error_mesg","commit_id":"e970a4c9353d79b8bc712850f5562156e4b00eae"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"83a035032a72a7f4aee4a829612749da0142ff9f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # here, iscsi daemon is considered not running in case"},{"line_number":45,"context_line":"    # tgtadm is not able to talk to tgtd to show iscsi targets"},{"line_number":46,"context_line":"    cmd \u003d [\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027, \u0027target\u0027, \u0027--op\u0027, \u0027show\u0027]"},{"line_number":47,"context_line":"    result \u003d utils.try_execute(*cmd, attempts\u003dattempts, delay_on_retry\u003dTrue)"},{"line_number":48,"context_line":"    if result is None:"},{"line_number":49,"context_line":"        error_msg \u003d \"ISCSI daemon didn\u0027t initialize\""},{"line_number":50,"context_line":"        LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_6048262e","line":47,"in_reply_to":"3a29b11f_ee23cea5","updated":"2015-10-30 00:25:47.000000000","message":"fixed","commit_id":"e970a4c9353d79b8bc712850f5562156e4b00eae"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b5f3a8b99dd8011967cdf25efe73c3535c45cb05","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    for attempt in range(attempts):"},{"line_number":47,"context_line":"        if os.path.exists(\"/var/run/tgtd.ipc_abstract_namespace.0\"):"},{"line_number":48,"context_line":"            break"},{"line_number":49,"context_line":"        time.sleep(interval)"},{"line_number":50,"context_line":"    else:"},{"line_number":51,"context_line":"        error_msg \u003d \"ISCSI daemon didn\u0027t initialize\""},{"line_number":52,"context_line":"        LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_3f50870a","side":"PARENT","line":49,"updated":"2015-10-22 19:47:00.000000000","message":"sleep is missing from the new logic.","commit_id":"1aeef4dc0d3125fb9790220ae5af6f7fe2df8b78"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"95b32163a1a42b2ec7d4ae176d94e39c1cd938c5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    for attempt in range(attempts):"},{"line_number":47,"context_line":"        if os.path.exists(\"/var/run/tgtd.ipc_abstract_namespace.0\"):"},{"line_number":48,"context_line":"            break"},{"line_number":49,"context_line":"        time.sleep(interval)"},{"line_number":50,"context_line":"    else:"},{"line_number":51,"context_line":"        error_msg \u003d \"ISCSI daemon didn\u0027t initialize\""},{"line_number":52,"context_line":"        LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_0e3e78b8","side":"PARENT","line":49,"in_reply_to":"3a29b11f_3f50870a","updated":"2015-10-29 15:24:27.000000000","message":"sleep is part of the _execute -\u003e utils.execute -\u003e oslo.concurrency.processutils.execute[1][2] call.\nPlease, note the attempts count is being passed down while the delay_on_retry flag is kept intact (True by default).\n\n[1] https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/processutils.py#L120\n[2] https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/processutils.py#L333","commit_id":"1aeef4dc0d3125fb9790220ae5af6f7fe2df8b78"}]}