)]}'
{"id":"openstack%2Fironic-python-agent~237621","triplet_id":"openstack%2Fironic-python-agent~master~I9e1434ae17da5112527a841ac069ed2285566cca","project":"openstack/ironic-python-agent","branch":"master","topic":"avoid_duplicate_text_in_ISCSIError_message","hashtags":[],"change_id":"I9e1434ae17da5112527a841ac069ed2285566cca","subject":"avoid duplicate text in ISCSIError message","status":"MERGED","created":"2015-10-20 15:00:34.000000000","updated":"2015-10-22 19:36:16.000000000","submitted":"2015-10-22 19:36:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3e44e6eac682e8cced966d969c5c6ae4c73fadfa","_number":237621,"virtual_id_number":237621,"owner":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-10-22 19:36:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-22 18:47:05.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"value":2,"date":"2015-10-20 19:22:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-10-22 18:47:05.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-20 19:22:10.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2015-10-22 18:47:05.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-10-22 19:36:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9ecbc3c3c93817ce88aff5f40434dc2275c5b4d2","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2015-10-20 15:00:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"67f6ac0ae06f3cb0c8a1a30073c6fdcb35e0f843","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2015-10-20 15:28:29.000000000","message":"Patch Set 1: Workflow-1\n\nneed to un-wrap the line","accounts_in_message":[],"_revision_number":1},{"id":"68adb77d881575efe3dd5aa8d1b637fbc6458845","author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"date":"2015-10-20 15:33:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6a68b43e3d37edcb5d6bd2db326a5b6d2dba06f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-20 16:41:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/21/237621/2/check/gate-ironic-python-agent-pep8/04fc02a/ : SUCCESS in 1m 06s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/21/237621/2/check/gate-ironic-python-agent-docs/0e7e4c9//doc/build/html/ : SUCCESS in 1m 19s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/21/237621/2/check/gate-ironic-python-agent-python27/86c1e3c/ : SUCCESS in 1m 16s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/21/237621/2/check/gate-ironic-python-agent-python34/045e4cc/ : SUCCESS in 1m 16s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/21/237621/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/ee61245/ : SUCCESS in 47m 13s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/21/237621/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/2106763/ : SUCCESS in 56m 14s","accounts_in_message":[],"_revision_number":2},{"id":"ab32f51b91089bf7aa1757b8bb252cc1e600482a","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-10-20 19:22:10.000000000","message":"Patch Set 2: Code-Review+2\n\nGood catch","accounts_in_message":[],"_revision_number":2},{"id":"9be42a6bafb108501c99e7783b756c17d88bc3da","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-10-22 18:47:05.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks Milan.","accounts_in_message":[],"_revision_number":2},{"id":"220af9396c14c82f326bda1e4afb5916e4d4768f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-22 18:47:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"23459a9fa83e5e46926c314073390455dc0fc6db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-22 19:36:15.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/21/237621/2/gate/gate-ironic-python-agent-docs/2627076//doc/build/html/ : SUCCESS in 1m 12s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/21/237621/2/gate/gate-ironic-python-agent-pep8/494a49a/ : SUCCESS in 49s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/21/237621/2/gate/gate-ironic-python-agent-python27/b177173/ : SUCCESS in 1m 03s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/21/237621/2/gate/gate-ironic-python-agent-python34/b3d53f1/ : SUCCESS in 2m 20s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/21/237621/2/gate/gate-tempest-dsvm-ironic-agent_ssh-src/88b47b9/ : SUCCESS in 43m 44s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/21/237621/2/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/fa36b44/ : SUCCESS in 49m 03s","accounts_in_message":[],"_revision_number":2},{"id":"db90c4c7c255b44d85d5882ae57191fee6578c38","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-22 19:36:16.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e51ccbe7c3c6e0836774e5d062fa58b3630ec179","revisions":{"dc24aa606467d6cdc6c1773d5f0e5981ace708b7":{"kind":"REWORK","_number":1,"created":"2015-10-20 15:00:34.000000000","uploader":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"ref":"refs/changes/21/237621/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/21/237621/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/1"}}},"commit":{"parents":[{"commit":"1aeef4dc0d3125fb9790220ae5af6f7fe2df8b78","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1aeef4dc0d3125fb9790220ae5af6f7fe2df8b78"}]}],"author":{"name":"dparalen","email":"vetrisko@gmail.com","date":"2015-10-20 12:59:16.000000000","tz":120},"committer":{"name":"dparalen","email":"vetrisko@gmail.com","date":"2015-10-20 14:59:42.000000000","tz":120},"subject":"avoid duplicate text in ISCSIError message","message":"avoid duplicate text in ISCSIError message\n\nThe ISCSIError class defines a class-level message attribute with\nvalue: \"Error starting iSCSI target\". This attribute is further\nprocessed in RESTError.__init__ method, the ISCSIError super-class, to\ncreate an Exception message concatenating self.message with provided\ndetails argument.  However, the ISCISError.__init__ method provides a\ndetails attribute prefixed with the same text to the super(ISCSIError,\nself).__init__ method.  As a result, the text appears twice:\n\"ISCSIError: Error starting iSCSI target: Error starting iSCSI target:\nISCSI daemon didn\u0027t initialize. Failed with exit code 107. stdout: .\nstderr: tgtadm: failed to send request hdr to tgt daemon, Transport\nendpoint is not connected\"\n\nThe patch purpose is to remove the details prefix to avoid duplicate\ntext in the exception text while honouring ISCSIError.message.\n\nChange-Id: I9e1434ae17da5112527a841ac069ed2285566cca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/dc24aa606467d6cdc6c1773d5f0e5981ace708b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/dc24aa606467d6cdc6c1773d5f0e5981ace708b7"}]},"branch":"refs/heads/master"},"e51ccbe7c3c6e0836774e5d062fa58b3630ec179":{"kind":"REWORK","_number":2,"created":"2015-10-20 15:33:10.000000000","uploader":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"ref":"refs/changes/21/237621/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/21/237621/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/21/237621/2"}}},"commit":{"parents":[{"commit":"1aeef4dc0d3125fb9790220ae5af6f7fe2df8b78","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1aeef4dc0d3125fb9790220ae5af6f7fe2df8b78"}]}],"author":{"name":"dparalen","email":"vetrisko@gmail.com","date":"2015-10-20 12:59:16.000000000","tz":120},"committer":{"name":"dparalen","email":"vetrisko@gmail.com","date":"2015-10-20 06:10:56.000000000","tz":120},"subject":"avoid duplicate text in ISCSIError message","message":"avoid duplicate text in ISCSIError message\n\nThe ISCSIError class defines a class-level message attribute with\nvalue: \"Error starting iSCSI target\". This attribute is further\nprocessed in RESTError.__init__ method, the ISCSIError super-class, to\ncreate an Exception message concatenating self.message with provided\ndetails argument.  However, the ISCISError.__init__ method provides a\ndetails attribute prefixed with the same text to the super(ISCSIError,\nself).__init__ method.  As a result, the text appears twice:\n\"ISCSIError: Error starting iSCSI target: Error starting iSCSI target:\nISCSI daemon didn\u0027t initialize. Failed with exit code 107. stdout: .\nstderr: tgtadm: failed to send request hdr to tgt daemon, Transport\nendpoint is not connected\"\n\nThe patch purpose is to remove the details prefix to avoid duplicate\ntext in the exception text while honouring ISCSIError.message.\n\nChange-Id: I9e1434ae17da5112527a841ac069ed2285566cca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e51ccbe7c3c6e0836774e5d062fa58b3630ec179"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e51ccbe7c3c6e0836774e5d062fa58b3630ec179"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}