)]}'
{"id":"openstack%2Fironic-python-agent~247514","triplet_id":"openstack%2Fironic-python-agent~master~I4c6712ea1e813d1f0f0d0aedaccfa1187526e0ec","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1517913","hashtags":[],"change_id":"I4c6712ea1e813d1f0f0d0aedaccfa1187526e0ec","subject":"Fix \"logs\" inspection collector when logs contain non-ascii symbols","status":"MERGED","created":"2015-11-19 13:48:09.000000000","updated":"2015-12-09 16:52:44.000000000","submitted":"2015-12-09 16:51:54.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e90059cb48901052959f463dbee7596c2a3f4ccc","_number":247514,"virtual_id_number":247514,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-12-09 16:51:54.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"date":"2015-12-08 19:01:02.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-08 13:44:37.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":1,"date":"2015-12-09 06:24:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":2,"date":"2015-12-09 16:04:05.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":1,"date":"2015-12-09 16:04:05.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-08 13:44:37.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2015-12-09 06:24:15.000000000","updated_by":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"reviewer":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"state":"REVIEWER"},{"updated":"2015-12-09 16:04:05.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2015-12-09 16:51:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a0d483a621769a5f9b34a0c16ba315d420659441","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-11-19 13:48:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfc592ee5adfca379461271127b273a5ac9a1e9f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-11-19 13:48:22.000000000","message":"Patch Set 1: Workflow-1\n\ntesting in my env","accounts_in_message":[],"_revision_number":1},{"id":"bab7f096488123ff438ee6a004106b26ab894d81","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-19 14:59:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/14/247514/1/check/gate-ironic-python-agent-pep8/800cdad/ : SUCCESS in 49s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/14/247514/1/check/gate-ironic-python-agent-docs/7cd2364//doc/build/html/ : SUCCESS in 1m 19s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/14/247514/1/check/gate-ironic-python-agent-python27/d0f237e/ : SUCCESS in 1m 03s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/14/247514/1/check/gate-ironic-python-agent-python34/4217c92/ : SUCCESS in 1m 17s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/14/247514/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/0fa1204/ : SUCCESS in 55m 57s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/14/247514/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/bd46148/ : SUCCESS in 48m 25s","accounts_in_message":[],"_revision_number":1},{"id":"82c8cd702851ea53352f9077514fb1383b9e184b","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-12-08 13:12:23.000000000","message":"Patch Set 1: -Workflow\n\nfinally tested, works for me","accounts_in_message":[],"_revision_number":1},{"id":"6f636d39262c5d076a0f0d7590e6f3624e5028ca","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2015-12-08 13:24:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nMoslty a nit but I think it\u0027s important to validate the arguments passed to the utils.execute() command.","accounts_in_message":[],"_revision_number":1},{"id":"f086b712cd4947d9cf6a17e7ddbec9ef3ff40cee","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-12-08 13:32:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ce85ed2f3f7a25ab303057bd67e08c5e0213d2d8","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2015-12-08 13:44:37.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks for the changes","accounts_in_message":[],"_revision_number":2},{"id":"bb0516e48bdfb5c53b580a21da71e35946f960c8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-08 17:52:40.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/14/247514/2/check/gate-ironic-python-agent-pep8/8223977/ : SUCCESS in 56s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/14/247514/2/check/gate-ironic-python-agent-docs/8e686b1//doc/build/html/ : SUCCESS in 1m 04s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/14/247514/2/check/gate-ironic-python-agent-python27/f4d6b11/ : SUCCESS in 1m 31s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/14/247514/2/check/gate-ironic-python-agent-python34/b28eacc/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/14/247514/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/f015c16/ : SUCCESS in 49m 45s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/14/247514/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/0f6d990/ : FAILURE in 45m 24s","accounts_in_message":[],"_revision_number":2},{"id":"5c4ac464771ca84907dc2a89bf6d4d0b8d4a926f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-12-08 19:01:02.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"572e7e1537f608355c06efa9dd43bc8d8e5d5769","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-08 21:26:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/14/247514/2/check/gate-ironic-python-agent-pep8/d15cfb5/ : SUCCESS in 1m 10s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/14/247514/2/check/gate-ironic-python-agent-docs/ebcba95//doc/build/html/ : SUCCESS in 1m 47s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/14/247514/2/check/gate-ironic-python-agent-python27/701e6e2/ : SUCCESS in 2m 39s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/14/247514/2/check/gate-ironic-python-agent-python34/e37d8f9/ : SUCCESS in 1m 27s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/14/247514/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/80b2777/ : SUCCESS in 54m 17s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/14/247514/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/cde59bd/ : SUCCESS in 51m 47s","accounts_in_message":[],"_revision_number":2},{"id":"1b37efa898929a4dbae2a972570dc94329d38ab2","author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"date":"2015-12-09 06:24:15.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks for the patch. LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"ad4606525aa472a5603dc403d2eb119a52115282","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2015-12-09 16:04:05.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks!","accounts_in_message":[],"_revision_number":2},{"id":"24bfa34cabe738a76bb2dd0c374dac72b3d6709d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-09 16:04:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e95786ebede40064e334a6fae952c7951e1a8e7f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-09 16:51:54.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"2980e5439ab4a3a6aa39d55d473f8cf4b66abec5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-09 16:51:54.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/14/247514/2/gate/gate-ironic-python-agent-docs/50a6944//doc/build/html/ : SUCCESS in 1m 27s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/14/247514/2/gate/gate-ironic-python-agent-pep8/a99a648/ : SUCCESS in 1m 10s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/14/247514/2/gate/gate-ironic-python-agent-python27/4a84440/ : SUCCESS in 1m 27s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/14/247514/2/gate/gate-ironic-python-agent-python34/528ec6a/ : SUCCESS in 1m 33s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/14/247514/2/gate/gate-tempest-dsvm-ironic-agent_ssh-src/bcb90c1/ : SUCCESS in 47m 35s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/14/247514/2/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/690c02a/ : SUCCESS in 42m 28s","accounts_in_message":[],"_revision_number":2},{"id":"f027e278a8f77a1cd6c13061eb59829282f22216","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2015-12-09 16:52:44.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/liberty as commit 9353adda59d7fe9d85465ef195b82a2437814e39","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5fa258b7087e610625e0277efb197f87db08f1ea","revisions":{"879f101f302a52386c8433507446cbfa83b02087":{"kind":"REWORK","_number":1,"created":"2015-11-19 13:48:09.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/14/247514/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/14/247514/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/1"}}},"commit":{"parents":[{"commit":"a2a71105c4a758ddbfa206255b4bf320fc407af7","subject":"Merge \"Refactor the image download and checksum computation bits\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a2a71105c4a758ddbfa206255b4bf320fc407af7"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-11-19 13:46:46.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-11-19 13:47:50.000000000","tz":60},"subject":"Fix \"logs\" inspection collector when logs contain non-ascii symbols","message":"Fix \"logs\" inspection collector when logs contain non-ascii symbols\n\nSomehow it didn\u0027t pop earlier. Updated tests to contain some creepy\nrussian letters :)\n\nCloses-Bug: #1517913\nChange-Id: I4c6712ea1e813d1f0f0d0aedaccfa1187526e0ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/879f101f302a52386c8433507446cbfa83b02087"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/879f101f302a52386c8433507446cbfa83b02087"}]},"branch":"refs/heads/master"},"5fa258b7087e610625e0277efb197f87db08f1ea":{"kind":"REWORK","_number":2,"created":"2015-12-08 13:32:28.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/14/247514/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/14/247514/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/14/247514/2"}}},"commit":{"parents":[{"commit":"1720759fa7d840471f65e0926bdfcc77c64e1221","subject":"Merge \"Support Linux-IO in addition to tgtd\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1720759fa7d840471f65e0926bdfcc77c64e1221"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-11-19 13:46:46.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@redhat.com","date":"2015-12-08 13:32:16.000000000","tz":60},"subject":"Fix \"logs\" inspection collector when logs contain non-ascii symbols","message":"Fix \"logs\" inspection collector when logs contain non-ascii symbols\n\nSomehow it didn\u0027t pop earlier. Updated tests to contain some creepy\nrussian letters :)\n\nCloses-Bug: #1517913\nChange-Id: I4c6712ea1e813d1f0f0d0aedaccfa1187526e0ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5fa258b7087e610625e0277efb197f87db08f1ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5fa258b7087e610625e0277efb197f87db08f1ea"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}