)]}'
{"id":"openstack%2Fironic-python-agent~262529","triplet_id":"openstack%2Fironic-python-agent~master~I8e95e10fac4748b115838b6b480f1085da73f28a","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"I8e95e10fac4748b115838b6b480f1085da73f28a","subject":"Change assertTrue(isinstance()) by optimal assert","status":"MERGED","created":"2015-12-30 14:38:57.000000000","updated":"2016-01-25 18:30:03.000000000","submitted":"2016-01-25 18:30:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a875fbfb30d8a26cd02f46c41e1b185e65bd43f2","_number":262529,"virtual_id_number":262529,"owner":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-01-25 18:30:03.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":2,"date":"2016-01-25 18:28:16.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"value":2,"date":"2016-01-22 08:32:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":1,"date":"2016-01-25 18:28:16.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-30 15:05:01.000000000","updated_by":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"reviewer":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"state":"REVIEWER"},{"updated":"2016-01-04 13:27:05.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2016-01-22 08:32:39.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-01-25 18:28:16.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2016-01-25 18:30:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5fa12bbd2d7a9bea434cf2275ec08eaa474d70eb","author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"date":"2015-12-30 14:38:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a4267e7e305c46e4a03603b0ee269d8cb8206f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-30 14:44:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/29/262529/1/check/gate-ironic-python-agent-pep8/8e1e384/ : FAILURE in 1m 02s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/29/262529/1/check/gate-ironic-python-agent-docs/ba9d98f//doc/build/html/ : SUCCESS in 1m 33s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/29/262529/1/check/gate-ironic-python-agent-python27/1ae52e4/ : FAILURE in 1m 28s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/29/262529/1/check/gate-ironic-python-agent-python34/acb288a/ : FAILURE in 2m 18s","accounts_in_message":[],"_revision_number":1},{"id":"f32eadff3222e0100a24d0c50ca46d5bc8805eaa","author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"date":"2015-12-30 15:05:01.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4e0d89f1c15b1bcf17bb68b1cbe55ea0f6c6235b","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-01-04 13:27:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6a636023c87ad5805a13d5c6ef40916fb09927fc","author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"date":"2016-01-21 06:20:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"80b8277bd96c1a9331acbf6c5adaf22bf0cd2bfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-21 06:23:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/29/262529/2/check/gate-ironic-python-agent-pep8/f8c13be/ : SUCCESS in 1m 09s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/29/262529/2/check/gate-ironic-python-agent-docs/bb602df//doc/build/html/ : SUCCESS in 1m 29s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/29/262529/2/check/gate-ironic-python-agent-python27/58874f5/ : SUCCESS in 1m 11s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/29/262529/2/check/gate-ironic-python-agent-python34/ad2bc7b/ : SUCCESS in 1m 18s","accounts_in_message":[],"_revision_number":2},{"id":"1a2d69fad1fba1fac49156013b768f55efc672c9","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-01-22 08:32:39.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f181dcb1ee1912ff61e370ca0c4d1f01087e12f4","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2016-01-25 18:28:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c6a8df13650fa9912d199b84a5d00b1ffb808626","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-25 18:28:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b42ecfb826c9dd5487c95b37d2f41697417dccd1","date":"2016-01-25 18:30:03.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"cbdd98b6c1bc797ce85f8cfaec8f4e47113051c0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-25 18:30:03.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/29/262529/2/gate/gate-ironic-python-agent-docs/2296ffa//doc/build/html/ : SUCCESS in 1m 24s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/29/262529/2/gate/gate-ironic-python-agent-pep8/63ff02f/ : SUCCESS in 57s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/29/262529/2/gate/gate-ironic-python-agent-python27/7c404fe/ : SUCCESS in 1m 24s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/29/262529/2/gate/gate-ironic-python-agent-python34/505c4c8/ : SUCCESS in 1m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fac700c8e76919996b735a5a3760050bfe05e88c","revisions":{"60a70469785147ec3f7e729fb3468c55c7653cca":{"kind":"REWORK","_number":1,"created":"2015-12-30 14:38:57.000000000","uploader":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"ref":"refs/changes/29/262529/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/29/262529/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/1"}}},"commit":{"parents":[{"commit":"10f1f203765974a2a77a7238ad5581e2e02fa157","subject":"Merge \"Revert \"Use latest CoreOS stable when building\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/10f1f203765974a2a77a7238ad5581e2e02fa157"}]}],"author":{"name":"Shuquan Huang","email":"huang.shuquan@99cloud.net","date":"2015-12-30 14:38:25.000000000","tz":480},"committer":{"name":"Shuquan Huang","email":"huang.shuquan@99cloud.net","date":"2015-12-30 14:38:25.000000000","tz":480},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nSome of tests use different method of assertTrue(isinstance(A, B)) or\nassertEqual(type(A), B). The correct way is to use assertIsInstance(A,\nB) provided by testtools.\n\nChange-Id: I8e95e10fac4748b115838b6b480f1085da73f28a\nCloses-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/60a70469785147ec3f7e729fb3468c55c7653cca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/60a70469785147ec3f7e729fb3468c55c7653cca"}]},"branch":"refs/heads/master"},"fac700c8e76919996b735a5a3760050bfe05e88c":{"kind":"REWORK","_number":2,"created":"2016-01-21 06:20:27.000000000","uploader":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"ref":"refs/changes/29/262529/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/29/262529/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/29/262529/2"}}},"commit":{"parents":[{"commit":"55239c2199d50403f203a9e41bef45fe6d7f67b1","subject":"Merge \"Fix params order in assertEqual\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/55239c2199d50403f203a9e41bef45fe6d7f67b1"}]}],"author":{"name":"Shuquan Huang","email":"huang.shuquan@99cloud.net","date":"2015-12-30 14:38:25.000000000","tz":480},"committer":{"name":"Shuquan Huang","email":"huang.shuquan@99cloud.net","date":"2016-01-21 06:20:11.000000000","tz":480},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nSome of tests use different method of assertTrue(isinstance(A, B)) or\nassertEqual(type(A), B). The correct way is to use assertIsInstance(A,\nB) provided by testtools.\n\nChange-Id: I8e95e10fac4748b115838b6b480f1085da73f28a\nCloses-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fac700c8e76919996b735a5a3760050bfe05e88c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fac700c8e76919996b735a5a3760050bfe05e88c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}