)]}'
{"ironic_python_agent/extensions/iscsi.py":[{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"5777bb334530268df31bcc2339d0fc69f5f0f946","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        # bind to the default port on all interfaces"},{"line_number":98,"context_line":"        # set default port"},{"line_number":99,"context_line":"        if portal_port is None:"},{"line_number":100,"context_line":"            portal_port \u003d 3260"},{"line_number":101,"context_line":"        rtslib_fb.NetworkPortal(tpg, \u00270.0.0.0\u0027, portal_port)"},{"line_number":102,"context_line":"    except rtslib_fb.utils.RTSLibError as exc:"},{"line_number":103,"context_line":"        msg \u003d \u0027Failed to publish a target: {0}\u0027.format(exc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_4130f6e8","line":100,"updated":"2016-01-26 09:19:26.000000000","message":"This is the magic number. Can we make a change like:\n\nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/standby.py#L33","commit_id":"927b8c59bfae4b794199fe4e235c2faf3eebb39c"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"5777bb334530268df31bcc2339d0fc69f5f0f946","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # If port is not given, set default value for log info"},{"line_number":172,"context_line":"        if portal_port is None:"},{"line_number":173,"context_line":"            portal_port \u003d 3260"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        LOG.info(\u0027Created iSCSI target with iqn %(iqn)s, portal_port %(port)s,\u0027"},{"line_number":176,"context_line":"                 \u0027 on device %(dev)s using %(method)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_a15532fb","line":173,"updated":"2016-01-26 09:19:26.000000000","message":"ditto","commit_id":"927b8c59bfae4b794199fe4e235c2faf3eebb39c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7310a54c5eb8785ef05a2c66ae295fde3235e961","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # If port is not given, set default value for log info"},{"line_number":173,"context_line":"        if portal_port is None:"},{"line_number":174,"context_line":"            portal_port \u003d ISCSI_PORTAL_PORT"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        LOG.info(\u0027Created iSCSI target with iqn %(iqn)s, portal_port %(port)d,\u0027"},{"line_number":177,"context_line":"                 \u0027 on device %(dev)s using %(method)s\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_8e47b84a","line":174,"updated":"2016-01-28 14:30:59.000000000","message":"this check should go upper and not duplicate in start_lio","commit_id":"cb67404c4c7bd7c488b503f8891c53d7b516591c"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"2ac93e875f974b7ca2e9334db851371d7830bf9b","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # If port is not given, set default value for log info"},{"line_number":173,"context_line":"        if portal_port is None:"},{"line_number":174,"context_line":"            portal_port \u003d ISCSI_PORTAL_PORT"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        LOG.info(\u0027Created iSCSI target with iqn %(iqn)s, portal_port %(port)d,\u0027"},{"line_number":177,"context_line":"                 \u0027 on device %(dev)s using %(method)s\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_fe16faef","line":174,"in_reply_to":"7a5de9d1_8e47b84a","updated":"2016-01-29 02:38:44.000000000","message":"That is because the difference between tgt and lio, for tgt, once the service is started, it will create default portal with default 3260 port, so for tgt operations, if no portal_port is specialed, no need to call portal creating command.\n\nSo we can move this check to upper, but for tgt case, will take no action if the portal_port is default value 3260.","commit_id":"cb67404c4c7bd7c488b503f8891c53d7b516591c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"2bedd6c249f64b014aed856caca24cd8718fc2e5","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    _wait_for_tgtd()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # tgt service will create default portal on default port 3260."},{"line_number":61,"context_line":"    # so no need to create again if input portal_port \u003d\u003d 3260."},{"line_number":62,"context_line":"    if portal_port !\u003d ISCSI_PORTAL_PORT:"},{"line_number":63,"context_line":"        cmd \u003d [\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027, \u0027portal\u0027, \u0027--op\u0027,"},{"line_number":64,"context_line":"               \u0027new\u0027, \u0027--param\u0027, \u0027portal\u003d0.0.0.0:\u0027 + str(portal_port)]"},{"line_number":65,"context_line":"        _execute(cmd, \"Error when adding a new portal with portal_port %d\""},{"line_number":66,"context_line":"                 % portal_port)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    cmd \u003d [\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027, \u0027target\u0027, \u0027--op\u0027,"},{"line_number":69,"context_line":"           \u0027new\u0027, \u0027--tid\u0027, \u00271\u0027, \u0027--targetname\u0027, iqn]"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_76b6103f","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":31},"updated":"2016-02-03 08:47:29.000000000","message":"Haomeng,\n\nThanks for nice patch.\nI may be missing something, but I couldn\u0027t find any test code which exercise the above.\n\nBest regards,\nNaohiro","commit_id":"0496d884f54e4365a8facc4b00cb19cc9b7d4d82"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"184b7da6d60b83b1915a96a74865383fe1ba7cb6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from ironic_python_agent import utils"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":33,"context_line":"ISCSI_PORTAL_PORT \u003d 3260"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _execute(cmd, error_msg, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_a019d87b","line":33,"updated":"2016-02-26 15:13:08.000000000","message":"s/ISCSI_PORTAL_PORT/DEFAULT_ISCSI_PORTAL_PORT","commit_id":"a067fadd1ab27a43baf20f40f72c948482379aa1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"184b7da6d60b83b1915a96a74865383fe1ba7cb6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        cmd \u003d [\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027, \u0027portal\u0027, \u0027--op\u0027,"},{"line_number":64,"context_line":"               \u0027new\u0027, \u0027--param\u0027, \u0027portal\u003d0.0.0.0:\u0027 + str(portal_port)]"},{"line_number":65,"context_line":"        _execute(cmd, \"Error when adding a new portal with portal_port %d\""},{"line_number":66,"context_line":"                 % portal_port)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    cmd \u003d [\u0027tgtadm\u0027, \u0027--lld\u0027, \u0027iscsi\u0027, \u0027--mode\u0027, \u0027target\u0027, \u0027--op\u0027,"},{"line_number":69,"context_line":"           \u0027new\u0027, \u0027--tid\u0027, \u00271\u0027, \u0027--targetname\u0027, iqn]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_00bb64e6","line":66,"updated":"2016-02-26 15:13:08.000000000","message":"We need to add tests for this exercise this conditional as well","commit_id":"a067fadd1ab27a43baf20f40f72c948482379aa1"}],"ironic_python_agent/tests/unit/extensions/test_iscsi.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"2bedd6c249f64b014aed856caca24cd8718fc2e5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            storage_object\u003dmock_rtslib.BlockStorageObject.return_value,"},{"line_number":128,"context_line":"            lun\u003d1)"},{"line_number":129,"context_line":"        mock_rtslib.NetworkPortal.assert_called_once_with("},{"line_number":130,"context_line":"            mock_rtslib.TPG.return_value, \u00270.0.0.0\u0027, 3260)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_failed_to_start_iscsi(self, mock_rtslib, mock_dispatch):"},{"line_number":133,"context_line":"        mock_dispatch.return_value \u003d self.fake_dev"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_b6e4880d","line":130,"range":{"start_line":130,"start_character":11,"end_line":130,"end_character":58},"updated":"2016-02-03 08:47:29.000000000","message":"There must be a code which verifies the port other than 3260 if there is a test code for the lines 60-66 in iscsi.py.","commit_id":"0496d884f54e4365a8facc4b00cb19cc9b7d4d82"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"184b7da6d60b83b1915a96a74865383fe1ba7cb6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                              \u0027--targetname\u0027, self.fake_iqn)]"},{"line_number":95,"context_line":"        mock_execute.assert_has_calls(expected)"},{"line_number":96,"context_line":"        mock_dispatch.assert_called_once_with(\u0027get_os_install_device\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"_ORIG_UTILS \u003d iscsi.rtslib_fb.utils"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_80cf747e","line":97,"updated":"2016-02-26 15:13:08.000000000","message":"Missing a test where we create a portal for TGTD","commit_id":"a067fadd1ab27a43baf20f40f72c948482379aa1"}],"releasenotes/notes/add-portal-port-arg-6d4faec2f709c8e9.yaml":[{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"5a1925d6cb6df4a0df8fe8c90b55ee6359c956c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - add new portal_port argument into iscsi.start_iscsi_target"},{"line_number":4,"context_line":"    to support iscsi portal port customization."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a5de9d1_cacf3127","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":7},"updated":"2016-02-02 05:56:03.000000000","message":"nit: s/add/Add","commit_id":"4aa80c3e62b971216fa77e79d01c63ee74d2170d"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"8fa9315f7b1883cda7418a26fbf7133c330d84c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - add new portal_port argument into iscsi.start_iscsi_target"},{"line_number":4,"context_line":"    to support iscsi portal port customization."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a5de9d1_6d2974e5","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":7},"in_reply_to":"7a5de9d1_cacf3127","updated":"2016-02-02 06:46:43.000000000","message":"Done","commit_id":"4aa80c3e62b971216fa77e79d01c63ee74d2170d"}]}