)]}'
{"id":"openstack%2Fironic-python-agent~284347","triplet_id":"openstack%2Fironic-python-agent~master~Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1550604","hashtags":[],"change_id":"Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf","subject":"iscsi: wipe part table before starting the target","status":"MERGED","created":"2016-02-24 18:54:12.000000000","updated":"2016-03-22 19:21:06.000000000","submitted":"2016-03-22 19:21:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":25,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"982ae7053a361fe6f1b35d08ac5a66b57b962f6c","_number":284347,"virtual_id_number":284347,"owner":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2016-03-22 19:21:06.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2016-03-22 17:30:53.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":2,"date":"2016-03-22 17:41:14.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"all":[{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":1,"date":"2016-03-22 17:41:14.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-25 12:42:35.000000000","updated_by":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"reviewer":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"state":"REVIEWER"},{"updated":"2016-03-02 17:06:03.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-03-03 07:14:24.000000000","updated_by":{"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"},"reviewer":{"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"},"state":"REVIEWER"},{"updated":"2016-03-10 05:48:09.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2016-03-18 15:22:40.000000000","updated_by":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"reviewer":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"state":"REVIEWER"},{"updated":"2016-03-22 16:38:26.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2016-03-22 17:30:53.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2016-03-22 17:41:14.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2016-03-22 19:21:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a1aa86a344fd8478201c62f06e67a85b6a880dfa","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-24 18:54:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"65606f6dd7b9c834ff126b2a6b96dc39619fe083","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-02-24 19:00:37.000000000","message":"Patch Set 1: Code-Review-1\n\nHow would this impact rebuild operations and ephemeral partitions where a user may wish to preserve the data across a rebuild.","accounts_in_message":[],"_revision_number":1},{"id":"d2a3d9096666a0302e4f03f2451a6accc71bbbe7","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-24 19:08:03.000000000","message":"Patch Set 1: Code-Review-1\n\nGood question. Is it possible to have a case where ironic-python-agent exposes the disk but it has to be kept unchanged?","accounts_in_message":[],"_revision_number":1},{"id":"beca46c60ac740b95e724affc8eb405aa97cdaba","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-24 20:07:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8e57492a9159c15934937db2875d7eeaeabbfaab","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-24 20:10:51.000000000","message":"Patch Set 1:\n\nJulia, this code (start_iscsi_target\u0027) is only called from do_agent_iscsi_deploy:\n\nhttps://github.com/openstack/ironic/search?utf8\u003d%E2%9C%93\u0026q\u003dstart_iscsi_target","accounts_in_message":[],"_revision_number":1},{"id":"0826a16db10b9f1eada17aec9afc269cf6fd21f6","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-02-24 20:24:15.000000000","message":"Patch Set 2:\n\nCan this be more generic?  As in not iscsi specific?\n\nLike:\n\nhttps://review.openstack.org/#/c/277949/","accounts_in_message":[],"_revision_number":2},{"id":"0147519fc1818011db1ba2b0d0709f4b6245770a","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-24 20:35:49.000000000","message":"Patch Set 2:\n\nThis script is not used when the deployment is driven by ironic-conductor (TripleO).","accounts_in_message":[],"_revision_number":2},{"id":"360c1ef1780f066b22c6c3ebd40f3b7c3e7fa742","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-24 22:05:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/2/check/gate-ironic-python-agent-pep8/d80cb12/ : SUCCESS in 50s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/2/check/gate-ironic-python-agent-docs/c164bbb//doc/build/html/ : SUCCESS in 1m 09s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/2/check/gate-ironic-python-agent-python27/f7d21f6/ : SUCCESS in 56s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/2/check/gate-ironic-python-agent-python34/618c19f/ : SUCCESS in 1m 33s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/82cac70/ : SUCCESS in 42m 03s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/a07a232/ : SUCCESS in 43m 53s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/2/check/gate-ironic-inspector-dsvm-ipa-src-nv/a213300/ : SUCCESS in 44m 15s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/2/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/2347079/ : SUCCESS in 36m 06s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"46be7d52003fa57a69d8b89c12a88e0b41fcd693","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2016-02-25 04:00:59.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI agree we need this fix here as scripts are used only by the agent based drivers. iscsi based drivers use Ironic code and extensions.\nOne question inline.","accounts_in_message":[],"_revision_number":2},{"id":"dd9deb75d8a4c5fc03eabbef7839a86df4f0c23a","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2016-02-25 12:42:35.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1ee0d4351c29436f7bb15d04e99555158670b40f","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-02-25 14:00:06.000000000","message":"Patch Set 2: Code-Review-1\n\nGonéri, I believe it can be the case, and understandably some users wish to do things like image the host via IPA, likely via iscsi, but that would be problematic if the table was automatically wiped prior it being offered up to the conductor.\n\nLooks like the iscsi connection is offered up when a node is in \"DEPLOYWAIT\" and continue_deploy is fired off upon the agent heartbeating.  \"REBUILD\" verb causes the node to go to \"DEPLOYING\", and eventually power cycles the machine which sets the node to \"DEPLOYWAIT\".   The preserve_ephemeral setting is set in the instance_info and is processed in the partition image deployment logic, which is part of continue_deploy, as called by do_agent_iscsi_deploy.   If you look through the nova driver code for rebuild https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1089 you can eventually see that it is saved in instance_info.","accounts_in_message":[],"_revision_number":2},{"id":"e7076fc94664b22c741faf2b7da1e5abc653a8c7","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-25 14:25:32.000000000","message":"Patch Set 2:\n\nAgain thank you all for these fast reviews.\n\nRegarding the sgdisk, this is an example where the sgdisk -Z is not enough and grub won\u0027t touch the device because there is still some\ntrace of an ancient system.\nhttp://paste.openstack.org/show/488186/\n\nI guess, I probably can just wipe 1MB instead of 10MB, if this is something wanted, I can retry my patch with that.\n\nOnly the system disk is wiped here (device \u003d hardware.dispatch_to_managers(\u0027get_os_install_device\u0027)). From my understanding a nova rebuild should with --preserve-ephemeral should rewrite the system disk and I don\u0027t think we can have an ephemeral system disk.","accounts_in_message":[],"_revision_number":2},{"id":"7227331f4828c0eac82e13d1c338f4567a750a3b","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-25 14:29:55.000000000","message":"Patch Set 2:\n\nThis is the message I guess without the patch:\nhttp://paste.openstack.org/show/488191/\n\nIf I just call sgdisk -Z I still get this one:\nhttp://paste.openstack.org/show/488189/","accounts_in_message":[],"_revision_number":2},{"id":"0b4279015ab5a9a2c44d5596951b86ce0ab1fbd1","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-02-25 14:48:41.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"c3da33f3df8d84fb2ce4639e1ff06ad2cf33f177","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-25 14:58:33.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f377b2533bc6e608f545e3820700928dac463800","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-27 01:46:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d367cc63024fbbaaccda3de6c2817bb31698b150","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-27 01:51:16.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"bb53e7133bd5780b054b02345cc216e56e33fa28","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-27 03:24:46.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/4/check/gate-ironic-python-agent-pep8/9442d90/ : SUCCESS in 47s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/4/check/gate-ironic-python-agent-docs/2930c0e//doc/build/html/ : SUCCESS in 59s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/4/check/gate-ironic-python-agent-python27/ff56040/ : SUCCESS in 47s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/4/check/gate-ironic-python-agent-python34/c281057/ : SUCCESS in 1m 20s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/4/check/gate-ironic-python-agent-requirements/9daf4e7/ : Incompatible requirement found; see http://docs.openstack.org/developer/requirements/ in 25s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/4/check/gate-ironic-python-agent-releasenotes/1fc8155//releasenotes/build/html/ : SUCCESS in 48s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/4/check/gate-tempest-dsvm-ironic-agent_ssh-src/701beb5/ : SUCCESS in 29m 53s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/4/check/gate-tempest-dsvm-ironic-pxe_ipa-src/1f4536f/ : SUCCESS in 43m 44s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/4/check/gate-ironic-inspector-dsvm-ipa-src-nv/5907f00/ : FAILURE in 1h 20m 11s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/4/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/12e2efe/ : SUCCESS in 33m 51s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"97b531f2bf45007f400bc7c3a9ee48b9af712294","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-27 04:04:54.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"d53790eaf80fbbb281078bff005dab9029a7c228","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-27 04:39:42.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/5/check/gate-ironic-python-agent-pep8/644cd60/ : SUCCESS in 1m 06s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/5/check/gate-ironic-python-agent-docs/4154a5d//doc/build/html/ : SUCCESS in 2m 57s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/5/check/gate-ironic-python-agent-python27/ecee17f/ : SUCCESS in 1m 19s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/5/check/gate-ironic-python-agent-python34/fc3c7e1/ : SUCCESS in 3m 18s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/5/check/gate-ironic-python-agent-requirements/594307e/ : Incompatible requirement found; see http://docs.openstack.org/developer/requirements/ in 1m 27s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/5/check/gate-ironic-python-agent-releasenotes/97f61d2//releasenotes/build/html/ : SUCCESS in 54s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/5/check/gate-tempest-dsvm-ironic-agent_ssh-src/13d3c78/ : SUCCESS in 31m 54s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/5/check/gate-tempest-dsvm-ironic-pxe_ipa-src/ab98497/ : SUCCESS in 33m 26s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/5/check/gate-ironic-inspector-dsvm-ipa-src-nv/2670033/ : SUCCESS in 31m 00s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/5/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/73e5d0e/ : SUCCESS in 34m 40s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"c0f7daa783163e3482260a861c6877eb5d87801b","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-01 15:19:31.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)\n\nThanks Gonerí,\n\nProblem on the requirements.txt other than that it lgtm","accounts_in_message":[],"_revision_number":5},{"id":"92010d6d9e194e4570c7ef32398eb1822c9bfc4c","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-01 16:42:39.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"433b0ff40edb9def324db1f69777c36b4f0fa909","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-01 18:31:06.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/6/check/gate-ironic-python-agent-pep8/9b7ac1f/ : SUCCESS in 51s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/6/check/gate-ironic-python-agent-docs/5011f32//doc/build/html/ : SUCCESS in 1m 15s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/6/check/gate-ironic-python-agent-python27/fc7ab2c/ : SUCCESS in 1m 07s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/6/check/gate-ironic-python-agent-python34/b8dc8ee/ : SUCCESS in 1m 23s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/6/check/gate-ironic-python-agent-requirements/0830403/ : SUCCESS in 29s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/6/check/gate-ironic-python-agent-releasenotes/2ea7c75//releasenotes/build/html/ : SUCCESS in 45s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/6/check/gate-tempest-dsvm-ironic-agent_ssh-src/91dc1c9/ : SUCCESS in 48m 35s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/6/check/gate-tempest-dsvm-ironic-pxe_ipa-src/2b8ee0c/ : SUCCESS in 40m 25s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/6/check/gate-ironic-inspector-dsvm-ipa-src-nv/fee1ee7/ : SUCCESS in 46m 58s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/6/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/05dfe6d/ : SUCCESS in 45m 18s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"6b41dd92c2fb59cbbc1d95855c24eea2d62f2bd4","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-03-02 08:51:58.000000000","message":"Patch Set 6: Code-Review-1\n\n(1 comment)\n\nOne small issue, otherwise looks good","accounts_in_message":[],"_revision_number":6},{"id":"27af982fccd4c73db13a5602fe49760f3ed333bf","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-02 15:52:45.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"bc004a96d81c9467b9fc33641c5c2d426afb7c15","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-02 15:53:33.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"5087a9f7200fd8535d2704c06eff876584c53fee","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-03-02 16:09:22.000000000","message":"Patch Set 7: Code-Review-1\n\n(3 comments)\n\nI am sorry, I was not reviewing the tests thoroughly enough. A couple of comments there as well.","accounts_in_message":[],"_revision_number":7},{"id":"ada3d5b11b04a08c496bb9343e98a1c27e86de26","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-02 17:01:13.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"8c367ed164984860cf8d2daac013d4de1b4a26ec","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-02 17:02:23.000000000","message":"Patch Set 7:\n\nDmitry, indeed the previous test was a bit messy. Does the new patch match your expectations?","accounts_in_message":[],"_revision_number":7},{"id":"385a8f788f809a6eb589d493de45f6c3bab8a01f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-03-02 17:06:03.000000000","message":"Patch Set 8: Code-Review+2\n\nthanks","accounts_in_message":[],"_revision_number":8},{"id":"7b2c9a863c2872c79e0e67e38bd4d1ee9763f97e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-03-02 17:06:20.000000000","message":"Patch Set 8:\n\nhmm, we might need a release note as described in http://docs.openstack.org/developer/ironic/dev/faq.html#create-a-new-release-note","accounts_in_message":[],"_revision_number":8},{"id":"7f551c581d14f21ecc28297e95d1e8e563740c8b","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-02 17:10:28.000000000","message":"Patch Set 8: Code-Review+2\n\nThanks,\n\nVery straight forward patch, not approving because we need people from other companies to also review it","accounts_in_message":[],"_revision_number":8},{"id":"2185b2ac234bd8f81c7139cdbf4a7f0550051134","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 19:07:56.000000000","message":"Patch Set 8: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/8/check/gate-ironic-python-agent-pep8/f5bcd54/ : FAILURE in 42s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/8/check/gate-ironic-python-agent-docs/08f896c//doc/build/html/ : SUCCESS in 1m 08s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/8/check/gate-ironic-python-agent-python27/eca66ff/ : SUCCESS in 48s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/8/check/gate-ironic-python-agent-python34/311a11c/ : SUCCESS in 1m 31s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/8/check/gate-ironic-python-agent-requirements/ebdf114/ : SUCCESS in 2m 28s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/8/check/gate-ironic-python-agent-releasenotes/1733d87//releasenotes/build/html/ : SUCCESS in 51s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/8/check/gate-tempest-dsvm-ironic-agent_ssh-src/0519b71/ : SUCCESS in 35m 49s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/8/check/gate-tempest-dsvm-ironic-pxe_ipa-src/bdb2bae/ : SUCCESS in 48m 24s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/8/check/gate-ironic-inspector-dsvm-ipa-src-nv/f7dc635/ : FAILURE in 52m 37s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/8/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/6332175/ : SUCCESS in 37m 57s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"356df6a77991b3a6588217c5dd7feae0a33378ab","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-02 19:23:57.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"5327721fc07be98229a402b3be03eabfb61deedd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 21:19:35.000000000","message":"Patch Set 9: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-pep8/457acc1/ : SUCCESS in 53s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/9/check/gate-ironic-python-agent-docs/45ac49e//doc/build/html/ : SUCCESS in 1m 17s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-python27/e6c7cf2/ : SUCCESS in 1m 08s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-python34/5dd69f2/ : SUCCESS in 3m 18s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-requirements/bcbc111/ : SUCCESS in 2m 19s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/9/check/gate-ironic-python-agent-releasenotes/3aa6380//releasenotes/build/html/ : SUCCESS in 32s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/9/check/gate-tempest-dsvm-ironic-agent_ssh-src/99110e7/ : FAILURE in 33m 29s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/9/check/gate-tempest-dsvm-ironic-pxe_ipa-src/be25eaf/ : SUCCESS in 37m 37s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/9/check/gate-ironic-inspector-dsvm-ipa-src-nv/520a1ed/ : SUCCESS in 38m 06s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/9/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/337eb56/ : SUCCESS in 39m 10s (non-voting)","accounts_in_message":[],"_revision_number":9},{"id":"2bd27c271cfe0ffd538975148176186f0811c2a3","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-02 22:14:04.000000000","message":"Patch Set 9:\n\nrecheck","accounts_in_message":[],"_revision_number":9},{"id":"4813e29b934c199fc422aab9a2b0c011cd70212a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 23:52:01.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-pep8/dde3cae/ : SUCCESS in 49s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/9/check/gate-ironic-python-agent-docs/4dfde89//doc/build/html/ : SUCCESS in 1m 18s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-python27/d31adfb/ : SUCCESS in 1m 00s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-python34/d21d2dd/ : SUCCESS in 1m 23s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/9/check/gate-ironic-python-agent-requirements/ff09443/ : SUCCESS in 19s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/9/check/gate-ironic-python-agent-releasenotes/2910c08//releasenotes/build/html/ : SUCCESS in 45s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/9/check/gate-tempest-dsvm-ironic-agent_ssh-src/d1448e9/ : SUCCESS in 36m 29s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/9/check/gate-tempest-dsvm-ironic-pxe_ipa-src/a2e6fe1/ : SUCCESS in 43m 23s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/9/check/gate-ironic-inspector-dsvm-ipa-src-nv/be8a4d1/ : SUCCESS in 41m 01s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/9/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/0b931eb/ : FAILURE in 59m 54s (non-voting)","accounts_in_message":[],"_revision_number":9},{"id":"8689d469b79525655b11b12cc41f54aaee77eec7","author":{"_account_id":20683,"name":"Venkata Mahesh Chinta","email":"venkata.mahesh.chinta@ericsson.com","username":"MaheshChinta"},"date":"2016-03-03 07:14:24.000000000","message":"Patch Set 9: Code-Review+1","accounts_in_message":[],"_revision_number":9},{"id":"830f5664ba83f67165d08150418b1e25914c67a2","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2016-03-03 07:41:15.000000000","message":"Patch Set 9: Code-Review-1\n\nThank you. Looks good. Can you please add release notes for the same.","accounts_in_message":[],"_revision_number":9},{"id":"7ecd42b29774ccf1390ce47798e636d6e82794cd","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-03-03 13:58:04.000000000","message":"Patch Set 9: Code-Review-1\n\nI\u0027m still opposed to this, given I\u0027ve had to actually get machines out of failed rebuilds in the past, and destroying the metadata should be a step that is performed only when everything is clear to proceed, however https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L338 is buried inside the logic which will cause a rebuild to abort prior to any changes having been made.  With this change, the machine cannot be recovered without someone intimately familiar with how ironic works.   If everything was pre-checked, I would have less of a concern over this, however destroying metadata before any validation on the target side can take place also feels wrong to me, even though we don\u0027t presently do that level of verification for rebuilds.","accounts_in_message":[],"_revision_number":9},{"id":"7b76c5d7493da4ae0871bdbb986d0f3d2ef9ba44","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-03 15:23:25.000000000","message":"Patch Set 9:\n\nThanks Julia,\n\nIs it ok if I add a new function, \u0027wipe_root_disk_metadata\u0027 just to wipe the metadata?","accounts_in_message":[],"_revision_number":9},{"id":"2b9a8352c8efed44547b3b9a90a0e52cc4a6830b","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-03 16:19:44.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"93e97716558be9acc0128266d677446028d98c4f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 17:37:24.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/10/check/gate-ironic-python-agent-pep8/91d3a05/ : SUCCESS in 54s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/10/check/gate-ironic-python-agent-docs/c13034b//doc/build/html/ : SUCCESS in 1m 09s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/10/check/gate-ironic-python-agent-python27/2fcc329/ : SUCCESS in 51s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/10/check/gate-ironic-python-agent-python34/341c233/ : SUCCESS in 1m 23s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/10/check/gate-ironic-python-agent-requirements/602a991/ : SUCCESS in 20s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/10/check/gate-ironic-python-agent-releasenotes/e157767//releasenotes/build/html/ : SUCCESS in 54s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/10/check/gate-tempest-dsvm-ironic-agent_ssh-src/62f92e5/ : SUCCESS in 46m 29s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/10/check/gate-tempest-dsvm-ironic-pxe_ipa-src/974b8a4/ : SUCCESS in 42m 50s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/10/check/gate-ironic-inspector-dsvm-ipa-src-nv/59ea787/ : SUCCESS in 1h 02m 45s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/10/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/a90cc09/ : SUCCESS in 42m 49s (non-voting)","accounts_in_message":[],"_revision_number":10},{"id":"fe46be829c4f3982f5a6629a959a3881883949c6","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-03 18:44:36.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"89f220bc04183b5d94c04d05e2994e063f698367","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 19:51:51.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/11/check/gate-ironic-python-agent-pep8/0bd46a5/ : SUCCESS in 44s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/11/check/gate-ironic-python-agent-docs/dfc5e28//doc/build/html/ : SUCCESS in 1m 05s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/11/check/gate-ironic-python-agent-python27/61c3b19/ : SUCCESS in 59s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/11/check/gate-ironic-python-agent-python34/27a8c1b/ : SUCCESS in 1m 34s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/11/check/gate-ironic-python-agent-requirements/dd8bf86/ : SUCCESS in 2m 25s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/11/check/gate-ironic-python-agent-releasenotes/5e146a3//releasenotes/build/html/ : SUCCESS in 54s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/11/check/gate-tempest-dsvm-ironic-agent_ssh-src/5c4996e/ : SUCCESS in 46m 29s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/11/check/gate-tempest-dsvm-ironic-pxe_ipa-src/5d4de73/ : SUCCESS in 40m 15s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/11/check/gate-ironic-inspector-dsvm-ipa-src-nv/680a6f7/ : SUCCESS in 35m 55s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/11/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/30bac6e/ : SUCCESS in 52m 27s (non-voting)","accounts_in_message":[],"_revision_number":11},{"id":"796113c409bb1e13b19a88ac58193538f50a4954","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-08 17:11:00.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"846ec1b68de3e664ca2d39f58ec313860f9c03d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-08 17:52:08.000000000","message":"Patch Set 12: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/12/check/gate-ironic-python-agent-pep8/fa407fe/ : SUCCESS in 3m 40s\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/12/check/gate-ironic-python-agent-docs/167f580//doc/build/html/ : SUCCESS in 4m 59s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/12/check/gate-ironic-python-agent-python27/4885207/ : SUCCESS in 3m 31s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/12/check/gate-ironic-python-agent-python34/b075a23/ : SUCCESS in 4m 15s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/12/check/gate-ironic-python-agent-requirements/a4796f7/ : Incompatible requirement found; see http://docs.openstack.org/developer/requirements/ in 4m 02s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/12/check/gate-ironic-python-agent-releasenotes/86892d9//releasenotes/build/html/ : SUCCESS in 34s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/12/check/gate-tempest-dsvm-ironic-agent_ssh-src/6dd0d9d/ : SUCCESS in 40m 13s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/12/check/gate-tempest-dsvm-ironic-pxe_ipa-src/73ec739/ : SUCCESS in 40m 42s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/12/check/gate-ironic-inspector-dsvm-ipa-src-nv/13665ed/ : SUCCESS in 40m 48s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/12/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/8ff2c47/ : SUCCESS in 39m 27s (non-voting)","accounts_in_message":[],"_revision_number":12},{"id":"6b483b133beedb304a0ecc109f56076b576798b2","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2016-03-10 05:48:09.000000000","message":"Patch Set 12: Code-Review-1\n\n(1 comment)\n\nIronic-lib version has changed. Might be it causing the jenkins failure. It has changed to \u0027ironic-lib\u003e\u003d1.1.0 # Apache-2.0\u0027 https://github.com/openstack/requirements/blob/master/global-requirements.txt","accounts_in_message":[],"_revision_number":12},{"id":"fe6378e1de59e388713836dbc2b48e738303d123","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-10 19:53:41.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"1e735dc4e9af36febb75c878b22b975f571d3604","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-10 19:54:10.000000000","message":"Patch Set 12:\n\nthanks Shivanand","accounts_in_message":[],"_revision_number":12},{"id":"0a88448aa9b210d81751f420b0bd51c8e2abe368","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-18 14:41:50.000000000","message":"Patch Set 13:\n\nrecheck","accounts_in_message":[],"_revision_number":13},{"id":"3e032b6eec314ff6407f278e6f7ce579b7a2b71d","author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"date":"2016-03-18 15:22:40.000000000","message":"Patch Set 13: Code-Review-1\n\n(1 comment)\n\nnote that requirements.txt change has already landed.","accounts_in_message":[],"_revision_number":13},{"id":"fe15f819259d07de194e4cccadcc59d3748e5e95","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-18 15:34:29.000000000","message":"Patch Set 13: Code-Review-1\n\n(1 comment)\n\nThanks for the patch Goneri,\n\nI\u0027m a little confused about what are the directions here. I see Julia\u0027s concern on patch-set #9 (and agree with that). But separating it in a new command that will be called by Ironic prior to start_iscsi_target() will have the same effect as patch-set #9 no ? (but worse because that\u0027s one more round of requests)\n\nIf the idea is to make wipping the device prior to start iscsi optional, I think we can make it by adding a parameter to the start_iscsi_target() method and avoiding an extra request.","accounts_in_message":[],"_revision_number":13},{"id":"6390d53bf844f90ddfa3dd6559b5acf22ca3839f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 15:45:40.000000000","message":"Patch Set 13: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/13/check/gate-ironic-python-agent-docs/cd70bcf//doc/build/html/ : SUCCESS in 2m 37s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/13/check/gate-ironic-python-agent-pep8/62afa5c/ : SUCCESS in 1m 51s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/13/check/gate-ironic-python-agent-python27/e0f06e1/ : SUCCESS in 3m 17s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/13/check/gate-ironic-python-agent-python34/c16a824/ : SUCCESS in 3m 32s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/13/check/gate-ironic-python-agent-requirements/8141323/ : SUCCESS in 1m 19s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/47/284347/13/check/gate-ironic-python-agent-releasenotes/e16be05//releasenotes/build/html/ : SUCCESS in 1m 30s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/13/check/gate-tempest-dsvm-ironic-agent_ssh-src/e077158/ : SUCCESS in 59m 08s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/13/check/gate-tempest-dsvm-ironic-pxe_ipa-src/a82a055/ : SUCCESS in 42m 51s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/13/check/gate-ironic-inspector-dsvm-ipa-src-nv/efee5cd/ : SUCCESS in 45m 17s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/13/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/1e5617b/ : SUCCESS in 26m 30s (non-voting)","accounts_in_message":[],"_revision_number":13},{"id":"c3295bc0d9cc73e81f0423a875a76aa181a2fc06","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-18 21:14:50.000000000","message":"Uploaded patch set 14.","accounts_in_message":[],"_revision_number":14},{"id":"bf7858a0cbd7335aac749cfd1db4eec8da501437","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-18 21:23:05.000000000","message":"Patch Set 14:\n\nAs decided on IRC today, I added a parameter (wipe_first) to enable/disable the drive clean up.","accounts_in_message":[],"_revision_number":14},{"id":"418c11d713c330a554bc4eeebae6e27bcddea9cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 21:47:00.000000000","message":"Patch Set 14: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs http://logs.openstack.org/47/284347/14/check/gate-ironic-python-agent-docs/3f92f87/ : FAILURE in 1m 42s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/14/check/gate-ironic-python-agent-pep8/85e52a8/ : FAILURE in 1m 19s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/14/check/gate-ironic-python-agent-python27/4eb749d/ : FAILURE in 1m 56s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/14/check/gate-ironic-python-agent-python34/15e6f5e/ : FAILURE in 1m 50s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/14/check/gate-ironic-python-agent-requirements/a88862e/ : Incompatible requirement found; see http://docs.openstack.org/developer/requirements/ in 1m 20s\n- gate-ironic-python-agent-releasenotes http://logs.openstack.org/47/284347/14/check/gate-ironic-python-agent-releasenotes/f7b43da/ : FAILURE in 1m 45s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/14/check/gate-tempest-dsvm-ironic-agent_ssh-src/fc75f30/ : FAILURE in 27m 40s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/14/check/gate-tempest-dsvm-ironic-pxe_ipa-src/654a3e9/ : FAILURE in 26m 02s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/14/check/gate-ironic-inspector-dsvm-ipa-src-nv/20d541e/ : FAILURE in 27m 50s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/14/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/b3384cc/ : FAILURE in 24m 21s (non-voting)","accounts_in_message":[],"_revision_number":14},{"id":"eb851b2a7ff26ccd42931029449bd3568ad913c4","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-19 22:12:11.000000000","message":"Uploaded patch set 15.","accounts_in_message":[],"_revision_number":15},{"id":"b0a22c2ee374ca423dd56789130328d114be0414","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-03-21 12:27:59.000000000","message":"Patch Set 15:\n\nrecheck","accounts_in_message":[],"_revision_number":15},{"id":"d8940f597c3d45fc045d11b7b49580454a88035f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-21 13:08:52.000000000","message":"Patch Set 15: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs http://logs.openstack.org/47/284347/15/check/gate-ironic-python-agent-docs/8cf8c0f/ : FAILURE in 1m 40s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/15/check/gate-ironic-python-agent-pep8/8a42b49/ : FAILURE in 1m 23s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/15/check/gate-ironic-python-agent-python27/9239888/ : FAILURE in 1m 48s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/15/check/gate-ironic-python-agent-python34/911892a/ : FAILURE in 1m 44s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/47/284347/15/check/gate-ironic-python-agent-requirements/1411b25/ : Incompatible requirement found; see http://docs.openstack.org/developer/requirements/ in 5m 41s\n- gate-ironic-python-agent-releasenotes http://logs.openstack.org/47/284347/15/check/gate-ironic-python-agent-releasenotes/6be4efd/ : FAILURE in 1m 09s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/15/check/gate-tempest-dsvm-ironic-agent_ssh-src/636c5a5/ : FAILURE in 27m 50s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/15/check/gate-tempest-dsvm-ironic-pxe_ipa-src/1e87c78/ : FAILURE in 35m 44s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/15/check/gate-ironic-inspector-dsvm-ipa-src-nv/8e9954d/ : FAILURE in 27m 43s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/15/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/a0b71c9/ : FAILURE in 15m 43s (non-voting)","accounts_in_message":[],"_revision_number":15},{"id":"3ad33598142264bdbd04cfaaaff379e515995aa4","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-03-21 13:12:09.000000000","message":"Patch Set 15: Code-Review-1\n\n(1 comment)\n\nPartial review, Duplicate requirement causing change to fail testing.","accounts_in_message":[],"_revision_number":15},{"id":"c474a0ff8d85e992d029479e57107255b180cf7c","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-21 22:45:24.000000000","message":"Uploaded patch set 16.","accounts_in_message":[],"_revision_number":16},{"id":"3e9cdf908973e508eaf6a7fe5adec1b3f8de3b4c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 00:36:43.000000000","message":"Patch Set 16: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/16/check/gate-ironic-python-agent-docs/7fc9b58//doc/build/html/ : SUCCESS in 2m 26s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/16/check/gate-ironic-python-agent-pep8/dfa4f6f/ : SUCCESS in 1m 33s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/16/check/gate-ironic-python-agent-python27/d1568f0/ : SUCCESS in 1m 38s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/16/check/gate-ironic-python-agent-python34/33c6787/ : SUCCESS in 4m 24s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/16/check/gate-tempest-dsvm-ironic-agent_ssh-src/800e3b4/ : SUCCESS in 45m 37s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/16/check/gate-tempest-dsvm-ironic-pxe_ipa-src/c3428be/ : SUCCESS in 47m 27s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/16/check/gate-ironic-inspector-dsvm-ipa-src-nv/bb15e47/ : SUCCESS in 27m 25s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/16/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/ff4095e/ : SUCCESS in 26m 46s (non-voting)","accounts_in_message":[],"_revision_number":16},{"id":"3f334e00fc31dbf49cb8d44ec14a2930ba94421f","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 12:39:56.000000000","message":"Patch Set 15:\n\n(1 comment)","accounts_in_message":[],"_revision_number":15},{"id":"a4250a65fb106afd1656318dc7c41aef0d7db7f8","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-22 12:46:07.000000000","message":"Patch Set 16: Code-Review+1\n\n(1 comment)\n\nThanks Gonerí, there\u0027s a nit inline for pep8. Other than that it LGTM (not sure it worth a -1 tho :-/)","accounts_in_message":[],"_revision_number":16},{"id":"3bc34cf0699da5fae043f68648f762ed2f25237b","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 12:55:54.000000000","message":"Uploaded patch set 17.","accounts_in_message":[],"_revision_number":17},{"id":"f058b64591df3a4cda3093537c9b1d77e71e96fd","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 12:56:40.000000000","message":"Patch Set 16:\n\n(1 comment)","accounts_in_message":[],"_revision_number":16},{"id":"7f7ac66be984e2c88d8f0a871fee940ca4a30a8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 13:45:14.000000000","message":"Patch Set 17: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/17/check/gate-ironic-python-agent-docs/66d1455//doc/build/html/ : SUCCESS in 3m 57s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/17/check/gate-ironic-python-agent-pep8/bbe92c1/ : SUCCESS in 3m 07s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/17/check/gate-ironic-python-agent-python27/dde2247/ : SUCCESS in 1m 41s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/17/check/gate-ironic-python-agent-python34/f5dee2a/ : SUCCESS in 4m 22s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/17/check/gate-tempest-dsvm-ironic-agent_ssh-src/ed42016/ : SUCCESS in 45m 31s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/17/check/gate-tempest-dsvm-ironic-pxe_ipa-src/217d5a4/ : SUCCESS in 26m 23s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/17/check/gate-ironic-inspector-dsvm-ipa-src-nv/df74c0a/ : SUCCESS in 26m 18s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/17/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/1f9bb28/ : SUCCESS in 26m 51s (non-voting)","accounts_in_message":[],"_revision_number":17},{"id":"8fc3f97915f06e7fa91ebafadbe7b4a7680fba08","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-03-22 14:00:42.000000000","message":"Patch Set 17: Code-Review+1\n\n(2 comments)\n\nTwo minor nits/thoughts in-line, not worth a -1\n\nOtherwise LGTM.","accounts_in_message":[],"_revision_number":17},{"id":"6d54d9e4fc0964ca238e474b884ed423d0ea80b6","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 15:39:58.000000000","message":"Uploaded patch set 18.","accounts_in_message":[],"_revision_number":18},{"id":"2f6487c9dc26e81c12beb211d64f76d8251337ab","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 15:40:45.000000000","message":"Patch Set 17:\n\n(2 comments)","accounts_in_message":[],"_revision_number":17},{"id":"a098dfc9e400a7d3bc18804228b00e56f8059d58","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-03-22 16:31:24.000000000","message":"Patch Set 18: Code-Review+1\n\nThank you!","accounts_in_message":[],"_revision_number":18},{"id":"c89e18d9892fd54111be4bedf5a677c783c15a04","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-22 16:33:50.000000000","message":"Patch Set 18: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":18},{"id":"f0fab95896b0e4d84371a2851ae463b436a2c095","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-22 16:35:00.000000000","message":"Patch Set 18: Workflow-1\n\nI will put a new patch-set fixing the nits","accounts_in_message":[],"_revision_number":18},{"id":"0196533016582e47fd47472e7fbe4a38e7e9ad0c","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-22 16:35:50.000000000","message":"Uploaded patch set 19.","accounts_in_message":[],"_revision_number":19},{"id":"d8098c10a8b8a8ccc3ea0590728aaefa1bc68e76","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-22 16:36:20.000000000","message":"Patch Set 19: Code-Review+2\n\n(just fixed the nits in a docstring)\n\nThanks for the patch Goneri","accounts_in_message":[],"_revision_number":19},{"id":"600310a24fb7671673c0fd4aefe0a5b13e6454ae","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-03-22 16:38:26.000000000","message":"Patch Set 19: Code-Review+1","accounts_in_message":[],"_revision_number":19},{"id":"e774ba858ad8e9cbee4f15d7a777d190f6e9e18d","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-03-22 17:11:34.000000000","message":"Patch Set 19: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":19},{"id":"0e90465cea7ed71fa8405657077d6311110879dd","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 17:11:47.000000000","message":"Uploaded patch set 20.","accounts_in_message":[],"_revision_number":20},{"id":"05fb9b3c3ca86d97a8997a415a3cf851f01d07df","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 17:12:30.000000000","message":"Patch Set 19:\n\noops, sorry for the ugly typo in the docstring.","accounts_in_message":[],"_revision_number":19},{"id":"922763a403d792a3c50c2d561c673db353810c57","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-03-22 17:28:41.000000000","message":"Uploaded patch set 21.","accounts_in_message":[],"_revision_number":21},{"id":"9769c5813b7245f205fbaf29061b0de3d779897d","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-03-22 17:30:53.000000000","message":"Patch Set 21: Code-Review+2","accounts_in_message":[],"_revision_number":21},{"id":"996b2944076900b2088bac9cf8ea8e06b7c82115","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-22 17:41:14.000000000","message":"Patch Set 21: Code-Review+2 Workflow+1\n\nThanks Gonéri","accounts_in_message":[],"_revision_number":21},{"id":"71a28967caf1be67c195f706a15e8bb056840521","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 18:36:24.000000000","message":"Patch Set 21: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/21/check/gate-ironic-python-agent-docs/39ebc2b//doc/build/html/ : SUCCESS in 2m 29s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/21/check/gate-ironic-python-agent-pep8/c9ccd19/ : SUCCESS in 2m 18s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/21/check/gate-ironic-python-agent-python27/c5466f5/ : SUCCESS in 2m 17s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/21/check/gate-ironic-python-agent-python34/28b5c02/ : SUCCESS in 3m 01s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/21/check/gate-tempest-dsvm-ironic-agent_ssh-src/3642173/ : SUCCESS in 44m 28s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/21/check/gate-tempest-dsvm-ironic-pxe_ipa-src/b499398/ : SUCCESS in 43m 17s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/47/284347/21/check/gate-ironic-inspector-dsvm-ipa-src-nv/86fce70/ : SUCCESS in 27m 21s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/47/284347/21/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/e371ae1/ : SUCCESS in 42m 17s (non-voting)","accounts_in_message":[],"_revision_number":21},{"id":"d2a71f5a5693d9ebc33e9ebbd3fb25002639f711","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 18:36:30.000000000","message":"Patch Set 21: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":21},{"id":"fea7dee907e39d176adbb63603f46e757edcdc29","date":"2016-03-22 19:21:06.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":21},{"id":"1003d6affa1aa9045a195c3cf8b6ee9fe8da519e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 19:21:06.000000000","message":"Patch Set 21: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/47/284347/21/gate/gate-ironic-python-agent-docs/22785c7//doc/build/html/ : SUCCESS in 2m 31s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/47/284347/21/gate/gate-ironic-python-agent-pep8/4d5321c/ : SUCCESS in 1m 33s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/47/284347/21/gate/gate-ironic-python-agent-python27/8af6842/ : SUCCESS in 2m 44s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/47/284347/21/gate/gate-ironic-python-agent-python34/52bfc9f/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/47/284347/21/gate/gate-tempest-dsvm-ironic-agent_ssh-src/2957ee8/ : SUCCESS in 43m 45s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/47/284347/21/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/52afacb/ : SUCCESS in 25m 40s","accounts_in_message":[],"_revision_number":21}],"current_revision_number":21,"current_revision":"0b1f01db9474fb7630d616fab4711fefaea2bce0","revisions":{"a4091a1faedf0fdfdcb40a549ccc53bbc3bef34d":{"kind":"REWORK","_number":1,"created":"2016-02-24 18:54:12.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/1"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:54:11.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a4091a1faedf0fdfdcb40a549ccc53bbc3bef34d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a4091a1faedf0fdfdcb40a549ccc53bbc3bef34d"}]},"branch":"refs/heads/master"},"8192f0d107d6fbe702f295cd2f7f0b5383b63640":{"kind":"REWORK","_number":2,"created":"2016-02-24 20:07:30.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/2"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 20:07:24.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8192f0d107d6fbe702f295cd2f7f0b5383b63640"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8192f0d107d6fbe702f295cd2f7f0b5383b63640"}]},"branch":"refs/heads/master"},"90a9ba31c865ac3875c58149a30f74e5bacc01e0":{"kind":"REWORK","_number":3,"created":"2016-02-27 01:46:00.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/3"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-25 19:48:42.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/90a9ba31c865ac3875c58149a30f74e5bacc01e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/90a9ba31c865ac3875c58149a30f74e5bacc01e0"}]},"branch":"refs/heads/master"},"03d6555d936db5d117e960c29c42b3cd829545bb":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2016-02-27 01:51:16.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/4"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-27 01:46:14.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/03d6555d936db5d117e960c29c42b3cd829545bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/03d6555d936db5d117e960c29c42b3cd829545bb"}]},"branch":"refs/heads/master"},"3c840300500aed2350c9b7bd8887087b4e84b97e":{"kind":"REWORK","_number":5,"created":"2016-02-27 04:04:54.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/5"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-27 03:47:08.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3c840300500aed2350c9b7bd8887087b4e84b97e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3c840300500aed2350c9b7bd8887087b4e84b97e"}]},"branch":"refs/heads/master"},"32184ea166c63936edbb9ab5ac4a511cefb4ad5f":{"kind":"REWORK","_number":6,"created":"2016-03-01 16:42:39.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/6"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-01 16:42:33.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/32184ea166c63936edbb9ab5ac4a511cefb4ad5f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/32184ea166c63936edbb9ab5ac4a511cefb4ad5f"}]},"branch":"refs/heads/master"},"16b9f0768d326f3b67d4e51f1236e8ab9264dfb5":{"kind":"REWORK","_number":7,"created":"2016-03-02 15:53:33.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/7"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-02 15:53:22.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/16b9f0768d326f3b67d4e51f1236e8ab9264dfb5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/16b9f0768d326f3b67d4e51f1236e8ab9264dfb5"}]},"branch":"refs/heads/master"},"60ac976ff8cf8ee6fe8ecb0ddb7fe89246bf493b":{"kind":"REWORK","_number":8,"created":"2016-03-02 17:01:13.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/8"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-02 17:00:57.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/60ac976ff8cf8ee6fe8ecb0ddb7fe89246bf493b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/60ac976ff8cf8ee6fe8ecb0ddb7fe89246bf493b"}]},"branch":"refs/heads/master"},"4cab520bc89f541147323475f582ac99908b84a3":{"kind":"REWORK","_number":9,"created":"2016-03-02 19:23:57.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/9"}}},"commit":{"parents":[{"commit":"2e1b6cd0ed444b9f2accbfeae52f5240a0798912","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2e1b6cd0ed444b9f2accbfeae52f5240a0798912"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-02 19:23:51.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4cab520bc89f541147323475f582ac99908b84a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4cab520bc89f541147323475f582ac99908b84a3"}]},"branch":"refs/heads/master"},"a7a04e04918f88c0e23156910aacc59bcf12aaa6":{"kind":"REWORK","_number":10,"created":"2016-03-03 16:19:44.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/10"}}},"commit":{"parents":[{"commit":"1971ad7023389c6b9fa52c9837676419d7f53f97","subject":"Merge \"Reduced restriction of parsing for dmidecode output\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1971ad7023389c6b9fa52c9837676419d7f53f97"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-03 16:16:13.000000000","tz":-300},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nInstead of the initial patchset, we now add a \u0027wipe_root_device_metadata\u0027\ndedicated to the disk metadata cleanup. This to preserve the initial\nbehavior of \u0027start_iscsi_target\u0027.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a7a04e04918f88c0e23156910aacc59bcf12aaa6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a7a04e04918f88c0e23156910aacc59bcf12aaa6"}]},"branch":"refs/heads/master"},"c963eea5af26b4564257f1cb8c27cbb86584ad08":{"kind":"REWORK","_number":11,"created":"2016-03-03 18:44:36.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/11"}}},"commit":{"parents":[{"commit":"1971ad7023389c6b9fa52c9837676419d7f53f97","subject":"Merge \"Reduced restriction of parsing for dmidecode output\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1971ad7023389c6b9fa52c9837676419d7f53f97"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-03 16:34:47.000000000","tz":-300},"subject":"image: add the ability to clean disk metadata","message":"image: add the ability to clean disk metadata\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nInstead of the initial patchset, we now add a \u0027wipe_root_device_metadata\u0027\ndedicated to the disk metadata cleanup. This to preserve the initial\nbehavior of \u0027start_iscsi_target\u0027. This command should be called before\n\u0027start_iscsi_target\u0027.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c963eea5af26b4564257f1cb8c27cbb86584ad08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c963eea5af26b4564257f1cb8c27cbb86584ad08"}]},"branch":"refs/heads/master"},"75711a8d649bbd1bed835a97b5af4eed0f22355e":{"kind":"REWORK","_number":12,"created":"2016-03-08 17:11:00.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/12"}}},"commit":{"parents":[{"commit":"1971ad7023389c6b9fa52c9837676419d7f53f97","subject":"Merge \"Reduced restriction of parsing for dmidecode output\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1971ad7023389c6b9fa52c9837676419d7f53f97"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-08 17:10:50.000000000","tz":-300},"subject":"image: add the ability to clean disk metadata","message":"image: add the ability to clean disk metadata\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nInstead of the initial patchset, we now add a \u0027wipe_root_device_metadata\u0027\ndedicated to the disk metadata cleanup. This to preserve the initial\nbehavior of \u0027start_iscsi_target\u0027. This command should be called before\n\u0027start_iscsi_target\u0027.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/75711a8d649bbd1bed835a97b5af4eed0f22355e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/75711a8d649bbd1bed835a97b5af4eed0f22355e"}]},"branch":"refs/heads/master"},"0498229880ce24f7aceab3063289ade117c73beb":{"kind":"REWORK","_number":13,"created":"2016-03-10 19:53:41.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/13"}}},"commit":{"parents":[{"commit":"944dc4e2480585a010bc5b21d6507c594beb69c8","subject":"CoreOS: Disable unused services","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/944dc4e2480585a010bc5b21d6507c594beb69c8"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-10 19:53:15.000000000","tz":-300},"subject":"image: add the ability to clean disk metadata","message":"image: add the ability to clean disk metadata\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nInstead of the initial patchset, we now add a \u0027wipe_root_device_metadata\u0027\ndedicated to the disk metadata cleanup. This to preserve the initial\nbehavior of \u0027start_iscsi_target\u0027. This command should be called before\n\u0027start_iscsi_target\u0027.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0498229880ce24f7aceab3063289ade117c73beb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0498229880ce24f7aceab3063289ade117c73beb"}]},"branch":"refs/heads/master"},"3210ce85cf0fa535bf866dc2d992913ea073390d":{"kind":"REWORK","_number":14,"created":"2016-03-18 21:14:50.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/14","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/14","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/14"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-18 21:14:42.000000000","tz":-240},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3210ce85cf0fa535bf866dc2d992913ea073390d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3210ce85cf0fa535bf866dc2d992913ea073390d"}]},"branch":"refs/heads/master"},"473ebbf84f5f320d09ad14e33d414b3806abf675":{"kind":"REWORK","_number":15,"created":"2016-03-19 22:12:11.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/15","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/15","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/15"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-19 22:10:21.000000000","tz":-240},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/473ebbf84f5f320d09ad14e33d414b3806abf675"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/473ebbf84f5f320d09ad14e33d414b3806abf675"}]},"branch":"refs/heads/master"},"367bf0f2eeeb4e87b39e7e4f370796100e7baf2a":{"kind":"REWORK","_number":16,"created":"2016-03-21 22:45:24.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/16","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/16","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/16 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/16 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/16 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/16"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-21 22:45:10.000000000","tz":-240},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/367bf0f2eeeb4e87b39e7e4f370796100e7baf2a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/367bf0f2eeeb4e87b39e7e4f370796100e7baf2a"}]},"branch":"refs/heads/master"},"b38020f168d1a3bc83f040afe549993b85dfaf97":{"kind":"REWORK","_number":17,"created":"2016-03-22 12:55:54.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/17","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/17","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/17 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/17 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/17 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/17"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-22 12:55:48.000000000","tz":-240},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b38020f168d1a3bc83f040afe549993b85dfaf97"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b38020f168d1a3bc83f040afe549993b85dfaf97"}]},"branch":"refs/heads/master"},"c8a88ae67c1dc9133d52ab3a9139ed60ee9e909c":{"kind":"REWORK","_number":18,"created":"2016-03-22 15:39:58.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/18","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/18","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/18 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/18 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/18 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/18"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-22 15:39:21.000000000","tz":-240},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c8a88ae67c1dc9133d52ab3a9139ed60ee9e909c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c8a88ae67c1dc9133d52ab3a9139ed60ee9e909c"}]},"branch":"refs/heads/master"},"668d3fb33047deacf15f4c86cdbe6a750b5ef290":{"kind":"REWORK","_number":19,"created":"2016-03-22 16:35:50.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/47/284347/19","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/19","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/19 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/19 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/19 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/19"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-22 16:35:36.000000000","tz":0},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/668d3fb33047deacf15f4c86cdbe6a750b5ef290"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/668d3fb33047deacf15f4c86cdbe6a750b5ef290"}]},"branch":"refs/heads/master"},"8212e51f3e0fd1e36f0d76a6ae1a8531319f9d41":{"kind":"REWORK","_number":20,"created":"2016-03-22 17:11:47.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/20","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/20","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/20 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/20 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/20 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/20"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-22 17:11:41.000000000","tz":-240},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8212e51f3e0fd1e36f0d76a6ae1a8531319f9d41"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8212e51f3e0fd1e36f0d76a6ae1a8531319f9d41"}]},"branch":"refs/heads/master"},"0b1f01db9474fb7630d616fab4711fefaea2bce0":{"kind":"REWORK","_number":21,"created":"2016-03-22 17:28:41.000000000","uploader":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"ref":"refs/changes/47/284347/21","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/284347/21","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/21 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/21 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/21 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/284347/21"}}},"commit":{"parents":[{"commit":"2a778f39e6151a94340c14dd012b30b9ffc52a1e","subject":"Merge \"Add support for partition images in agent driver.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2a778f39e6151a94340c14dd012b30b9ffc52a1e"}]}],"author":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-02-24 18:39:33.000000000","tz":-300},"committer":{"name":"Gonéri Le Bouder","email":"goneri@redhat.com","date":"2016-03-22 17:28:21.000000000","tz":-240},"subject":"iscsi: wipe part table before starting the target","message":"iscsi: wipe part table before starting the target\n\nIf the local disk has already a partition table, it must be clean up\nbefore the disk is exposed through iscsi. Otherwise this disk partition\ncan create a conflict during the grub installation.\n\nHow reproducible:\n\n1. Inject an image on the root disk, like for example ipxe.usb or ipxe.iso\n2. Try to deploy a system on the node using Ironic\n3. The node is properly deployed but the grub installation has failed\n   with the following error:\n     attempting to install grub to a disk with multiple partition labels\n\nA simple sgdisk -Z /dev/vdX is not enough because grub-install will\ninspect the disk and will still detect a remaining partition.\n\nThis commit makes use of the ironic-lib to do the clean up of the disk.\nThe additional review Id59fa5a06b9115c0f9afc09aae95daaac97e2fac increase\nthe amount of data to wipe.\n\nReferences:\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1310883\n\nPartial-Bug: 1550604\n\nChange-Id: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0b1f01db9474fb7630d616fab4711fefaea2bce0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0b1f01db9474fb7630d616fab4711fefaea2bce0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}